SatishChGit opened a new pull request, #36953:
URL: https://github.com/apache/airflow/pull/36953
Initial Implementation of Airflow Teradata Provider for Teradata - complete
cloud analytics and data platform. As part of initial release, Added below
functionalities.
1. Tera
sunilkmallam commented on PR #36953:
URL: https://github.com/apache/airflow/pull/36953#issuecomment-1904378584
Hi Airflow Community,
We've sent a proposal for Teradata being Airflow's new community provider.
After 72 hours of voting, we have _9 positive votes_ (4 binding and 5
non-bi
hussein-awala commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1462574940
##
.github/CODEOWNERS:
##
@@ -75,6 +75,7 @@ airflow/providers/cncf/kubernetes/executors/ @dstandish
@jedcunningham
/tests/system/providers/amazon/ @eladkal @o
sunilkmallam commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1462698853
##
.github/CODEOWNERS:
##
@@ -75,6 +75,7 @@ airflow/providers/cncf/kubernetes/executors/ @dstandish
@jedcunningham
/tests/system/providers/amazon/ @eladkal @o-
sunilkmallam commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1462699045
##
tests/providers/teradata/hooks/test_teradata.py:
##
@@ -0,0 +1,274 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1462750608
##
.github/CODEOWNERS:
##
@@ -75,6 +75,7 @@ airflow/providers/cncf/kubernetes/executors/ @dstandish
@jedcunningham
/tests/system/providers/amazon/ @eladkal @o-n
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1462750765
##
tests/providers/teradata/hooks/test_teradata.py:
##
@@ -0,0 +1,274 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
eladkal commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1463001545
##
airflow/providers/teradata/transfers/teradata_to_teradata.py:
##
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contr
sunilkmallam commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1463031416
##
airflow/providers/teradata/transfers/teradata_to_teradata.py:
##
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465001706
##
airflow/providers/teradata/transfers/teradata_to_teradata.py:
##
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465010521
##
airflow/providers/teradata/example_dags/example_teradata_to_teradata_transfer_operator.py:
##
@@ -0,0 +1,158 @@
+#
Review Comment:
system tests are defined
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465010521
##
airflow/providers/teradata/example_dags/example_teradata_to_teradata_transfer_operator.py:
##
@@ -0,0 +1,158 @@
+#
Review Comment:
system tests are defined
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465012016
##
airflow/providers/teradata/example_dags/example_teradata_operator.py:
##
@@ -0,0 +1,132 @@
+#
Review Comment:
system tests are defined under [system
](htt
eladkal commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465092920
##
airflow/providers/teradata/example_dags/example_teradata_operator.py:
##
@@ -0,0 +1,132 @@
+#
Review Comment:
All example dags will be converted to system test
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465178743
##
airflow/providers/teradata/transfers/teradata_to_teradata.py:
##
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465179800
##
airflow/providers/teradata/transfers/teradata_to_teradata.py:
##
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465186558
##
airflow/providers/teradata/example_dags/example_teradata_operator.py:
##
@@ -0,0 +1,132 @@
+#
Review Comment:
Got it. Do you want to remove example dags no
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1465186558
##
airflow/providers/teradata/example_dags/example_teradata_operator.py:
##
@@ -0,0 +1,132 @@
+#
Review Comment:
Got it. Is it required to remove these now or
SatishChGit commented on PR #36953:
URL: https://github.com/apache/airflow/pull/36953#issuecomment-1908478949
> Partial review for now
Addressed the review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
flolas commented on PR #36953:
URL: https://github.com/apache/airflow/pull/36953#issuecomment-1908984012
Hi @SatishChGit,
I think that many long-time Teradata users rely on BTEQ queries. How about
integrating a TtuHook ([Teradata tools and
utilities](https://downloads.teradata.com/downlo
flolas commented on PR #36953:
URL: https://github.com/apache/airflow/pull/36953#issuecomment-1908985410
Hi @SatishChGit,
I think that many long-time Teradata users rely on BTEQ queries. How about
in the future integrating a TtuHook ([Teradata tools and
utilities](https://downloads.terad
SatishChGit commented on PR #36953:
URL: https://github.com/apache/airflow/pull/36953#issuecomment-1909253980
> integrating
Thank you for this. We will check the possibility and will add in our
roadmap.
--
This is an automated message from the Apache Git Service.
To respond to the
sunilkmallam commented on PR #36953:
URL: https://github.com/apache/airflow/pull/36953#issuecomment-1912928299
> > Partial review for now
>
>
>
> Addressed the review comments.
Hi @eladkal, have you had a chance to review the changes we did?
--
This is an automated me
potiuk commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1468925306
##
airflow/providers/teradata/example_dags/example_teradata_operator.py:
##
@@ -0,0 +1,132 @@
+#
Review Comment:
example_dags = system_tests. The system tests have
potiuk commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1468925500
##
airflow/providers/teradata/example_dags/example_teradata_operator.py:
##
@@ -0,0 +1,132 @@
+#
Review Comment:
The problem with having SEPARATE example_dags is t
SatishChGit commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1469103806
##
airflow/providers/teradata/example_dags/example_teradata_operator.py:
##
@@ -0,0 +1,132 @@
+#
Review Comment:
okay thank you. Let me merge these and will k
josh-fell commented on code in PR #36953:
URL: https://github.com/apache/airflow/pull/36953#discussion_r1470489935
##
airflow/providers/teradata/example_dags/example_teradata_operator.py:
##
@@ -0,0 +1,132 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
27 matches
Mail list logo
