[PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2023-12-31 Thread via GitHub
kaxil opened a new pull request, #36517: URL: https://github.com/apache/airflow/pull/36517 **Motivation**: Currently, when using `airflow dags test`, there is no easy way to know programmatically if a DagRun fails since the state is not stored in DB. The way to do know relies on log

Re: [PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2023-12-31 Thread via GitHub
dirrao commented on PR #36517: URL: https://github.com/apache/airflow/pull/36517#issuecomment-1873176047 > I am a bit wondering why we add another CLI parameter. If the DAG test fails and exit code 0 is returned I'd rather see this as a bug. > > Is there a reason adding a new CLI para

Re: [PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2024-01-01 Thread via GitHub
potiuk commented on PR #36517: URL: https://github.com/apache/airflow/pull/36517#issuecomment-1873242002 Once concern is backwards compatibility (and I think that's where @kaxil's solution came from). But yeah, I think you are right @jscheffl @dirrao - probably return value is not **

Re: [PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2024-01-01 Thread via GitHub
jscheffl commented on PR #36517: URL: https://github.com/apache/airflow/pull/36517#issuecomment-1873268073 > Once concern is backwards compatibility (and I think that's where @kaxil's solution came from). > > But yeah, I think you are right @jscheffl @dirrao - probably return value i

Re: [PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2024-01-02 Thread via GitHub
kaxil commented on PR #36517: URL: https://github.com/apache/airflow/pull/36517#issuecomment-1873817303 >I am a bit wondering why we add another CLI parameter. If the DAG test fails and exit code 0 is returned I'd rather see this as a bug. Yeah I tried to think more on it to keep back

Re: [PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2024-01-02 Thread via GitHub
kaxil commented on PR #36517: URL: https://github.com/apache/airflow/pull/36517#issuecomment-1873821721 @jscheffl Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2024-01-02 Thread via GitHub
kaxil merged PR #36517: URL: https://github.com/apache/airflow/pull/36517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap