Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-15 Thread via GitHub
o-nikolas merged PR #39500: URL: https://github.com/apache/airflow/pull/39500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-15 Thread via GitHub
ferruzzi commented on PR #39500: URL: https://github.com/apache/airflow/pull/39500#issuecomment-2113133539 Ran it using the system test trigger script and it passes with the external sources getting skipped: ``` INFO [tests.system.utils] EXECUTION SUMMARY: ╒

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-14 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1600319579 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) # [

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1599301829 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) # [

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
o-nikolas commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1598853590 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) #

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1598842673 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) # [

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
o-nikolas commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1598821701 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) #

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1598804403 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) # [

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-09 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1596070383 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) # [

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-09 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1596065112 ## tests/providers/amazon/aws/operators/test_bedrock.py: ## @@ -346,3 +347,168 @@ def test_id_returned(self, mock_conn): result = self.operator.execute({})

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-09 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1596061831 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -664,3 +669,198 @@ def execute(self, context: Context) -> str: ) return ingestion

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-09 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1596061444 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -664,3 +669,198 @@ def execute(self, context: Context) -> str: ) return ingestion

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-09 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1596050868 ## docs/apache-airflow-providers-amazon/operators/bedrock.rst: ## @@ -174,6 +177,40 @@ To add data from an Amazon S3 bucket into an Amazon Bedrock Data Source, you

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-09 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1596046080 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -664,3 +669,198 @@ def execute(self, context: Context) -> str: ) return ingestion

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-09 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1596045184 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -664,3 +669,198 @@ def execute(self, context: Context) -> str: ) return ingestion

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-09 Thread via GitHub
o-nikolas commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1596032939 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -664,3 +669,198 @@ def execute(self, context: Context) -> str: ) return ingestio