[PR] Enable EksPodOperator deferrable [airflow]

2024-08-11 Thread via GitHub
jx2lee opened a new pull request, #41380: URL: https://github.com/apache/airflow/pull/41380 (TBD) closes: https://github.com/apache/airflow/issues/39685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-18 Thread via GitHub
jx2lee commented on code in PR #41380: URL: https://github.com/apache/airflow/pull/41380#discussion_r1720987537 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -1100,4 +1108,22 @@ def execute(self, context: Context): with eks_hook.generate_config_file(

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-19 Thread via GitHub
jx2lee commented on code in PR #41380: URL: https://github.com/apache/airflow/pull/41380#discussion_r1720987537 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -1100,4 +1108,22 @@ def execute(self, context: Context): with eks_hook.generate_config_file(

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-20 Thread via GitHub
o-nikolas commented on PR #41380: URL: https://github.com/apache/airflow/pull/41380#issuecomment-2299197837 I was under the impression this was already fixed by #41178 and the deferrable logic was inherited through the k8s pod operator itself. Were you testing with an older version of the p

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-23 Thread via GitHub
jx2lee commented on PR #41380: URL: https://github.com/apache/airflow/pull/41380#issuecomment-2307363389 @o-nikolas you're right. - the deferrable logic was inherited throught the k8s pod operator. ([execute](https://github.com/apache/airflow/blob/c0ffa9c5d96625c68ded9562632674ed366b5eb3/

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-23 Thread via GitHub
o-nikolas commented on PR #41380: URL: https://github.com/apache/airflow/pull/41380#issuecomment-2307471516 > @o-nikolas you're right. > > * Deferrable logic was inherited through the k8s pod operator. ([execute](https://github.com/apache/airflow/blob/c0ffa9c5d96625c68ded956263267

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-11 Thread via GitHub
jx2lee commented on PR #41380: URL: https://github.com/apache/airflow/pull/41380#issuecomment-2282661724 It was closed #41377 because the branch was renamed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-12 Thread via GitHub
vincbeck commented on code in PR #41380: URL: https://github.com/apache/airflow/pull/41380#discussion_r1713934095 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -1100,4 +1108,22 @@ def execute(self, context: Context): with eks_hook.generate_config_file(

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-12 Thread via GitHub
jx2lee commented on code in PR #41380: URL: https://github.com/apache/airflow/pull/41380#discussion_r1713955909 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -1100,4 +1108,22 @@ def execute(self, context: Context): with eks_hook.generate_config_file(

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-12 Thread via GitHub
vincbeck commented on code in PR #41380: URL: https://github.com/apache/airflow/pull/41380#discussion_r1713993250 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -1100,4 +1108,22 @@ def execute(self, context: Context): with eks_hook.generate_config_file(