ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1581853068
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +321,36 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1581736040
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +321,36 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1581585548
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +321,36 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1581163636
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +321,36 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1581083971
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +321,36 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1580501806
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +321,36 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1579880936
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +321,36 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
pankajastro merged PR #38536:
URL: https://github.com/apache/airflow/pull/38536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airf
Lee-W commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1575721005
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -74,7 +74,7 @@ class _VaultClient(LoggingMixin):
:param key_id: Key ID for Authentication (f
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1575653113
##
docs/apache-airflow-providers-hashicorp/secrets-backends/hashicorp-vault.rst:
##
@@ -217,6 +217,18 @@ Add "verify": "absolute path to ca-certificate file"
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1575653530
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -74,7 +74,7 @@ class _VaultClient(LoggingMixin):
:param key_id: Key ID for Authenticat
Lee-W commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1575592940
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -74,7 +74,7 @@ class _VaultClient(LoggingMixin):
:param key_id: Key ID for Authentication (f
ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1574621604
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -103,6 +104,7 @@ def __init__(
password: str | None = None,
key_id: str |
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1573322029
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -103,7 +108,11 @@ def __init__(
password: str | None = None,
key_id: str
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1573321715
##
airflow/providers/hashicorp/provider.yaml:
##
@@ -55,6 +55,7 @@ versions:
dependencies:
- apache-airflow>=2.6.0
- hvac>=1.1.0
+ - apache-airflow-provid
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1573321595
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +322,23 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
Lee-W commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1555990209
##
airflow/providers/hashicorp/provider.yaml:
##
@@ -55,6 +55,7 @@ versions:
dependencies:
- apache-airflow>=2.6.0
- hvac>=1.1.0
+ - apache-airflow-providers-am
ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1555877716
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +322,23 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1555273271
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +322,23 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1554430225
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -318,15 +322,23 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
pankajastro commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1543545322
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -103,7 +108,11 @@ def __init__(
password: str | None = None,
key_id: str
Taragolis commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1541468429
##
airflow/providers/hashicorp/_internal_client/vault_client.py:
##
@@ -103,7 +108,11 @@ def __init__(
password: str | None = None,
key_id: str |
pankajastro opened a new pull request, #38536:
URL: https://github.com/apache/airflow/pull/38536
This PR expose below missing param in hashicorp secret for aws auth
- session_token
- header_value
- use_token
- region
https://github.com/hvac/hvac/blob/48027db42c037fe8f6b1c6
23 matches
Mail list logo
