bolkedebruin merged PR #37168:
URL: https://github.com/apache/airflow/pull/37168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@air
bolkedebruin commented on PR #37168:
URL: https://github.com/apache/airflow/pull/37168#issuecomment-1948021295
> We do need to specify the classname, which should be "builtins.tuple":
>
> The `serialize` method (in
[airflow/serialization/serializers/builtin.py](https://github.com/apac
Joffreybvn commented on PR #37168:
URL: https://github.com/apache/airflow/pull/37168#issuecomment-1946307574
CI-CD is failing because the generated classname is the name of the
namedtuple, instead of "builtins.tuple".
Do we want to serialize the namedtuple like tuples ? If yes, we need to
potiuk commented on PR #37168:
URL: https://github.com/apache/airflow/pull/37168#issuecomment-1946279357
Hey @joffreyvbn @bolkedebruin - any chance to get it soon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Joffreybvn commented on PR #37168:
URL: https://github.com/apache/airflow/pull/37168#issuecomment-1941624178
We do need to specify the classname, which should be "builtins.tuple":
The `serialize` method (in
[airflow/serialization/serializers/builtin.py](https://github.com/apache/airf
bolkedebruin commented on code in PR #37168:
URL: https://github.com/apache/airflow/pull/37168#discussion_r1487739235
##
airflow/serialization/serde.py:
##
@@ -134,19 +134,25 @@ def serialize(o: object, depth: int = 0) -> U | None:
cls = type(o)
qn = qualname(o)
+
Joffreybvn commented on code in PR #37168:
URL: https://github.com/apache/airflow/pull/37168#discussion_r1483856992
##
airflow/serialization/serde.py:
##
@@ -147,6 +147,13 @@ def serialize(o: object, depth: int = 0) -> U | None:
if is_serialized:
return enc
Joffreybvn commented on code in PR #37168:
URL: https://github.com/apache/airflow/pull/37168#discussion_r1483855868
##
airflow/serialization/serde.py:
##
@@ -337,6 +344,11 @@ def _is_pydantic(cls: Any) -> bool:
return hasattr(cls, "model_config") and hasattr(cls, "model_fie
Joffreybvn commented on PR #37168:
URL: https://github.com/apache/airflow/pull/37168#issuecomment-1935299982
Sorry, busy week. I'm on it !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
bolkedebruin commented on PR #37168:
URL: https://github.com/apache/airflow/pull/37168#issuecomment-1933626917
ping @Joffreybvn :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
bolkedebruin commented on code in PR #37168:
URL: https://github.com/apache/airflow/pull/37168#discussion_r1478045494
##
airflow/serialization/serde.py:
##
@@ -147,6 +147,13 @@ def serialize(o: object, depth: int = 0) -> U | None:
if is_serialized:
return e
Joffreybvn opened a new pull request, #37168:
URL: https://github.com/apache/airflow/pull/37168
namedtuple is serialized like 'builtins.tuple'
This PR fix two issues:
- namedtuple fails to serialize (#36839) when nested in a complex data
structure - typically when u
12 matches
Mail list logo
