hussein-awala merged PR #35185:
URL: https://github.com/apache/airflow/pull/35185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1824891188
Finally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-182483
> I guess later we can add multi-namespace mode to run in CI. We likely do
not want to add another dimention for k8s tests but we can do what we do in
databases with some kind of
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1824872772
I guess later we can add multi-namespace mode to run in CI. We likely do not
want to add another dimention for k8s tests but we can do what we do in
databases with some kind of rotating
hussein-awala commented on code in PR #35185:
URL: https://github.com/apache/airflow/pull/35185#discussion_r1403682530
##
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##
@@ -1036,8 +1047,47 @@ def _deploy_airflow(
executor=executor,
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1810937222
Oh. What was it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1810885684
K8S tests are green, I will move the helm chart changes to a separate PR and
provide a small patch for these tests instead.
--
This is an automated message from the Apache Git
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1806765381
And BTW. My wild guess - without looking at the changes/code is that this is
some kind of race condition - where the service account is either not created
yet or maybe while being
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1806752378
> Thanks @potiuk! I will check why I don't have the same issue in local.
>
> I will update the breeze command to create this serviceaccount
>
> > error looking up service
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1806570752
Thanks @potiuk! I will check why I don't have the same issue in local.
I will update the breeze command to create this serviceaccount
> error looking up service account
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1806397361
Just go to "Summary" and scroll down to see the artifacts
https://github.com/apache/airflow/actions/runs/6827578309?pr=35185
--
This is an automated message from the Apache Git
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1806394641
The artifacts containing log dumps from kind have more information on the
root cause
If you download the artifacts and look at the logs you will find this (in
one of the
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1806077600
Can you reabase again/resolve conflicts please ? The artifacts have expired
now - so we cannot even see what happened in the logs of K8s here.
--
This is an automated message from the
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1804748263
> My best guess is that this is what is failing:
>
>
jedcunningham commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1803252298
My best guess is that this is what is failing:
eladkal commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1793042604
@hussein-awala were you able to find some info about the problem? I tried
also to check the logs but couldn't find the root cause for the failures
--
This is an automated message
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1786332204
BTW. Those tests are pretty stable in general, so it's quite for sure some
effect of those changes.
--
This is an automated message from the Apache Git Service.
To respond to the
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1786330950
> I already reproduced all the steps on two different computers step by
step, and I also tested `run-complete-tests`, in both cases, the tests finished
successfully.
Oh I missed
hussein-awala closed pull request #35225: Fix K8S executor override config
using pod_override_object
URL: https://github.com/apache/airflow/pull/35225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1783916472
FYI. I removed the "full tests needed" and rebased to check if there is
indeed an issue that "K8S System tests" are not triggered for such PR - I think
they should be - looking at
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1783612383
> I guess changing timeout will not work here. This looks like a real
problem introduced by the change - k8s executor stops working and it should be
investigated. It's rather
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1783610243
I guess changing timeout will not work here. This looks like a real problem
introduced by the change - k8s executor stops working and it should be
investigated. It's rather easy to
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1783541285
But let's see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1783540723
This branch is [4 commits
ahead](https://github.com/hussein-awala/airflow/compare/apache:airflow:main...fix/k8s_executor_ns_override),
[18 commits
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1783518870
@potiuk, do you have an idea why the K8S executor tests failed? I tested
locally with Mac arm and Linux amd, the tests finished successfully.
--
This is an automated message
hussein-awala closed pull request #35225: Fix K8S executor override config
using pod_override_object
URL: https://github.com/apache/airflow/pull/35225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hussein-awala opened a new pull request, #35225:
URL: https://github.com/apache/airflow/pull/35225
Try to run the CI for #35185 from an airflow branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1781786310
I'm still trying to reproduce the tests failure locally:
```
test_kubernetes_executor.py::TestKubernetesExecutor::test_integration_run_dag
PASSED
eladkal commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1780370460
Helm tests are failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
eladkal commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1780076435
I am not sure why helm chart tests are skipped here cc @potiuk
In previous attempt to address the issue
https://github.com/apache/airflow/pull/34505 we had failing helm tests so I
eladkal closed pull request #35185: Fix K8S executor override config using
pod_override_object
URL: https://github.com/apache/airflow/pull/35185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hussein-awala opened a new pull request, #35185:
URL: https://github.com/apache/airflow/pull/35185
related: #22298
Currently, we don't use all the configs from `pod_override_object` where we
override some of them by the default K8S executor configurations or the kube
config file
32 matches
Mail list logo
