Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-11-12 Thread via GitHub
potiuk merged PR #35181: URL: https://github.com/apache/airflow/pull/35181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-11-01 Thread via GitHub
potiuk commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1789835536 > Yes @potiuk I've verified all cases and works without any issue Which cases? out of curiosity? Do you know exactly what causes the problem in the first place? -- This is an

Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-11-01 Thread via GitHub
pavansharma36 commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1789123954 Yes @potiuk I've verified all cases and works without any issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-11-01 Thread via GitHub
potiuk commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1789103071 Deleted my comment by mistake - but you can likely see it in notification. Generally I am ok with reinitializing as long as we do not have any side effects. Have you looked at those abd

Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-11-01 Thread via GitHub
potiuk commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1789083878 > @potiuk I believe that is unnecessary complicating things as not all process are opening stats socket before daemonize, > plus there can be different impl we need to take care and

Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-11-01 Thread via GitHub
pavansharma36 commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1789065292 @potiuk I believe that is unnecessary complicating things as not all process are opening stats socket before daemonize, plus there can be different impl we need to take care

Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-11-01 Thread via GitHub
potiuk commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1788770992 > This doesn't flush the existing metrics when you create a new instance? For example, graphs still have their data from before the flush?? I believe there are virtually no

Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-10-30 Thread via GitHub
ferruzzi commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1786102641 This doesn't flush the existing metrics when you create a new instance? For example, graphs still have their data from before the flush?? -- This is an automated message from the

Re: [PR] Fix Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1784126920 I see no big problem with it and I see why it could be needed, but I would love someone else to take a look as well @Taragolis @uranusjr @ferruzzi ? Seems to me that this could