potiuk commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1422794159
##
airflow/serialization/serde.py:
##
@@ -360,7 +360,7 @@ def _register():
@functools.lru_cache(maxsize=None)
def _get_patterns() -> list[Pattern]:
patterns = c
tobiaszorzetto commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1423167103
##
airflow/serialization/serde.py:
##
@@ -360,7 +360,7 @@ def _register():
@functools.lru_cache(maxsize=None)
def _get_patterns() -> list[Pattern]:
patt
tobiaszorzetto commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1423167103
##
airflow/serialization/serde.py:
##
@@ -360,7 +360,7 @@ def _register():
@functools.lru_cache(maxsize=None)
def _get_patterns() -> list[Pattern]:
patt
bolkedebruin commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1425102889
##
airflow/serialization/serde.py:
##
@@ -360,7 +360,7 @@ def _register():
@functools.lru_cache(maxsize=None)
def _get_patterns() -> list[Pattern]:
patter
potiuk commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1853617581
> Although alternatively a allowed_serialization_classes could be the glob
version and allowed_serialization_classes_regexp could be the regexp version.
> Could that work?
tobiaszorzetto commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1426051902
##
airflow/serialization/serde.py:
##
@@ -360,7 +360,7 @@ def _register():
@functools.lru_cache(maxsize=None)
def _get_patterns() -> list[Pattern]:
patt
potiuk commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1426809710
##
airflow/serialization/serde.py:
##
@@ -360,7 +360,7 @@ def _register():
@functools.lru_cache(maxsize=None)
def _get_patterns() -> list[Pattern]:
patterns = c
potiuk commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1426814072
##
airflow/serialization/serde.py:
##
@@ -360,7 +360,7 @@ def _register():
@functools.lru_cache(maxsize=None)
def _get_patterns() -> list[Pattern]:
patterns = c
tobiaszorzetto commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1429283240
##
airflow/serialization/serde.py:
##
@@ -360,7 +360,7 @@ def _register():
@functools.lru_cache(maxsize=None)
def _get_patterns() -> list[Pattern]:
patt
eladkal commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1430070203
##
airflow/config_templates/config.yml:
##
@@ -241,11 +241,20 @@ core:
allowed_deserialization_classes:
description: |
What classes can be import
bolkedebruin commented on code in PR #36147:
URL: https://github.com/apache/airflow/pull/36147#discussion_r1430388614
##
airflow/serialization/serde.py:
##
@@ -288,7 +287,26 @@ def _convert(old: dict) -> dict:
def _match(classname: str) -> bool:
-return any(p.match(clas
tobiaszorzetto commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1863701178
> Following @bolkedebruin's performance comment. I think we could improve
caching and perforrmance much more there:
>
> 1. the _get_patterns should returned compiled regexp
potiuk commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1863726693
> Hey @potiuk! we have implemented these changes :). However, I'm thinking
if maybe the lru_caches for the _get_patterns fuctions may be unecessary as the
_match fuctions, which are the
potiuk commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1863728194
Just spelchecking /docs needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
VictorDominguite commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1863766189
> Just spelchecking /docs needs to be fixed.
Hi @potiuk! First of all, we'd like to thank you for the explanation about
the caches, it's all clearer now :) . Second of al
potiuk commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1864240921
I rebased your PR. There were some changes to auth-manager docs structure
recently and it works in the way that if you have not rebased, such changes in
document structure might cause d
potiuk commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1864241872
Generally - as a rule - if you see unrelated error, rebase to see if this is
not a result of being behind `main`
--
This is an automated message from the Apache Git Service.
To respond
potiuk commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1865311363
@bolkedebruin ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tobiaszorzetto commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1888272425
Hey @potiuk ! Sorry for the ask, but I was wondering if there was a way to
accelerate the process of closing this PR. Thanks!
--
This is an automated message from the Apache G
bolkedebruin commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1890483168
Good point. I got sidetracked on this one. I'll take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bolkedebruin merged PR #36147:
URL: https://github.com/apache/airflow/pull/36147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@air
boring-cyborg[bot] commented on PR #36147:
URL: https://github.com/apache/airflow/pull/36147#issuecomment-1903681950
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
22 matches
Mail list logo
