romsharon98 merged PR #41054:
URL: https://github.com/apache/airflow/pull/41054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airf
shahar1 commented on PR #41054:
URL: https://github.com/apache/airflow/pull/41054#issuecomment-2262251870
> @shahar1 any further comments?
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
eladkal commented on PR #41054:
URL: https://github.com/apache/airflow/pull/41054#issuecomment-2262196942
@shahar1 any further comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
shahar1 commented on PR #41054:
URL: https://github.com/apache/airflow/pull/41054#issuecomment-2254591785
Looks better :) tests fail though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
romsharon98 commented on code in PR #41054:
URL: https://github.com/apache/airflow/pull/41054#discussion_r1694218619
##
airflow/providers/apprise/notifications/apprise.py:
##
@@ -52,9 +51,9 @@ def __init__(
*,
body: str,
title: str | None = None,
-
shahar1 commented on code in PR #41054:
URL: https://github.com/apache/airflow/pull/41054#discussion_r1693417148
##
airflow/providers/apprise/notifications/apprise.py:
##
@@ -52,9 +51,9 @@ def __init__(
*,
body: str,
title: str | None = None,
-
romsharon98 opened a new pull request, #41054:
URL: https://github.com/apache/airflow/pull/41054
closes: https://github.com/apache/airflow/pull/38593/
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apach
github-actions[bot] closed pull request #38593: Fix default behaviour for init
function in `AppriseNotifier`
URL: https://github.com/apache/airflow/pull/38593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #38593:
URL: https://github.com/apache/airflow/pull/38593#issuecomment-2234848922
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
eladkal commented on PR #38593:
URL: https://github.com/apache/airflow/pull/38593#issuecomment-2105600969
@rrr2rrr can you please fix the test?
`FAILED
tests/providers/apprise/notifications/test_apprise.py::TestAppriseNotifier::test_notifier
- AssertionError: expected call not found.`
rrr2rrr commented on code in PR #38593:
URL: https://github.com/apache/airflow/pull/38593#discussion_r1560478523
##
airflow/providers/apprise/hooks/apprise.py:
##
@@ -71,7 +72,7 @@ def notify(
title: str | None = None,
notify_type: NotifyType = NotifyType.INFO,
rrr2rrr commented on code in PR #38593:
URL: https://github.com/apache/airflow/pull/38593#discussion_r1560474269
##
airflow/providers/apprise/hooks/apprise.py:
##
@@ -71,7 +72,7 @@ def notify(
title: str | None = None,
notify_type: NotifyType = NotifyType.INFO,
dirrao commented on code in PR #38593:
URL: https://github.com/apache/airflow/pull/38593#discussion_r1545289958
##
airflow/providers/apprise/hooks/apprise.py:
##
@@ -71,7 +72,7 @@ def notify(
title: str | None = None,
notify_type: NotifyType = NotifyType.INFO,
eladkal commented on PR #38593:
URL: https://github.com/apache/airflow/pull/38593#issuecomment-2027959962
Tests are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
14 matches
Mail list logo
