Re: [PR] Fix handling selective docs builds for "special" packages [airflow]

2023-10-21 Thread via GitHub
potiuk merged PR #35102: URL: https://github.com/apache/airflow/pull/35102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Fix handling selective docs builds for "special" packages [airflow]

2023-10-21 Thread via GitHub
potiuk commented on PR #35102: URL: https://github.com/apache/airflow/pull/35102#issuecomment-1773834304 I found also a duplication @Taragolis @amoghrajesh -> so the docs build params used their own version of converting from short-hand to filters, and I know made them common. -- This i

Re: [PR] Fix handling selective docs builds for "special" packages [airflow]

2023-10-21 Thread via GitHub
potiuk commented on code in PR #35102: URL: https://github.com/apache/airflow/pull/35102#discussion_r1367747958 ## dev/breeze/src/airflow_breeze/params/doc_build_params.py: ## @@ -20,20 +20,30 @@ from dataclasses import dataclass from airflow_breeze.branch_defaults import AI

Re: [PR] Fix handling selective docs builds for "special" packages [airflow]

2023-10-21 Thread via GitHub
amoghrajesh commented on code in PR #35102: URL: https://github.com/apache/airflow/pull/35102#discussion_r1367747019 ## dev/breeze/src/airflow_breeze/params/doc_build_params.py: ## @@ -20,20 +20,30 @@ from dataclasses import dataclass from airflow_breeze.branch_defaults impo

[PR] Fix handling selective docs builds for "special" packages [airflow]

2023-10-21 Thread via GitHub
potiuk opened a new pull request, #35102: URL: https://github.com/apache/airflow/pull/35102 The #35069 and #35087 that switched from `--package-filter` to shorthand package names in CI did not handle all the cases - special package names such as "apache-airflow" or "helm-chart" were treated