potiuk commented on PR #35252:
URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784275810
> But reading comments in https://github.com/apache/airflow/pull/35258 hope
it is okay to revert the termination log fix.
Absolutely. As if "replace with generated dir which makes
jens-scheffler-bosch commented on PR #35252:
URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784274264
> > Termination log is just "one" thin but I now just realized that all venv
script input, output, logs and temp files are also created in the venv cache
folder. This is
potiuk commented on PR #35252:
URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784257754
> Sorry, I was off during the day and just now this PR jumped into my eyes.
Reading the fix description and looking through the code I fear we have a more
severe problem that we
jens-scheffler-bosch commented on PR #35252:
URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784237922
Sorry, I was off during the day and just now this PR jumped into my eyes.
Reading the fix description and looking through the code I fear we have a more
severe problem
potiuk merged PR #35252:
URL: https://github.com/apache/airflow/pull/35252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on PR #35252:
URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784057135
(Real error this time) It was found when I optimized tests by using caching.
cc: @jens-scheffler-bosch :).. Very interesting side-effect - I think you
should check in your
potiuk opened a new pull request, #35252:
URL: https://github.com/apache/airflow/pull/35252
When PythonVirtualEnv and friends use cached venv, script and termination
logs are stored in the venv. While this was fine for logs because the env is
locked and scripts were overwritten every time
