bolkedebruin merged PR #36199:
URL: https://github.com/apache/airflow/pull/36199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@air
ephraimbuddy commented on PR #36199:
URL: https://github.com/apache/airflow/pull/36199#issuecomment-1854168090
> Im working on it but I'm also not feeling so well. So I'm a bit slow.
Sorry about that. Take it easy
--
This is an automated message from the Apache Git Service.
To respo
bolkedebruin commented on PR #36199:
URL: https://github.com/apache/airflow/pull/36199#issuecomment-1854149920
Give me an hour or so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bolkedebruin commented on PR #36199:
URL: https://github.com/apache/airflow/pull/36199#issuecomment-1854149379
Im working on it but I'm also not feeling so well. So I'm a bit slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
ephraimbuddy commented on PR #36199:
URL: https://github.com/apache/airflow/pull/36199#issuecomment-1854082541
Anyone working on this or should we leave it for 2.8.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ephraimbuddy commented on PR #36199:
URL: https://github.com/apache/airflow/pull/36199#issuecomment-1853786826
> Much more complete. @ephraimbuddy - if we have a chance to get it into RC2
still (or RC3 is on the horizon) this one is very good candidate.
I have already released RC2. Ma
uranusjr commented on code in PR #36199:
URL: https://github.com/apache/airflow/pull/36199#discussion_r1425204152
##
airflow/io/__init__.py:
##
@@ -93,11 +93,18 @@ def get_fs(
raise ValueError(f"No filesystem registered for scheme {scheme}") from
None
options =
bolkedebruin commented on code in PR #36199:
URL: https://github.com/apache/airflow/pull/36199#discussion_r1425198778
##
airflow/io/__init__.py:
##
@@ -93,11 +93,18 @@ def get_fs(
raise ValueError(f"No filesystem registered for scheme {scheme}") from
None
option
uranusjr commented on code in PR #36199:
URL: https://github.com/apache/airflow/pull/36199#discussion_r1425190267
##
airflow/io/__init__.py:
##
@@ -93,11 +93,18 @@ def get_fs(
raise ValueError(f"No filesystem registered for scheme {scheme}") from
None
options =
potiuk commented on code in PR #36199:
URL: https://github.com/apache/airflow/pull/36199#discussion_r1425184231
##
tests/io/test_path.py:
##
@@ -300,3 +301,6 @@ def test_backwards_compat(self):
with pytest.raises(AttributeError):
get_fs("file", storage_op
potiuk commented on code in PR #36199:
URL: https://github.com/apache/airflow/pull/36199#discussion_r1425181498
##
tests/io/test_path.py:
##
@@ -300,3 +301,6 @@ def test_backwards_compat(self):
with pytest.raises(AttributeError):
get_fs("file", storage_op
potiuk commented on code in PR #36199:
URL: https://github.com/apache/airflow/pull/36199#discussion_r1425181498
##
tests/io/test_path.py:
##
@@ -300,3 +301,6 @@ def test_backwards_compat(self):
with pytest.raises(AttributeError):
get_fs("file", storage_op
potiuk commented on code in PR #36199:
URL: https://github.com/apache/airflow/pull/36199#discussion_r1425180013
##
tests/io/test_path.py:
##
@@ -300,3 +301,6 @@ def test_backwards_compat(self):
with pytest.raises(AttributeError):
get_fs("file", storage_op
bolkedebruin opened a new pull request, #36199:
URL: https://github.com/apache/airflow/pull/36199
Older providers do not have a get_fs method that takes storage_options as
arguments. If we encounter such provider and storage_options are passed we
should error out instead if silently ignorin
14 matches
Mail list logo
