josh-fell merged PR #30176:
URL: https://github.com/apache/airflow/pull/30176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
josh-fell commented on code in PR #30176:
URL: https://github.com/apache/airflow/pull/30176#discussion_r1428855485
##
docs/apache-airflow/howto/operator/bash.rst:
##
@@ -23,126 +23,324 @@ BashOperator
Use the :class:`~airflow.operators.bash.BashOperator` to exec
potiuk commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1845330672
> I would argue if you need logic it is better to create a shell script file
and use templating to pass in the values instead. Trying to generate a shell
command with Python code—or more
uranusjr commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1845026632
I would argue if you need logic it is better to create a shell script file
and use templating to pass in the values instead. Trying to generate a shell
command with Python code—or more
potiuk commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1844405774
> We can absolutely add a note to the docs that using the f-string approach
is encouraged. I completely agree it's more "Pythonic" and fits better in the
TaskFlow paradigm.
Fine w
josh-fell commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1844117044
We can absolutely add a note to the docs that using the f-string approach is
encouraged. I completely agree it's more "Pythonic" and fits better in the
TaskFlow context/authoring.
-
josh-fell commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1844102050
> Disabke it by default add ad parameter is_templated?
>
> WHY?
>
> I think the reason why we want it templated is to allow people to convert
old operators easily but I t
potiuk commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1833409643
Disabke it by default add ad parameter is_templated?
away?
I think the reason why we ant it templated is to allow people to convert old
operators easily but I think with pu
potiuk commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1833410060
Disabke it by default add ad parameter is_templated?
WHY?
I think the reason why we ant it templated is to allow people to convert old
operators easily but I think with put
potiuk commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1833406532
Disabke it by default add ad parameter is_templated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
josh-fell commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1833047011
One question I do have is should the `bash_command` attribute (aka the
return value from the callable) be templated? Clearly `BashOperator` has this
now, but with TaskFlow historicall
josh-fell commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1831182350
@potiuk Just about summed everything I was thinking! I completely agree
being able to enrich Bash with Python is strong. Also, it's a more
straightforward approach to parametrize the
potiuk commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1830969268
> @potiuk I can confirm this works for multi-line strings.
My comment was rather about "why do we need method at all?" (following
@uranusjr comment.
For me the proposed synt
josh-fell commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1828970904
Reviving this after finally getting out of a large hole.
@fritz-astronomer Yes, this approach is very much inspired by the Astro SDK.
@potiuk I can confirm this works for
github-actions[bot] commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1826152395
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] commented on PR #30176:
URL: https://github.com/apache/airflow/pull/30176#issuecomment-1754095136
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
16 matches
Mail list logo
