syun64 opened a new pull request, #36024:
URL: https://github.com/apache/airflow/pull/36024
closes #32816
### Summary
This PR introduces Dag SLAs as a part of **AIP-57 Refactor SLA Feature**.
After many discussions, the community has voted to introduce new
syun64 opened a new pull request, #36639:
URL: https://github.com/apache/airflow/pull/36639
closes #32816
### Summary
This PR introduces Dag SLAs as a part of **AIP-57 Refactor SLA Feature**.
After many discussions, the community has voted to introduce new
syun64 commented on code in PR #36024:
URL: https://github.com/apache/airflow/pull/36024#discussion_r1412846622
##
tests/ti_deps/deps/test_not_previously_skipped_dep.py:
##
@@ -113,7 +113,7 @@ def test_parent_skip_branch(session, dag_maker):
"""
A simple DAG with a Bra
syun64 closed pull request #36024: Introduce Dag sla
URL: https://github.com/apache/airflow/pull/36024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
syun64 commented on PR #36024:
URL: https://github.com/apache/airflow/pull/36024#issuecomment-1879890262
A new pull request had to be made because this the Git Diff got messy on
this open PR after a git rebase based on current upstream main branch. The new
PR based on the same branch is ope
syun64 commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-1880146129
@dstandish @potiuk could I ask for your review on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dstandish commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-2021080626
@syun64 sorry that i have not been active on this for a while. my concern
is that i don't think it's an SLA if it's evaluated against "when it started"
-- i think an SLA is about "wh
github-actions[bot] commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-1984819526
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
michael-robbins-seek commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-1992960089
Will this DAG SLA be compatible at all with Data-aware scheduled dags?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
mtsadler-branch commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-2286480818
@dstandish are you proposing to simply replace `start_date` with
`data_interval_start` in this PR's code changes?
--
This is an automated message from the Apache Git Service.
dstandish commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-2286652488
> @dstandish are you proposing to simply replace `start_date` with
`data_interval_start` in this PR's code changes?
I am not sure that interval start is the time when it's expec
uranusjr commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-2287944474
The `run_after` value in `DagRunInfo` is probably the best for this purpose,
but I’m not sure if it is available in this context.
--
This is an automated message from the Apache Git
ferruzzi commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-2289461751
As @dstandish mentioned/alluded, for Airflow 3 (Coming Soon :tm:) we intend
to do a complete overhaul of the existing SLA system so I'm not sure there is
any benefit to reviving this P
dstandish commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-1904759235
why do we rename `sla_miss_callback` to `on_ sla_miss_callback`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
syun64 commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-1904979195
> why do we rename `sla_miss_callback` to `on_ sla_miss_callback`?
We aren't renaming it, it's a different feature entirely.
`sla_miss_callback` is the callback for the existing SL
github-actions[bot] commented on PR #36639:
URL: https://github.com/apache/airflow/pull/36639#issuecomment-2126272152
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
16 matches
Mail list logo
