Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

uranusjr commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1508602289 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,22 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __or__(self, other:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1508591928 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,22 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __or__(self, other:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1508510791 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,22 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __or__(self, other:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1508510791 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,22 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __or__(self, other:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1508510791 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,22 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __or__(self, other:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

dstandish commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1507906113 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,22 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __or__(self, other:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

dstandish commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1507904437 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,22 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __or__(self, other:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

phanikumv merged PR #37101: URL: https://github.com/apache/airflow/pull/37101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

jedcunningham commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500828291 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500478161 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500450827 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500370517 ## airflow/jobs/scheduler_job_runner.py: ## Review Comment: I have

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500363667 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,91 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

Lee-W commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500359710 ## tests/datasets/test_dataset.py: ## @@ -269,3 +269,70 @@ def test_dag_with_complex_dataset_triggers(session, dag_maker): assert isinstance(

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500340787 ## tests/datasets/test_dataset.py: ## @@ -269,3 +269,70 @@ def test_dag_with_complex_dataset_triggers(session, dag_maker): assert isinstance(

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500339341 ## tests/datasets/test_dataset.py: ## @@ -269,3 +269,70 @@ def test_dag_with_complex_dataset_triggers(session, dag_maker): assert isinstance(

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500292451 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500292042 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500291884 ## airflow/datasets/__init__.py: ## @@ -73,6 +73,12 @@ def __eq__(self, other): def __hash__(self): return hash(self.uri) +def __or__(self,

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500291702 ## airflow/datasets/__init__.py: ## @@ -73,6 +73,12 @@ def __eq__(self, other): def __hash__(self): return hash(self.uri) +def __or__(self,

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500260607 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

Lee-W commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500235447 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,91 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects: Dataset

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

uranusjr commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500240334 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

uranusjr commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500240073 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

uranusjr commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500239430 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500225342 ## docs/apache-airflow/authoring-and-scheduling/timetable.rst: ## @@ -212,9 +212,29 @@ Here's an example of a DAG using ``DatasetTimetable``: In this example,

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1500222490 ## docs/apache-airflow/authoring-and-scheduling/datasets.rst: ## @@ -237,6 +237,85 @@ Example: Note that this example is using `(.values() | first | first)

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

dstandish commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499742378 ## airflow/jobs/scheduler_job_runner.py: ## Review Comment: the changes to this file were in a previous version of my foundation PR, checking one at a time

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

dstandish commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499734230 ## airflow/datasets/__init__.py: ## @@ -106,8 +112,90 @@ class DatasetAny(_DatasetBooleanCondition): agg_func = any +def __init__(self, *objects:

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

jedcunningham commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499600781 ## docs/apache-airflow/authoring-and-scheduling/datasets.rst: ## @@ -237,6 +237,85 @@ Example: Note that this example is using `(.values() | first | first)

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499043899 ## docs/apache-airflow/authoring-and-scheduling/datasets.rst: ## @@ -237,6 +237,85 @@ Example: Note that this example is using `(.values() | first | first)

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499033361 ## airflow/models/dataset.py: ## @@ -374,12 +386,96 @@ def all_datasets(self) -> dict[str, Dataset]: class DatasetAny(DatasetBooleanCondition): -"""Use to

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499032959 ## airflow/models/dataset.py: ## @@ -374,12 +386,96 @@ def all_datasets(self) -> dict[str, Dataset]: class DatasetAny(DatasetBooleanCondition): -"""Use to

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499015986 ## airflow/models/dataset.py: ## @@ -374,12 +386,96 @@ def all_datasets(self) -> dict[str, Dataset]: class DatasetAny(DatasetBooleanCondition): -"""Use to

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499010581 ## airflow/models/dataset.py: ## @@ -374,12 +386,96 @@ def all_datasets(self) -> dict[str, Dataset]: class DatasetAny(DatasetBooleanCondition): -"""Use to

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1499009478 ## tests/models/test_datasets.py: ## @@ -0,0 +1,87 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1498995225 ## airflow/datasets/__init__.py: ## @@ -55,3 +55,13 @@ def __eq__(self, other): def __hash__(self): return hash(self.uri) + +def __or__(self,

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

Lee-W commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1498745854 ## airflow/models/dataset.py: ## @@ -341,9 +341,9 @@ def __repr__(self) -> str: class DatasetBooleanCondition: """ -Base class for boolean logic for

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on PR #37101: URL: https://github.com/apache/airflow/pull/37101#issuecomment-1958753213 > As #37016 has been merged, I think we might need to rebase from the main branch and resolve the conflicts before we can review it. Done. Please review @Lee-W -- This is

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

sunank200 commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1498675285 ## airflow/models/dag.py: ## @@ -585,6 +587,8 @@ def __init__( self.timetable: Timetable self.schedule_interval: ScheduleInterval

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

Lee-W commented on PR #37101: URL: https://github.com/apache/airflow/pull/37101#issuecomment-1958591897 As https://github.com/apache/airflow/pull/37016 has been merged, I think we might need to rebase from the main branch and resolve the conflicts before we can review it. -- This is an

Re: [PR] Introducing Logical Operators for dataset conditional logic [airflow]

uranusjr commented on code in PR #37101: URL: https://github.com/apache/airflow/pull/37101#discussion_r1472562902 ## airflow/models/dag.py: ## @@ -585,6 +587,8 @@ def __init__( self.timetable: Timetable self.schedule_interval: ScheduleInterval