dstandish merged PR #38992:
URL: https://github.com/apache/airflow/pull/38992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2130348286
@potiuk i'll just go ahead and merge this now so i can close out all the PRs
waiting on it. if you later want to look i'm happy to take your suggestions
and make changes afterwards.
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1612108927
##
airflow/models/taskinstance.py:
##
@@ -504,6 +791,34 @@ def _execute_callable(context: Context,
**execute_callable_kwargs):
return result
+def _set_ti_
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2120823774
also for reference @jscheffl here's the PRs that came before on this one 😅
https://github.com/apache/airflow/pulls?q=is%3Apr+project%3Aapache%2F169+is%3Aclosed
--
This is an
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2120822126
> So as you cherry-pick into smaller PRs and leaving complexity
manageable... if all is green might still be good to merge the pieces and I
assume to make it working then a few other
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2120816036
> missing in internal API or will Subdag just not be supported?
+ etc
ah yeah those scenarios are good to add to my testing dag. maybe you could
share your dag? and maybe i coul
jscheffl commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2120812783
> thanks @jscheffl -- which branch were you on? there are more changes re
mapping on the "mothership" PR (#37851) that are excluded from this PR just for
easier review -- that's the br
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2120782203
thanks @jscheffl -- which branch were you on? there are more changes re
mapping on the "mothership" PR (https://github.com/apache/airflow/pull/37851)
that are excluded from this PR
jscheffl commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2120775487
Okay, did some testing with a breeze setup, manually "massaged" the ENV to
enable AIP-44, strated internal API server, took away the DB connection and set
the internal API endpoints fo
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2119386522
Thanks yeah you mean like help with practical testing like trying things
out. I’ve done a lot of it so I feel ok about it so not necessary unless you
want to. If you do I recommend ch
jscheffl commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2119367963
> can you clarify what you mean here?
Uuups, too many typos. I wanted to say:
(1) If in any means besides other reviewers it helps to support testing, let
me know. Just did a
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2119359554
> If it helps let me know then I could make a full test as I am failing
exactly on this point maight be easy. Otherwise I assume some more pytests are
missing?
can you clarify
jscheffl commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1606094032
##
airflow/serialization/pydantic/taskinstance.py:
##
@@ -21,9 +21,17 @@
from typing_extensions import Annotated
+from airflow.exceptions import AirflowReschedu
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1605193809
##
airflow/models/taskinstance.py:
##
@@ -2709,43 +3004,12 @@ def _execute_task(self, context: Context, task_orig:
Operator):
return _execute_task(self, c
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1605193809
##
airflow/models/taskinstance.py:
##
@@ -2709,43 +3004,12 @@ def _execute_task(self, context: Context, task_orig:
Operator):
return _execute_task(self, c
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1605204033
##
airflow/models/taskinstance.py:
##
@@ -1265,6 +1558,130 @@ def _update_rtif(ti, rendered_fields, session: Session
| None = None):
RenderedTaskInstanceField
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1605195033
##
airflow/datasets/manager.py:
##
@@ -71,13 +76,14 @@ def register_dataset_change(
For local datasets, look them up, record the dataset event, queue
dagr
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1605193809
##
airflow/models/taskinstance.py:
##
@@ -2709,43 +3004,12 @@ def _execute_task(self, context: Context, task_orig:
Operator):
return _execute_task(self, c
vincbeck commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1605048275
##
airflow/datasets/manager.py:
##
@@ -71,13 +76,14 @@ def register_dataset_change(
For local datasets, look them up, record the dataset event, queue
dagru
potiuk commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2117309803
@dstandish - I am currently at PyCon US, and I have a busy plan of
attending talks and meeting people here :) - > I plan to take a very serious
look at the AIP-44 related changes right
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2116324386
ok @potiuk @vincbeck @uranusjr -- i think this is ready for another look.
This "base" PR is the first 4 commits from the mothership PR
(https://github.com/apache/airflow/pull/37
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2070503704
converting to draft while i work through a few more aspects of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1571154157
##
airflow/models/taskinstance.py:
##
@@ -1309,6 +1500,130 @@ def _update_rtif(ti, rendered_fields, session: Session
| None = None):
RenderedTaskInstanceFields.d
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1571143500
##
airflow/models/taskinstance.py:
##
@@ -1309,6 +1500,130 @@ def _update_rtif(ti, rendered_fields, session: Session
| None = None):
RenderedTaskInstanceFields.d
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1571078882
##
airflow/models/taskinstance.py:
##
@@ -2555,7 +2811,7 @@ def _run_raw_task(
# a trigger.
if raise_on_defer:
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1571078294
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1571078084
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1571005858
##
airflow/models/taskinstance.py:
##
@@ -2555,7 +2811,7 @@ def _run_raw_task(
# a trigger.
if raise_on_defer:
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570989592
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
+@
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570989592
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
+@
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570989592
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
+@
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570989592
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
+@
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570989592
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
+@
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570989592
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
+@
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570977458
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
dstandish commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570962006
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
potiuk commented on code in PR #38992:
URL: https://github.com/apache/airflow/pull/38992#discussion_r1570785504
##
airflow/models/taskinstance.py:
##
@@ -186,6 +186,193 @@ class TaskReturnCode(Enum):
"""When task exits with deferral to trigger."""
+@internal_api_call
+@
potiuk commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2063915337
I reviewed it quite a bit more thoroughly. I think it's the right direction,
but we should - I think - complete it (i.e. turn handle_reschedule into
internal_api, merge commiting changes
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2059889774
> I am moatly out till Friday and this one needs quite a bit more review -
if it can wait.
no worries, enjoy
--
This is an automated message from the Apache Git Service.
To r
potiuk commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2059887605
I am moatly out till Friday and this one needs quite a bit more review - if
it can wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dstandish commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2059303214
checks passed @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
potiuk commented on PR #38992:
URL: https://github.com/apache/airflow/pull/38992#issuecomment-2056166939
Generally it's what I would expect - let's get the test pass and merge the
depending PR and we can review that one in detail
--
This is an automated message from the Apache Git Service
dstandish opened a new pull request, #38992:
URL: https://github.com/apache/airflow/pull/38992
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
43 matches
Mail list logo
