Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-17 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1428246056 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -241,13 +258,17 @@ def run( else: return results -@staticmethod -def

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-17 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1428247519 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -241,13 +258,17 @@ def run( else: return results -@staticmethod -def

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-16 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1428885237 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -241,13 +258,17 @@ def run( else: return results -@staticmethod -def

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-15 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1428247519 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -241,13 +258,17 @@ def run( else: return results -@staticmethod -def

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-15 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1428246056 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -241,13 +258,17 @@ def run( else: return results -@staticmethod -def

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-15 Thread via GitHub
bolkedebruin commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1428218892 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -241,13 +258,17 @@ def run( else: return results -@staticmethod -d

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-15 Thread via GitHub
bolkedebruin commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1428216767 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -241,13 +258,17 @@ def run( else: return results -@staticmethod -d

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-15 Thread via GitHub
bolkedebruin commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1428216767 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -241,13 +258,17 @@ def run( else: return results -@staticmethod -d

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1427221843 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -80,8 +85,18 @@ def __init__( self.http_headers = http_headers self.catalog = cata

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1427221843 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -80,8 +85,18 @@ def __init__( self.http_headers = http_headers self.catalog = cata

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1427222586 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -80,8 +85,18 @@ def __init__( self.http_headers = http_headers self.catalog = cata

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1427221843 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -80,8 +85,18 @@ def __init__( self.http_headers = http_headers self.catalog = cata

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1856184404 Constraints with databricks 5.0.0 updated https://github.com/apache/airflow/commit/33121932d4cdcd2da27756ac149791365a88f08c and tag for 2.8.0rc3 moved @ephraimbuddy -- This is an aut

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
bolkedebruin commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1426953507 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -80,8 +85,18 @@ def __init__( self.http_headers = http_headers self.catalog = ca

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1856011705 Also cc: @ephraimbuddy -> since we yanked 5.0.1, I will rerun the last build for v2-8-stable to refresh constraints and move the tag once done (currentlly 5.0.1 was in the constraints p

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1856003948 Yanked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1855996509 > The databricks provider was already released with the breaking change-> [5.0.1](https://pypi.org/project/apache-airflow-providers-databricks/5.0.1/). Maybe this version should be remov

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
Joffreybvn commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1855988794 The databricks provider was already released with the breaking change-> [5.0.1](https://pypi.org/project/apache-airflow-providers-databricks/5.0.1/). Maybe this version should be rem

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1855968176 And I created https://github.com/apache/airflow/issues/36224 and assigned to myself and will shortly take a close look at this - to make sure the common.sql API is not only defined but a

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-14 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1855953848 @bolkedebruin @phanikumv -> please take a look and see what you think. I am all for this direction -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425894982 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""Tr

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
Joffreybvn commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425862433 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""Tr

Re: [PR] Make databricks sql hook return a serializable namedtuple [airflow]

2023-12-13 Thread via GitHub
potiuk commented on code in PR #36205: URL: https://github.com/apache/airflow/pull/36205#discussion_r1425659482 ## airflow/providers/databricks/hooks/databricks_sql.py: ## @@ -243,11 +244,15 @@ def run( @staticmethod def _make_serializable(result): -"""Transf