o-nikolas merged PR #37137:
URL: https://github.com/apache/airflow/pull/37137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
o-nikolas commented on PR #37137:
URL: https://github.com/apache/airflow/pull/37137#issuecomment-1924900854
> One thing that occurred to me is whether we want to document this design
choice. I think the unit test does a very good job of explaining the behaviour.
Might be worth putting that
o-nikolas commented on PR #37137:
URL: https://github.com/apache/airflow/pull/37137#issuecomment-1922506188
@mshober Can you have a look at this PR and see if it satisfies your use
case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
o-nikolas commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475312683
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -406,17 +407,17 @@ def _run_task_kwargs(
One last chance to modify Boto3's "run_task
ferruzzi commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475314154
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -406,17 +407,17 @@ def _run_task_kwargs(
One last chance to modify Boto3's "run_task"
o-nikolas commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475312683
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -406,17 +407,17 @@ def _run_task_kwargs(
One last chance to modify Boto3's "run_task
ferruzzi commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475299681
##
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##
@@ -406,17 +407,17 @@ def _run_task_kwargs(
One last chance to modify Boto3's "run_task"
o-nikolas commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475149018
##
airflow/providers/amazon/aws/executors/ecs/utils.py:
##
@@ -264,3 +264,16 @@ def camelize_dict_keys(nested_dict) -> dict:
else:
result[new_
Taragolis commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475050095
##
airflow/providers/amazon/aws/executors/ecs/utils.py:
##
@@ -264,3 +264,16 @@ def camelize_dict_keys(nested_dict) -> dict:
else:
result[new_
o-nikolas commented on PR #37137:
URL: https://github.com/apache/airflow/pull/37137#issuecomment-1922088649
CC @syedahsn (since I can't seem to add you via the reviewers list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
o-nikolas commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475045195
##
tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py:
##
@@ -1147,3 +1148,220 @@ def
test_providing_no_capacity_provider_no_lunch_type_no_cluster_defau
o-nikolas opened a new pull request, #37137:
URL: https://github.com/apache/airflow/pull/37137
This PR changes how `exec_config` works for the ECS executor. Previously the
`exec_config` was only applied to item zero of the `containerOverrides` list
(the container that receives the Airflow t
12 matches
Mail list logo
