Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
potiuk commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385277883 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = pytest.m

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
potiuk commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385255340 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = pytest.m

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
potiuk commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385244494 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = pytest.m

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
vincbeck commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385158833 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = pytest

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
ephraimbuddy commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385073359 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = py

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
vincbeck commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385071293 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = pytest

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
potiuk commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385063931 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = pytest.m

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
vincbeck commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385058491 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = pytest

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
potiuk merged PR #35421: URL: https://github.com/apache/airflow/pull/35421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
ephraimbuddy commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r138442 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = py

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
potiuk commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1383965182 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark = pytest.m

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
vincbeck commented on PR #35421: URL: https://github.com/apache/airflow/pull/35421#issuecomment-1795126135 I guess you'll have to mark these tests as DB tests ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
vincbeck commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1383523969 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -79,12 +79,14 @@ def delete_role(**kwargs) -> APIResponse: @_require_fab def patch_role(**kwar

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
ephraimbuddy commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1383500061 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -79,12 +79,14 @@ def delete_role(**kwargs) -> APIResponse: @_require_fab def patch_role(**

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
vincbeck commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1383490475 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -79,12 +79,14 @@ def delete_role(**kwargs) -> APIResponse: @_require_fab def patch_role(**kwar

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
vincbeck commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1383488315 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -79,12 +79,14 @@ def delete_role(**kwargs) -> APIResponse: @_require_fab def patch_role(**kwar

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
vincbeck commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1383488315 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -79,12 +79,14 @@ def delete_role(**kwargs) -> APIResponse: @_require_fab def patch_role(**kwar

Re: [PR] More code coverage for the REST API [airflow]

2023-11-06 Thread via GitHub
ephraimbuddy commented on PR #35421: URL: https://github.com/apache/airflow/pull/35421#issuecomment-1794791728 > > @vincbeck , looks like the forwarding of endpoints to FAB doesn't work for post & patch endpoints. See errors below: > > ``` > > FAILED tests/api_connexion/endpoints/test

Re: [PR] More code coverage for the REST API [airflow]

2023-11-05 Thread via GitHub
ephraimbuddy commented on PR #35421: URL: https://github.com/apache/airflow/pull/35421#issuecomment-1793842723 > @vincbeck , looks like the forwarding of endpoints to FAB doesn't work for post & patch endpoints. See errors below: > > ``` > FAILED tests/api_connexion/endpoints/test

Re: [PR] More code coverage for the REST API [airflow]

2023-11-03 Thread via GitHub
ephraimbuddy commented on PR #35421: URL: https://github.com/apache/airflow/pull/35421#issuecomment-1793063627 @vincbeck , looks like the forwarding of endpoints to FAB doesn't work for post & patch endpoints. See errors below: ``` FAILED tests/api_connexion/endpoints/test_forward_to_

[PR] More code coverage for the REST API [airflow]

2023-11-03 Thread via GitHub
ephraimbuddy opened a new pull request, #35421: URL: https://github.com/apache/airflow/pull/35421 This commit adds more tests to the REST API modules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov