potiuk merged PR #35146:
URL: https://github.com/apache/airflow/pull/35146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1779214261
@potiuk @eladkal @jedcunningham I'd like to run the PR again by all of you.
CI is green now
Take a look when you have some time
--
This is an automated message from the Apa
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1778934922
Thank you @potiuk
Just pushed a fix for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
potiuk commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1778852631
looks great, but docs and tests need fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1778595457
@potiuk @eladkal @jedcunningham I updated the code and also the usage
screenshots in the PR description. Can you take a look when you have soem time?
--
This is an automated messa
amoghrajesh commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1371211303
##
docs/apache-airflow/security/kerberos.rst:
##
@@ -100,6 +100,18 @@ Launch the ticket renewer by
# run ticket renewer
airflow kerberos
+To support m
eladkal commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1371202895
##
docs/apache-airflow/security/kerberos.rst:
##
@@ -100,6 +100,18 @@ Launch the ticket renewer by
# run ticket renewer
airflow kerberos
+To support more
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1778574530
> That's why best to start with main always.
When I started unfortunately the code was up to date. In a few hours time,
the change was introduced!
--
This is an automated m
amoghrajesh commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1371199104
##
airflow/cli/cli_config.py:
##
@@ -561,6 +561,7 @@ def string_lower_type(val):
# kerberos
ARG_PRINCIPAL = Arg(("principal",), help="kerberos principal", nargs
amoghrajesh commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1371198278
##
airflow/security/kerberos.py:
##
@@ -176,18 +189,25 @@ def detect_conf_var() -> bool:
return b"X-CACHECONF:" in file.read()
-def run(principal: st
amoghrajesh commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1371196623
##
airflow/security/kerberos.py:
##
@@ -176,18 +189,25 @@ def detect_conf_var() -> bool:
return b"X-CACHECONF:" in file.read()
-def run(principal: st
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1778570420
I did rebase it. Now working on review comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1778563839
> What if we didn't have "mode", but a "one-time" flag instead. I doubt we
will have another mode down the road and sidesteps the "normal/daemon/standard"
naming problem.
Gre
potiuk commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-157089
> What if we didn't have "mode", but a "one-time" flag instead. I doubt we
will have another mode down the road and sidesteps the "normal/daemon/standard"
naming problem.
:heart:
jedcunningham commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1370605608
##
airflow/security/kerberos.py:
##
@@ -176,18 +189,25 @@ def detect_conf_var() -> bool:
return b"X-CACHECONF:" in file.read()
-def run(principal:
potiuk commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1777669677
That's why best to start with main always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1370550640
##
airflow/cli/cli_config.py:
##
@@ -561,6 +561,7 @@ def string_lower_type(val):
# kerberos
ARG_PRINCIPAL = Arg(("principal",), help="kerberos principal", nargs="?")
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1777666123
Oh the main branch seems to have diverged quite a bit. I will rebase it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
amoghrajesh commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1370548258
##
airflow/cli/cli_config.py:
##
@@ -561,6 +561,7 @@ def string_lower_type(val):
# kerberos
ARG_PRINCIPAL = Arg(("principal",), help="kerberos principal", nargs
amoghrajesh commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1370547760
##
airflow/cli/cli_config.py:
##
@@ -561,6 +561,7 @@ def string_lower_type(val):
# kerberos
ARG_PRINCIPAL = Arg(("principal",), help="kerberos principal", nargs
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1777660457
> (BTW. I think you should rebase as you have conflicts to solve :)
Just saw the merge conflict. Sure, will rebase now
--
This is an automated message from the Apache Git Se
potiuk commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1777619818
(BTW. I think you should rebase :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
potiuk commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1370512003
##
airflow/cli/cli_config.py:
##
@@ -561,6 +561,7 @@ def string_lower_type(val):
# kerberos
ARG_PRINCIPAL = Arg(("principal",), help="kerberos principal", nargs="?")
amoghrajesh commented on PR #35146:
URL: https://github.com/apache/airflow/pull/35146#issuecomment-1777561228
@potiuk @eladkal can you take a look at this when you have some time?
I have added screenshots regarding the command too in the PR description.
--
This is an automated message f
amoghrajesh commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1370461767
##
airflow/cli/commands/kerberos_command.py:
##
@@ -33,6 +34,17 @@ def kerberos(args):
"""Start a kerberos ticket renewer."""
print(settings.HEADER)
+
25 matches
Mail list logo
