potiuk merged PR #34926:
URL: https://github.com/apache/airflow/pull/34926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
oleksiidav commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1792321565
Hi @potiuk @eladkal, let's merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
oleksiidav commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1786932971
Ah, thank you very much @potiuk! Will wait for a few days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
potiuk commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1786267427
You need to wait until 4.7.0 is released. It is being voted currently - but
not yet released and the error you see is when documentation is generated to
show the difference between relea
oleksiidav commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1786060269
I have spent some time but I'm really not sure where the bad revision error
is coming from in [provider docs GH
workflow](https://github.com/apache/airflow/actions/runs/6696355323/jo
oleksiidav commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1781171372
Thanks @eladkal ! Applied changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
oleksiidav commented on code in PR #34926:
URL: https://github.com/apache/airflow/pull/34926#discussion_r1373212596
##
airflow/providers/databricks/CHANGELOG.rst:
##
@@ -61,6 +61,13 @@ Misc
4.5.0
.
+Breaking changes
+
+
+The ``offset`` parameter has been
eladkal commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1779763315
Please also add `5.0.0` entry to versions in `provider.yaml:`
https://github.com/apache/airflow/blob/e9987d50598f70d84cbb2a5d964e21020e81c080/airflow/providers/databricks/provider
eladkal commented on code in PR #34926:
URL: https://github.com/apache/airflow/pull/34926#discussion_r1372113523
##
airflow/providers/databricks/CHANGELOG.rst:
##
@@ -61,6 +61,13 @@ Misc
4.5.0
.
+Breaking changes
+
+
+The ``offset`` parameter has been dep
oleksiidav commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1779249193
Hi @eladkal, could you ptal? This is ready to be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
oleksiidav commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1777216767
Thanks @uranusjr, I have added the breaking change note the changelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
uranusjr commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1768030729
Yes we do. Or to not make this a breaking change, we can continue to accept
the argument but just ignore it with a warning. I would prefer dropping it
entirely though.
--
This is an
Lee-W commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1762499379
Do we need to do something like
https://github.com/apache/airflow/pull/34738#discussion_r1344665048 in this PR
as well? Looks like a breaking change.
--
This is an automated message fr
oleksiidav commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1762258496
> https://github.com/apache/airflow/pull/33472 have not been released yet so
no have been warned
I see @eladkal ! In any case, there is at least a month of time between that
P
eladkal commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1761820002
> This is a follow-up to https://github.com/apache/airflow/pull/33472.
Airflow users passing offsets to list_jobs have been receiving deprecation
warnings for the last month.
htt
oleksiidav commented on PR #34926:
URL: https://github.com/apache/airflow/pull/34926#issuecomment-1761740255
@alexott could you please take a look and assign a maintainer to review if
you can?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
oleksiidav opened a new pull request, #34926:
URL: https://github.com/apache/airflow/pull/34926
Databricks has deprecated the offset parameter from [ListJobs
API](https://docs.databricks.com/api/workspace/jobs/list), and to soften and
control the inevitable breaking change for Airflow users
17 matches
Mail list logo
