Re: [PR] Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #37015: URL: https://github.com/apache/airflow/pull/37015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #37015: URL: https://github.com/apache/airflow/pull/37015#issuecomment-1911143165 Yeah. I thought a bit about it and I think reverting is the fastest and most secure way. This way we can release RC2 now, and properly get it implemented and tested. There are a bit unex

Re: [PR] Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" [airflow]

2024-01-25 Thread via GitHub
hussein-awala commented on PR #37015: URL: https://github.com/apache/airflow/pull/37015#issuecomment-1910890170 I know it's faster, but with a simple reset soft for the revert commit, we can easily exclude the classes where it's not provided explicitly, wdyt? -- This is an automated messa

[PR] Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" [airflow]

2024-01-25 Thread via GitHub
Taragolis opened a new pull request, #37015: URL: https://github.com/apache/airflow/pull/37015 related: https://github.com/apache/airflow/issues/36948#issuecomment-1910279616 We need to properly sanitise `logger_name` from hook `kwargs` in case of if Airflow < 2.8 use