potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1912117628
Boom :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
potiuk merged PR #36969:
URL: https://github.com/apache/airflow/pull/36969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1911263008
Addressed @jscheffl comments. I target to merge it tomorrow - more comments
welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1467138182
##
contributing-docs/testing/unit_tests.rst:
##
@@ -0,0 +1,1160 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agr
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1467137828
##
contributing-docs/testing/unit_tests.rst:
##
@@ -0,0 +1,1160 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agr
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1467135204
##
contributing-docs/testing/unit_tests.rst:
##
@@ -0,0 +1,1160 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agr
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1467134116
##
contributing-docs/02_how_to_communicate.rst:
##
@@ -0,0 +1,152 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license a
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1467133611
##
contributing-docs/02_how_to_communicate.rst:
##
@@ -0,0 +1,152 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license a
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1467133169
##
contributing-docs/02_how_to_communicate.rst:
##
@@ -0,0 +1,152 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license a
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466984316
##
generated/PYPI_README.md:
##
@@ -163,11 +163,20 @@ release provided they have access to the appropriate
platform and tools.
## Contributing
-Want to help buil
jscheffl commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466962083
##
generated/PYPI_README.md:
##
@@ -163,11 +163,20 @@ release provided they have access to the appropriate
platform and tools.
## Contributing
-Want to help bu
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466935091
##
COMMITTERS.rst:
##
@@ -15,14 +15,39 @@
specific language governing permissions and limitations
under the License.
+Committers and PMC members
+=
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466932570
##
generated/PYPI_README.md:
##
@@ -163,11 +163,20 @@ release provided they have access to the appropriate
platform and tools.
## Contributing
-Want to help buil
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466931569
##
generated/PYPI_README.md:
##
@@ -163,11 +163,20 @@ release provided they have access to the appropriate
platform and tools.
## Contributing
-Want to help buil
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466931569
##
generated/PYPI_README.md:
##
@@ -163,11 +163,20 @@ release provided they have access to the appropriate
platform and tools.
## Contributing
-Want to help buil
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466918029
##
RELEASE_NOTES.rst:
##
@@ -8279,7 +8279,7 @@ Doc only changes
- [AIRFLOW-] Add Updating.md section for 1.10.9 (#7385)
- [AIRFLOW-] Remove duplication in Ba
jscheffl commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466910031
##
COMMITTERS.rst:
##
@@ -15,14 +15,39 @@
specific language governing permissions and limitations
under the License.
+Committers and PMC members
+===
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1910726777
> You know... I've usually done the build-docs to verify the formatting and
stuff, then used those generated docs to verify the links I don't think it
has occurred to me to try them
ferruzzi commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1910722652
You know... I've usually done the build-docs to verify the formatting and
stuff, then used those generated docs to verify the links I don't think it
has occurred to me to try them
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1910702781
> I did not try to generate the docs and click through all the links to
verify them; they look good in code but has anyone tried that yet?
They do not need generation @ferruzzi -
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1910354778
Thanks @amoghrajesh - applied your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466474000
##
contributing-docs/03_contributors_quick_start.rst:
##
@@ -141,13 +140,14 @@ Docker Compose
docker-compose --version
-Pyenv and setting up virtual-env
---
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466182477
##
contributing-docs/02_how_to_communicate.rst:
##
@@ -0,0 +1,151 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license a
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466168117
##
README.md:
##
@@ -426,13 +427,22 @@ might decide to add additional limits (and justify them
with comment).
## Contributing
-Want to help build Apache Airflow?
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1466145383
##
.github/SECURITY.md:
##
@@ -97,7 +97,7 @@ do not apply to Airflow, or have a different severity than
some generic scoring
### What happens after you report the
amoghrajesh commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1465826457
##
.github/SECURITY.md:
##
@@ -97,7 +97,7 @@ do not apply to Airflow, or have a different severity than
some generic scoring
### What happens after you report
amoghrajesh commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1909330305
> Also - just to add @amoghrajesh - nice way of showing what I explained
about sequence:
>
> https://private-user-images.githubusercontent.com/595491/299392082-b6bfae42-8fba-4
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1908553450
Also - just to add @amoghrajesh - nice way of showing what I explained
about sequence:
https://github.com/apache/airflow/assets/595491/b6bfae42-8fba-4efc-b671-93a48ce9c259";>
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1908494200
Applied the comments from @aritra24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1465208033
##
README.md:
##
@@ -426,13 +427,23 @@ might decide to add additional limits (and justify them
with comment).
## Contributing
-Want to help build Apache Airflow?
potiuk commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1465206732
##
README.md:
##
@@ -426,13 +427,23 @@ might decide to add additional limits (and justify them
with comment).
## Contributing
-Want to help build Apache Airflow?
aritra24 commented on code in PR #36969:
URL: https://github.com/apache/airflow/pull/36969#discussion_r1464930407
##
README.md:
##
@@ -426,13 +427,23 @@ might decide to add additional limits (and justify them
with comment).
## Contributing
-Want to help build Apache Airflo
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1907851710
> @potiuk I started looking at it too, will complete by EOD, but I am not
very much in favour of labelling the docs as -title.rst, when only title.rst
would be enough, any specific reaso
amoghrajesh commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1907362539
> I started looking through it today, but haven't finished. I'll try to get
through the rest of it tomorrow or Thursday. When do the interns start?
Hi @ferruzzi, it starts on
ferruzzi commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1907200985
I started looking through it today, but haven't finished. I'll try to get
through the rest of it tomorrow or Thursday. When do the interns start?
--
This is an automated message f
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1907183513
I would love to merge that one (despite the size) pretty soon - we are
starting soon to work with MLH interns and I want to use the opportunity that
they use the docs, review them and im
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1905837553
I also removed some outdated content and refreshed some other - everything I
noticed was outdated or misplaced (I moved a few chapters around), so generally
the structure and content sho
potiuk commented on PR #36969:
URL: https://github.com/apache/airflow/pull/36969#issuecomment-1905833272
All right. I think it should be basically READY for review. I am quite sure
there are few broken links that I mised. So I'd really love more pairs of eyes
looking at it:
https://github.
potiuk commented on PR #36961:
URL: https://github.com/apache/airflow/pull/36961#issuecomment-1905816653
The new PR -> even more split (testing is now spearate doc for every kind of
tests we have + we have better ordering and navigation of documents in the
contributor documentation - and ni
jedcunningham commented on PR #36961:
URL: https://github.com/apache/airflow/pull/36961#issuecomment-1905766870
No problem (I had only partially reviewed it anyways 👍).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
potiuk closed pull request #36961: Split contributing docs to multiple files
URL: https://github.com/apache/airflow/pull/36961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
potiuk opened a new pull request, #36969:
URL: https://github.com/apache/airflow/pull/36969
Following #36936 and the fact that GitHub stopped rendering big .rst files,
we also split CONTRIBUTING.rst into multiple files. It will be much easier to
follow and it will render in GitHub.
potiuk commented on PR #36961:
URL: https://github.com/apache/airflow/pull/36961#issuecomment-1905669633
I addressed all comments @jedcunningham and @aritra24 - but I have to close
the PR to open it `apache` repository because removed `images` folder prevents
from building CI image in `buil
aritra24 commented on code in PR #36961:
URL: https://github.com/apache/airflow/pull/36961#discussion_r1462698655
##
contribution-docs/README.rst:
##
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. Se
jedcunningham commented on code in PR #36961:
URL: https://github.com/apache/airflow/pull/36961#discussion_r1462607332
##
CONTRIBUTING.rst:
##
@@ -15,23 +15,24 @@
specific language governing permissions and limitations
under the License.
+Contributions primer
+==
potiuk opened a new pull request, #36961:
URL: https://github.com/apache/airflow/pull/36961
Following #36936 and the fact that GitHub stopped rendering big .rst files,
we also split CONTRIBUTING.rst into multiple files. It will be much easier to
follow and it will render in GitHub.
46 matches
Mail list logo
