potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2333832009
> This has been...educational
Oh, I am sure it was :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
topherinternational commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2333824217
> Wooh!
This has been...educational 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2331727868
🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1745543361
##
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##
@@ -1278,7 +1277,10 @@ def excluded_providers_as_string(self) -> str:
if "excl
topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1745540135
##
airflow/providers/cloudant/provider.yaml:
##
@@ -46,7 +47,17 @@ versions:
dependencies:
- apache-airflow>=2.8.0
- - cloudant>=2.13.0
+ - ibmclo
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2331483524
🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
topherinternational commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2331401946
Another cross-fix: #42030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2331295625
🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2328558624
This one should fix it https://github.com/apache/airflow/pull/41991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2328372934
Hmm. The problem is this for apache.beam
```
--verbosity=0 --strict-markers --durations=100 --maxfail=50 --color=yes
--junitxml=/files/test_result-providers_apache_beam-postgres
topherinternational commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2323435403
> There is one more issue - when package is excluded fromcertai version ,
the 'lowest deendencies' test goes wild - it tests all other packages then.
This should be fixed
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2323323766
I guess we will also have to exclude Python 3.12 version - until apache.beam
fixes the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2323262923
Almost there. For some strange reason apache.beam "downgrade" does not work
quite consistently and hangs for Python 3.12.
Need to take a look
--
This is an automated message fr
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2323075534
I added a fixup that is supposed to skip cloundant tests for 3.8, 3.9, 3.12
@topherinternational
--
This is an automated message from the Apache Git Service.
To respond to the message
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2320776697
There is one more issue - when package is excluded fromcertai version , the
'lowest deendencies' test goes wild - it tests all other packages then. This
should be fixed as part of CI i
eladkal commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1736247926
##
airflow/providers/cloudant/provider.yaml:
##
@@ -25,7 +25,7 @@ state: ready
source-date-epoch: 1723969866
# note that those versions are maintained by release ma
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2308779326
> I checked the repo and none of the released providers exclude Python 3.8,
I figure maybe this problem hasn't come up yet.
Yes. As I wrote in the #41718 - likely matrix for all pr
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2308775821
> We also have spurious failures where one of the tests in "Lowest direct
dependency resolution tests" and one in "Kubernetes tests" will fail, but it
looks like a different one each tim
topherinternational commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2306141955
We also have spurious failures where one of the tests in "Lowest direct
dependency resolution tests" and one in "Kubernetes tests" will fail, but it
looks like a different o
topherinternational commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2306136496
@potiuk @eladkal we have 3 persistent failures in the provider checks; tldr,
I think there's a bug-ish in the provider checks commands in breeze where all
providers are assu
eladkal commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1724392868
##
airflow/providers/cloudant/provider.yaml:
##
@@ -46,7 +47,17 @@ versions:
dependencies:
- apache-airflow>=2.8.0
- - cloudant>=2.13.0
+ - ibmcloudant>=0.9.1
potiuk commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1724080680
##
airflow/providers/cloudant/cloudant_fake.py:
##
Review Comment:
We should just leave a note to drop it after the issue is solved ( PR
merged) explaining why
potiuk commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1724080680
##
airflow/providers/cloudant/cloudant_fake.py:
##
Review Comment:
We should just leave a note / comment to drop it after the issue is solved
( PR merged) expl
potiuk commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1724076522
##
airflow/providers/cloudant/provider.yaml:
##
@@ -25,7 +25,7 @@ state: ready
source-date-epoch: 1723969866
# note that those versions are maintained by release man
topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1724076743
##
airflow/providers/cloudant/cloudant_fake.py:
##
Review Comment:
@eladkal @potiuk so this is a big hack...static tests were failing bc we run
stat
topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1724073931
##
airflow/providers/cloudant/provider.yaml:
##
@@ -25,7 +25,7 @@ state: ready
source-date-epoch: 1723969866
# note that those versions are maintained b
potiuk commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1724061965
##
docs/spelling_wordlist.txt:
##
@@ -250,8 +250,8 @@ classpaths
cleartext
cli
clientId
-Cloudant
cloudant
+CloudantV
Review Comment:
Add `` around. (`Cloundan
topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1724058435
##
docs/spelling_wordlist.txt:
##
@@ -250,8 +250,8 @@ classpaths
cleartext
cli
clientId
-Cloudant
cloudant
+CloudantV
Review Comment:
When I tried
topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1723817914
##
airflow/providers/cloudant/provider.yaml:
##
@@ -46,7 +47,17 @@ versions:
dependencies:
- apache-airflow>=2.8.0
- - cloudant>=2.13.0
+ - ibmclo
eladkal commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1723781663
##
airflow/providers/cloudant/provider.yaml:
##
@@ -46,7 +47,17 @@ versions:
dependencies:
- apache-airflow>=2.8.0
- - cloudant>=2.13.0
+ - ibmcloudant>=0.9.1
topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1723445214
##
airflow/providers/cloudant/provider.yaml:
##
@@ -46,7 +47,17 @@ versions:
dependencies:
- apache-airflow>=2.8.0
- - cloudant>=2.13.0
+ - ibmclo
topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1723445214
##
airflow/providers/cloudant/provider.yaml:
##
@@ -46,7 +47,17 @@ versions:
dependencies:
- apache-airflow>=2.8.0
- - cloudant>=2.13.0
+ - ibmclo
eladkal commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1722716096
##
airflow/providers/cloudant/provider.yaml:
##
@@ -46,7 +47,17 @@ versions:
dependencies:
- apache-airflow>=2.8.0
- - cloudant>=2.13.0
+ - ibmcloudant>=0.9.1
eladkal commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1721621154
##
airflow/providers/cloudant/provider.yaml:
##
Review Comment:
Please `4.0.0` to versions. Since we know for sure this PR is breaking
```
versions:
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2296264555
You should also add a note at the top of changelog (see comment at the top
of changelog) and bump the version to the new major release in the
provider.yaml.
--
This is an automated me
topherinternational commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295750150
Ok @potiuk I've added the exclusion and an explanatory comment, so I think
this is complete. Please review at your convenience, thanks.
--
This is an automated message fro
topherinternational commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295512197
Great explanation, thank you @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295384199
I've added "all-versions" tag to the PR of yours - to make sure it's tested
on all versions - so once you exclude python versions you should be able to see
both CI images and tests to ru
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295383824
See https://github.com/apache/airflow/pull/41548 - where we just removed
such exclusion for Papermill for Python 3.12
--
This is an automated message from the Apache Git Service.
To re
potiuk commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295383399
> Rats, looks like the joke is on me and this PR is blocked on another
third-party...`ibmcloudant` has a dependency conflict with the Snowflake Python
library that nerfs the Airflow buil
topherinternational commented on PR #41555:
URL: https://github.com/apache/airflow/pull/41555#issuecomment-2294991433
Rats, looks like the joke is on me and this PR is blocked on another
third-party...`ibmcloudant` has a dependency conflict with the Snowflake Python
library that nerfs the A
topherinternational opened a new pull request, #41555:
URL: https://github.com/apache/airflow/pull/41555
closes: #21004, cloudant is no longer developed and ibmcloudant is the
active replacement
This is a breaking change to the provider in the following ways:
- `get_conn` now r
42 matches
Mail list logo
