o-nikolas opened a new pull request, #40285:
URL: https://github.com/apache/airflow/pull/40285
Instead of instantiating an executor and providing it to the Job constructor
(only used for testing), use the "production" ExecutorLoader logic to load
executors (using mocking where required). Th
vincbeck commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1643476741
##
tests/jobs/test_backfill_job.py:
##
@@ -139,14 +167,14 @@ def test_unfinished_dag_runs_set_to_failed(self,
dag_maker):
assert State.FAILED == dag_run.
ferruzzi commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1643477441
##
tests/jobs/test_backfill_job.py:
##
@@ -350,9 +377,8 @@ def
test_backfill_respect_max_active_tis_per_dag_limit(self, mock_log, dag_maker
)
dag_
uranusjr commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1643865257
##
tests/jobs/test_backfill_job.py:
##
@@ -139,14 +167,14 @@ def test_unfinished_dag_runs_set_to_failed(self,
dag_maker):
assert State.FAILED == dag_run.
potiuk commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644554626
##
tests/jobs/test_backfill_job.py:
##
@@ -763,15 +778,13 @@ def test_backfill_skip_active_scheduled_dagrun(self,
dag_maker, caplog):
# since DAG backfill is
potiuk commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644555723
##
tests/jobs/test_backfill_job.py:
##
@@ -79,11 +80,38 @@ def dag_bag():
return DagBag(include_examples=True)
-# Patch the MockExecutor into the dict of know
potiuk commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644558818
##
tests/jobs/test_backfill_job.py:
##
@@ -139,14 +167,14 @@ def test_unfinished_dag_runs_set_to_failed(self,
dag_maker):
assert State.FAILED == dag_run.st
o-nikolas commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644786444
##
tests/jobs/test_backfill_job.py:
##
@@ -694,20 +712,21 @@ def test_backfill_run_rescheduled(self, dag_maker):
ti.refresh_from_db()
ti.set_state
o-nikolas commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644788180
##
tests/jobs/test_backfill_job.py:
##
@@ -139,14 +167,14 @@ def test_unfinished_dag_runs_set_to_failed(self,
dag_maker):
assert State.FAILED == dag_run
o-nikolas commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644790025
##
tests/jobs/test_backfill_job.py:
##
@@ -79,11 +80,38 @@ def dag_bag():
return DagBag(include_examples=True)
-# Patch the MockExecutor into the dict of k
o-nikolas commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644791977
##
tests/jobs/test_backfill_job.py:
##
@@ -350,9 +377,8 @@ def
test_backfill_respect_max_active_tis_per_dag_limit(self, mock_log, dag_maker
)
dag
o-nikolas commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644815890
##
tests/jobs/test_backfill_job.py:
##
@@ -763,15 +778,13 @@ def test_backfill_skip_active_scheduled_dagrun(self,
dag_maker, caplog):
# since DAG backfill
vincbeck commented on code in PR #40285:
URL: https://github.com/apache/airflow/pull/40285#discussion_r1644818369
##
tests/jobs/test_backfill_job.py:
##
@@ -694,20 +712,21 @@ def test_backfill_run_rescheduled(self, dag_maker):
ti.refresh_from_db()
ti.set_state(
13 matches
Mail list logo
