Re: [PR] Use base aws classes in AWS Batch Operators/Sensors/Triggers [airflow]

2023-10-31 Thread via GitHub
Taragolis closed pull request #35226: Use base aws classes in AWS Batch Operators/Sensors/Triggers URL: https://github.com/apache/airflow/pull/35226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Use base aws classes in AWS Batch Operators/Sensors/Triggers [airflow]

2023-10-31 Thread via GitHub
Taragolis commented on PR #35226: URL: https://github.com/apache/airflow/pull/35226#issuecomment-1788167258 Yet another tab vs spaces and ' vs " -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Use base aws classes in AWS Batch Operators/Sensors/Triggers [airflow]

2023-10-31 Thread via GitHub
o-nikolas commented on code in PR #35226: URL: https://github.com/apache/airflow/pull/35226#discussion_r1378245972 ## tests/providers/amazon/aws/sensors/test_batch.py: ## @@ -29,59 +30,86 @@ ) from airflow.providers.amazon.aws.triggers.batch import BatchJobTrigger +if

Re: [PR] Use base aws classes in AWS Batch Operators/Sensors/Triggers [airflow]

2023-10-30 Thread via GitHub
Lee-W commented on code in PR #35226: URL: https://github.com/apache/airflow/pull/35226#discussion_r1376255346 ## tests/providers/amazon/aws/operators/test_batch.py: ## @@ -305,40 +337,55 @@ def test_monitor_job_with_logs( class TestBatchCreateComputeEnvironmentOperator: +

Re: [PR] Use base aws classes in AWS Batch Operators/Sensors/Triggers [airflow]

2023-10-30 Thread via GitHub
Taragolis commented on code in PR #35226: URL: https://github.com/apache/airflow/pull/35226#discussion_r1376095456 ## tests/providers/amazon/aws/sensors/test_batch.py: ## @@ -29,59 +30,86 @@ ) from airflow.providers.amazon.aws.triggers.batch import BatchJobTrigger +if

Re: [PR] Use base aws classes in AWS Batch Operators/Sensors/Triggers [airflow]

2023-10-30 Thread via GitHub
Taragolis commented on code in PR #35226: URL: https://github.com/apache/airflow/pull/35226#discussion_r1376085439 ## tests/providers/amazon/aws/operators/test_batch.py: ## @@ -305,40 +337,55 @@ def test_monitor_job_with_logs( class

Re: [PR] Use base aws classes in AWS Batch Operators/Sensors/Triggers [airflow]

2023-10-30 Thread via GitHub
Lee-W commented on code in PR #35226: URL: https://github.com/apache/airflow/pull/35226#discussion_r1376049250 ## tests/providers/amazon/aws/sensors/test_batch.py: ## @@ -106,215 +134,167 @@ def test_execute_failure_in_deferrable_mode_with_soft_fail(self, deferrable_batc

[PR] Use base aws classes in AWS Batch Operators/Sensors/Triggers [airflow]

2023-10-27 Thread via GitHub
Taragolis opened a new pull request, #35226: URL: https://github.com/apache/airflow/pull/35226 --- **^ Add meaningful description above** Read the **[Pull Request