potiuk merged PR #38601:
URL: https://github.com/apache/airflow/pull/38601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk closed pull request #38643: Use explicit and easier to use runs-on
approach for CI workflows
URL: https://github.com/apache/airflow/pull/38643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk commented on PR #38601:
URL: https://github.com/apache/airflow/pull/38601#issuecomment-2028786806
Also I standardized `fromJSON` everywhere - in an attempt to see what is
causing the problem if I put `run-as` in two lines of yaml rather than one 🤯
--
This is an automated message f
potiuk commented on PR #38601:
URL: https://github.com/apache/airflow/pull/38601#issuecomment-2028780900
I think I figured it 🤯 🤯 🤯 🤯 🤯 🤯 🤯 🤯 🤯
```
# NOTE! This has to be put in one line for runs-on to recognize the
"fromJSON" properly
# adding space befor
potiuk commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545681685
##
.github/workflows/additional-ci-image-checks.yml:
##
@@ -93,7 +96,7 @@ jobs:
packages: write
secrets: inherit
with:
- # Runs on Public runners
potiuk commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545657439
##
.github/workflows/additional-ci-image-checks.yml:
##
@@ -93,7 +96,7 @@ jobs:
packages: write
secrets: inherit
with:
- # Runs on Public runners
potiuk opened a new pull request, #38643:
URL: https://github.com/apache/airflow/pull/38643
Depending on selective checks, but also on the job executed, we choose
whether to run job on public runners or self-hosted runners. So far the set of
labels to select the runners were passed in a bit
potiuk commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545656973
##
.github/workflows/additional-ci-image-checks.yml:
##
@@ -93,7 +96,7 @@ jobs:
packages: write
secrets: inherit
with:
- # Runs on Public runners
potiuk commented on PR #38601:
URL: https://github.com/apache/airflow/pull/38601#issuecomment-2028721875
@hussein-awala :
> I don't think the as-string suffix makes it clearer here, personally, I
prefer to keep the name pattern -runs-on or -runs-on-as-json as we
can use the string wi
pankajkoti commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545612839
##
.github/workflows/push-image-cache.yml:
##
@@ -134,7 +133,7 @@ jobs:
push-prod-image-cache:
name: "Push PROD ${{ inputs.cache-type }}:${{ matrix.pytho
pankajkoti commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545631644
##
.github/workflows/push-image-cache.yml:
##
@@ -20,10 +20,9 @@ name: Push image cache
on: # yamllint disable-line rule:truthy
workflow_call:
inputs:
-
pankajkoti commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545612812
##
.github/workflows/push-image-cache.yml:
##
@@ -76,7 +75,7 @@ on: # yamllint disable-line rule:truthy
jobs:
push-ci-image-cache:
name: "Push CI ${{ inp
pankajkoti commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545612839
##
.github/workflows/push-image-cache.yml:
##
@@ -134,7 +133,7 @@ jobs:
push-prod-image-cache:
name: "Push PROD ${{ inputs.cache-type }}:${{ matrix.pytho
potiuk commented on PR #38630:
URL: https://github.com/apache/airflow/pull/38630#issuecomment-2027862488
Closing - all looks good here. The PR to merge is #38601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk closed pull request #38630: Use explicit and easier to use runs-on
approach for CI workflows
URL: https://github.com/apache/airflow/pull/38630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk commented on PR #38601:
URL: https://github.com/apache/airflow/pull/38601#issuecomment-2027862357
All good - tested all cases: regular builds, public runner builds,
maintainer build from PR in apache repo, canary build - this one is ready to
merge I think. Looking forward to reviews
potiuk commented on PR #38601:
URL: https://github.com/apache/airflow/pull/38601#issuecomment-2027813850
Running it with `use public runners` to check if everything is fine for a
`regular` run - also running it as `canary` build in #38630
--
This is an automated message from the Apache Gi
potiuk opened a new pull request, #38630:
URL: https://github.com/apache/airflow/pull/38630
Depending on selective checks, but also on the job executed, we choose
whether to run job on public runners or self-hosted runners. So far the set of
labels to select the runners were passed in a bit
potiuk commented on PR #38601:
URL: https://github.com/apache/airflow/pull/38601#issuecomment-2027810175
Green :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
potiuk commented on PR #38601:
URL: https://github.com/apache/airflow/pull/38601#issuecomment-2027245024
This one also looks good-to-go with much easier way to manage what runners
are used (and I am going to have some follow-ups once this is better organized).
--
This is an automated mess
potiuk closed pull request #38605: Use explicit and easier to use runs-on
approach for CI workflows
URL: https://github.com/apache/airflow/pull/38605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk commented on PR #38605:
URL: https://github.com/apache/airflow/pull/38605#issuecomment-2027044226
Running with "upgrade to newer dependencies" as well. So far all looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
potiuk closed pull request #38605: Use explicit and easier to use runs-on
approach for CI workflows
URL: https://github.com/apache/airflow/pull/38605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk commented on PR #38605:
URL: https://github.com/apache/airflow/pull/38605#issuecomment-2026450838
same as #38601 but run as canary run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
potiuk closed pull request #38605: Use explicit and easier to use runs-on
approach for CI workflows
URL: https://github.com/apache/airflow/pull/38605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk opened a new pull request, #38605:
URL: https://github.com/apache/airflow/pull/38605
Depending on selective checks, but also on the job executed, we choose
whether to run job on public runners or self-hosted runners. So far the set of
labels to select the runners were passed in a bit
potiuk opened a new pull request, #38601:
URL: https://github.com/apache/airflow/pull/38601
Depending on selective checks, but also on the job executed, we choose
whether to run job on public runners or self-hosted runners. So far the set of
labels to select the runners were passed in a bit
27 matches
Mail list logo
