Lee-W commented on PR #37176:
URL: https://github.com/apache/airflow/pull/37176#issuecomment-1951958882
> what happens if the user upgrades Airflow (and thus receives this endpoint
addition) but does not upgrade the FAB provider (and thus does not receive the
permission addition mentioned i
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1494185708
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +131,167 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
uranusjr commented on PR #37176:
URL: https://github.com/apache/airflow/pull/37176#issuecomment-1951803492
One potential thing we might want to figure out and maybe put into the
release note, what happens if the user upgrades Airflow (and thus receives this
endpoint addition) but does not u
uranusjr commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1494074992
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +131,167 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
D
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1494049554
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +131,167 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
uranusjr commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1494039476
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +131,167 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
D
uranusjr commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1494039476
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +131,167 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
D
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1492014740
##
airflow/providers/fab/auth_manager/security_manager/override.py:
##
@@ -276,6 +276,7 @@ class
FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):
uranusjr commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1492007495
##
airflow/providers/fab/auth_manager/security_manager/override.py:
##
@@ -276,6 +276,7 @@ class
FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1487180422
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +130,153 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1487135574
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +130,153 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1487135376
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +130,153 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1487133451
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +130,153 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1487132906
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3014,6 +3171,15 @@ components:
description: Custom notes left by users for this Dag Run.
type: st
jedcunningham commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1486982924
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +130,153 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1482304716
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -4101,6 +4267,35 @@ components:
description: The dataset event creation time
nullable: false
+
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1482271942
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -986,6 +986,163 @@ paths:
"404":
$ref: "#/components/responses/NotFound"
+ /dags/{dag_id}/dataset
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1482270771
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -986,6 +986,163 @@ paths:
"404":
$ref: "#/components/responses/NotFound"
+ /dags/{dag_id}/dataset
cmarteepants commented on PR #37176:
URL: https://github.com/apache/airflow/pull/37176#issuecomment-1932641038
> might be good for @bbovenzi to have a look. i suspect there wants to be a
UI component here for management of the queue if it gets to undesirable state.
@cmarteepants is that par
dstandish commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1481861065
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -986,6 +986,163 @@ paths:
"404":
$ref: "#/components/responses/NotFound"
+ /dags/{dag_id}/dat
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1481116355
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -4101,6 +4267,35 @@ components:
description: The dataset event creation time
nullable: false
+
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1481114839
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3014,6 +3171,15 @@ components:
description: Custom notes left by users for this Dag Run.
type: st
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1481112633
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +129,148 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
uranusjr commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1480912755
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -4101,6 +4267,35 @@ components:
description: The dataset event creation time
nullable: false
uranusjr commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1480912161
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3014,6 +3171,15 @@ components:
description: Custom notes left by users for this Dag Run.
type:
uranusjr commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1480910760
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +129,148 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
D
Lee-W commented on PR #37176:
URL: https://github.com/apache/airflow/pull/37176#issuecomment-1931264165
> > 5. requires_access_dataset
>
> I would use `requires_access_dataset `
Thanks for your suggestions! Just updated it.
--
This is an automated message from the Apache Git
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1480883420
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +129,150 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1480883003
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +129,150 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Data
vincbeck commented on PR #37176:
URL: https://github.com/apache/airflow/pull/37176#issuecomment-1930727732
> 5\. requires_access_dataset
I would use `requires_access_dataset `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
sunank200 commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1480227166
##
airflow/api_connexion/endpoints/dataset_endpoint.py:
##
@@ -124,3 +129,150 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
Lee-W commented on PR #37176:
URL: https://github.com/apache/airflow/pull/37176#issuecomment-1929335415
> I came up a few questions during implementation
>
> 1. should we use `uri` instead of `dataset_id` in this endpoint? but
we'll have to use Dataset to find its id and then quer
Lee-W commented on PR #37176:
URL: https://github.com/apache/airflow/pull/37176#issuecomment-1927174666
I came up a few questions during implementation
1. should we use `uri` instead of `dataset_id` in this endpoint? but we'll
have to use Dataset to find its id and then query DDRQ.
Lee-W opened a new pull request, #37176:
URL: https://github.com/apache/airflow/pull/37176
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull
34 matches
Mail list logo