o-nikolas commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1856968452
Yeah, I think this is fine if the triggerer doesn't take up too many
resources. Since often the test may not be making use of it. Depending on
whether the operators support it or not
potiuk commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1855361153
That's a good quesiont. I think it should get default settings that are
"good" for system tests. I think defaults are fine - depending how triggerer is
started. It shoudl go in the backg
Bowrna commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1855144121
can i start the triggerer by default without supporting it as option to
pass? like how start-airflow breeze command supports. @potiuk @o-nikolas
--
This is an automated message from t
potiuk commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1853405709
Yeah. Apologies I missed that 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
o-nikolas commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1853290953
> ah can i work on this part of starting the triggerer with system-tests
@potiuk @o-nikolas ?
>
> Edit: I will open it as a different PR and submit the fix
Yes please! W
Bowrna commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1853278229
ah can i work on this part of starting the triggerer with system-tests
@potiuk @o-nikolas ?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
potiuk commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1852646164
Ah No. Indeed it's only start-airflow 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
o-nikolas commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1852622579
But will this start the triggerer for system tests as well? Or just when
using start-airflow?
--
This is an automated message from the Apache Git Service.
To respond to the message,
potiuk commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1844973380
All good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
potiuk merged PR #36063:
URL: https://github.com/apache/airflow/pull/36063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
Bowrna commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1844863215
And I have fixed this issue by simply finding the hidden feature :) please
check and let me know if i have to do anything @potiuk :)
--
This is an automated message from the Apache Git
Bowrna commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1844850660
Lol, now I can remove the switch added in this draft PR as we start the
triggerer regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
potiuk commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1844836762
AH.. 🤦 Of course WE DO have triggerer already - it starts automatically
already :). So this issue is implemented already (and no switch is needed) -
triggerer always starts regardle
Bowrna commented on PR #36063:
URL: https://github.com/apache/airflow/pull/36063#issuecomment-1844801488
@potiuk I could see in the run_tmux script that we have triggerer enabled to
run, but it's inside a check. Could you tell me why it is done this way if you
are aware of this?
htt
Bowrna opened a new pull request, #36063:
URL: https://github.com/apache/airflow/pull/36063
relates: #31826
fixes: #31826
Adding flag in breeze commands to start the triggered to make system tests
for triggered part easier
---
**^ Add meaningfu
15 matches
Mail list logo
