Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1496871113 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: tas

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1470456522 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: task_

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on PR #36797: URL: https://github.com/apache/airflow/pull/36797#issuecomment-1914031940 Also need to look into test failures and static check errors, and fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1469118381 ## tests/models/test_mappedoperator.py: ## @@ -609,6 +609,42 @@ def test_expand_kwargs_mapped_task_instance(dag_maker, session, num_existing_tis assert indices

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1469118016 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: tas

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1469115322 ## airflow/models/taskinstance.py: ## @@ -2502,6 +2509,15 @@ def signal_handler(signum, frame): # Execute the task with set_current_context

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1469114706 ## airflow/models/taskinstance.py: ## @@ -2502,6 +2510,7 @@ def signal_handler(signum, frame): # Execute the task with set_current_context(

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467174201 ## airflow/utils/context.py: ## @@ -59,6 +59,7 @@ "inlets", "logical_date", "macros", +"map_index_template", Review Comment: If [this](https://

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467172568 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: task_

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467172568 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: task_

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467173302 ## airflow/models/taskinstance.py: ## @@ -2502,6 +2510,7 @@ def signal_handler(signum, frame): # Execute the task with set_current_context(co

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467172568 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: task_

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1464368882 ## airflow/models/taskinstance.py: ## @@ -2502,6 +2510,7 @@ def signal_handler(signum, frame): # Execute the task with set_current_context(

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1464368433 ## airflow/models/taskinstance.py: ## @@ -575,6 +575,8 @@ def _get_template_context( dag_run = task_instance.get_dagrun(session) data_interval = dag.get_ru

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1464368241 ## airflow/models/baseoperator.py: ## @@ -765,6 +765,7 @@ def __init__( resources: dict[str, Any] | None = None, run_as_user: str | None = None,

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1464367724 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: tas

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1463969880 ## airflow/models/dagrun.py: ## @@ -166,6 +164,7 @@ class DagRun(Base, LoggingMixin): "state", "dag_id", postgresql_where=text("

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1463968646 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: task_

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1463932569 ## airflow/models/baseoperator.py: ## @@ -765,6 +765,7 @@ def __init__( resources: dict[str, Any] | None = None, run_as_user: str | None = None,

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462822550 ## airflow/models/taskinstance.py: ## @@ -2467,7 +2474,9 @@ def signal_handler(signum, frame): self.task.params = context["params"] with

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462820826 ## airflow/models/taskinstance.py: ## @@ -2467,7 +2474,9 @@ def signal_handler(signum, frame): self.task.params = context["params"] with

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462820826 ## airflow/models/taskinstance.py: ## @@ -2467,7 +2474,9 @@ def signal_handler(signum, frame): self.task.params = context["params"] with

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462820387 ## airflow/models/taskinstance.py: ## @@ -2502,6 +2511,9 @@ def signal_handler(signum, frame): # Execute the task with set_current_context(

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462818365 ## airflow/models/taskinstance.py: ## @@ -1401,6 +1407,7 @@ def insert_mapping(run_id: str, task: Operator, map_index: int) -> dict[str, Any "operator"

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462818964 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator: tas

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462804569 ## airflow/models/dagrun.py: ## @@ -166,6 +164,7 @@ class DagRun(Base, LoggingMixin): "state", "dag_id", postgresql_where=text

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462785304 ## airflow/models/dagrun.py: ## @@ -166,6 +164,7 @@ class DagRun(Base, LoggingMixin): "state", "dag_id", postgresql_where=text

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462785304 ## airflow/models/dagrun.py: ## @@ -166,6 +164,7 @@ class DagRun(Base, LoggingMixin): "state", "dag_id", postgresql_where=text

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462784905 ## airflow/models/baseoperator.py: ## @@ -765,6 +765,7 @@ def __init__( resources: dict[str, Any] | None = None, run_as_user: str | None = None,

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1462783960 ## airflow/decorators/base.py: ## @@ -504,6 +504,7 @@ def _expand(self, expand_input: ExpandInput, *, strict: bool) -> XComArg: # task's expand() contr

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1458454855 ## airflow/models/taskinstance.py: ## @@ -2331,6 +2336,10 @@ def _run_raw_task( self.task = self.task.prepare_for_execution() context = sel

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1456968191 ## airflow/utils/context.py: ## @@ -59,6 +59,7 @@ "inlets", "logical_date", "macros", +"map_index_template", Review Comment: I don’t think we

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1456968191 ## airflow/utils/context.py: ## @@ -59,6 +59,7 @@ "inlets", "logical_date", "macros", +"map_index_template", Review Comment: I don’t think we

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

uranusjr commented on PR #36797: URL: https://github.com/apache/airflow/pull/36797#issuecomment-1897873975 I’m thinking the following flow: 1. Define `map_index_template` on the operator (done) 2. Instead of just forwarding the template to TaskInstance, we only store the _rendered_

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1452820653 ## airflow/models/dagrun.py: ## @@ -166,6 +164,7 @@ class DagRun(Base, LoggingMixin): "state", "dag_id", postgresql_where=text("

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

Bisk1 commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1452752642 ## airflow/models/dagrun.py: ## @@ -166,6 +164,7 @@ class DagRun(Base, LoggingMixin): "state", "dag_id", postgresql_where=text("s

[PR] draft for map_index_template to overwrite map_index in the UI [airflow]

RNHTTR opened a new pull request, #36797: URL: https://github.com/apache/airflow/pull/36797 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*