boring-cyborg[bot] commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1783266148
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
eladkal merged PR #35130:
URL: https://github.com/apache/airflow/pull/35130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
hakuno commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1778325712
Ps.¹ Other Airflow components also has `safeToEvict` values.
Ps.² At another moment, I see I can contribute with other PRs. Because
`workers.podAnnotations` and `airflowPodAnnotati
hakuno commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1778309120
@jedcunningham @hussein-awala @potiuk I got it.
```
pytest
helm_tests/airflow_core/test_worker.py::TestWorker::test_safetoevict_annotations
=
hakuno commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1777258718
Thanks, @potiuk - I meant the environment setup itself. My Pytest couldn't
discovery tests etc.
I'll read that docs as soon as possible... thanks again :)
--
This is an automate
potiuk commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1777228011
> @jedcunningham Thanks for that. Unfortunately, I've had some difficult to
setup this test environment.
>
> Thoughts?
If you do not write what kind of difficulties you had,
hakuno commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1777184228
@jedcunningham Thanks for that. Unfortunately, I've had some difficult to
setup this test environment.
Thoughts?
--
This is an automated message from the Apache Git Service.
To
jedcunningham commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1776502995
@hakuno, Hussein meant a test in our test suit to make sure this doesn't
regress. [Here is an
example](https://github.com/apache/airflow/blob/f457228bd21b13a7fdb29e154202d5357d024
hakuno commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1776255255
Thank you so, @hussein-awala
I tested the Helm Chart itself with `--validate` on a Kubernetes cluster to
verify the generated manifests.
```
$ helm template --dry-run --
hakuno opened a new pull request, #35130:
URL: https://github.com/apache/airflow/pull/35130
It improves (or fixes) the `workers.safeToEvict` usage.
Kubernetes administrators/users agree that
`cluster-autoscaler.kubernetes.io/safe-to-evict` can be managed to avoid the
Autoscaler to ki
boring-cyborg[bot] commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1775330488
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
11 matches
Mail list logo
