jedcunningham commented on code in PR #36968:
URL: https://github.com/apache/airflow/pull/36968#discussion_r1463064242
##
tests/models/test_taskinstance.py:
##
@@ -3192,6 +3192,22 @@ def raise_skip_exception():
assert State.SKIPPED == ti.state
assert callback_f
Lee-W commented on code in PR #36968:
URL: https://github.com/apache/airflow/pull/36968#discussion_r1463101163
##
tests/models/test_taskinstance.py:
##
@@ -3192,6 +3192,22 @@ def raise_skip_exception():
assert State.SKIPPED == ti.state
assert callback_function.
Lee-W commented on code in PR #36968:
URL: https://github.com/apache/airflow/pull/36968#discussion_r1463128170
##
tests/models/test_taskinstance.py:
##
@@ -3192,6 +3192,22 @@ def raise_skip_exception():
assert State.SKIPPED == ti.state
assert callback_function.
jkramer-ginkgo commented on PR #36968:
URL: https://github.com/apache/airflow/pull/36968#issuecomment-1906125382
I'm not totally convinced this is the best fix. Per my
[comment](https://github.com/apache/airflow/issues/36957#issue-2094747829) I
don't think `@Sentry.enrich_errors` makes sens
Lee-W commented on PR #36968:
URL: https://github.com/apache/airflow/pull/36968#issuecomment-1907162041
> I'm not totally convinced this is the best fix. Per my
[comment](https://github.com/apache/airflow/issues/36957#issue-2094747829) I
don't think `@Sentry.enrich_errors` makes sense on
`
dirrao commented on code in PR #36968:
URL: https://github.com/apache/airflow/pull/36968#discussion_r1465798357
##
airflow/sentry.py:
##
@@ -178,8 +179,12 @@ def wrapper(_self, *args, **kwargs):
with sentry_sdk.push_scope():
try:
-
Lee-W commented on code in PR #36968:
URL: https://github.com/apache/airflow/pull/36968#discussion_r1465835134
##
airflow/sentry.py:
##
@@ -178,8 +179,12 @@ def wrapper(_self, *args, **kwargs):
with sentry_sdk.push_scope():
try:
-
potiuk closed pull request #36968: fix task_instance can not get task attribute
correctly when turning on sentry
URL: https://github.com/apache/airflow/pull/36968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
