mobuchowski merged PR #36084:
URL: https://github.com/apache/airflow/pull/36084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airf
JDarDagran commented on PR #36084:
URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842915896
@potiuk @Taragolis yeah, in the end we all agreed on removing the
annotation. Went for it
--
This is an automated message from the Apache Git Service.
To respond to the message, p
potiuk commented on PR #36084:
URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842875683
BTw. @Taragolis in slack mentioned that just removing the annotation might
work ... so maybe ?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
potiuk commented on code in PR #36084:
URL: https://github.com/apache/airflow/pull/36084#discussion_r1417273983
##
airflow/providers/openlineage/plugins/facets.py:
##
@@ -63,7 +67,9 @@ class UnknownOperatorInstance(RedactMixin):
properties: dict[str, object]
type: str
potiuk commented on code in PR #36084:
URL: https://github.com/apache/airflow/pull/36084#discussion_r1417273791
##
airflow/providers/openlineage/plugins/facets.py:
##
@@ -28,7 +30,9 @@ class AirflowMappedTaskRunFacet(BaseFacet):
mapIndex: int
operatorClass: str
-
JDarDagran commented on PR #36084:
URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842726791
@potiuk thanks for your thorough explanation.
After all it seems like I should bump the dependency version as the change
in `openlineage-python` is correct, we just want to have al
potiuk commented on PR #36084:
URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842714520
Longer explanation:
> I'm not sure why mypy fails now - it looks the opposite to what happens in
main.
Yes. This is entirely expected that your PR will have 'regular' constr
JDarDagran commented on PR #36084:
URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842704615
Okay, how about we remove annotations in provider now as suggested by
@Taragolis?
Not sure if we ever want to add them back once contraints for
`openlineage-python` are updated wi
potiuk commented on PR #36084:
URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842699757
@JDarDagran https://github.com/apache/airflow/tree/constraints-main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
potiuk commented on PR #36084:
URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842698048
> I'm not sure why mypy fails now - it looks the opposite to what happens
in main.
How to check what versions of packages are installed in the CI env?
If PR does not change dep
Taragolis commented on code in PR #36084:
URL: https://github.com/apache/airflow/pull/36084#discussion_r1417097596
##
airflow/providers/openlineage/plugins/facets.py:
##
@@ -28,7 +30,7 @@ class AirflowMappedTaskRunFacet(BaseFacet):
mapIndex: int
operatorClass: str
-
JDarDagran commented on PR #36084:
URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842509172
I'm not sure why mypy fails now - it looks the opposite to what happens in
main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
JDarDagran opened a new pull request, #36084:
URL: https://github.com/apache/airflow/pull/36084
Recent OpenLineage release introduced a change that breaks mypy in main.
This PR fixes it.
--
This is an automated message from the Apache Git Service.
To respond to the message
13 matches
Mail list logo
