[jira] [Updated] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong updated AIRFLOW-2192: -- Fix Version/s: 1.10.1 > Don't authenticate on Google Authentication >

[jira] [Commented] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675594#comment-16675594 ] Fokko Driesprong commented on AIRFLOW-2192: --- Thanks for adding the test. Still, bit confused

[GitHub] dimberman commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2018-11-05 Thread GitBox
dimberman commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-435990338 @Fokko LGTM This is an automated message from the

[GitHub] dimberman commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2018-11-05 Thread GitBox
dimberman commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#discussion_r219713160 ## File path: scripts/ci/kubernetes/kube/deploy.sh ## @@ -22,16 +22,130 @@ set -x

[GitHub] dgies commented on issue #2058: [AIRFLOW-850] Add a PythonSensor

2018-11-05 Thread GitBox
dgies commented on issue #2058: [AIRFLOW-850] Add a PythonSensor URL: https://github.com/apache/incubator-airflow/pull/2058#issuecomment-435989528 I still think it's a good idea, but don't have any time to contribute. On Mon, Nov 5, 2018 at 10:44 AM Fokko Driesprong

[GitHub] Fokko commented on issue #2632: [AIRFLOW-1642] Use scoped_session in alembic revision cc1e65623dc7

2018-11-05 Thread GitBox
Fokko commented on issue #2632: [AIRFLOW-1642] Use scoped_session in alembic revision cc1e65623dc7 URL: https://github.com/apache/incubator-airflow/pull/2632#issuecomment-435988382 I'm also a big fan of the with-comprehension when it comes to database sessions.

[GitHub] Fokko commented on issue #2058: [AIRFLOW-850] Add a PythonSensor

2018-11-05 Thread GitBox
Fokko commented on issue #2058: [AIRFLOW-850] Add a PythonSensor URL: https://github.com/apache/incubator-airflow/pull/2058#issuecomment-435987793 @dgies Still working on this? I was amazed that this wasn't in (yet). This is

[GitHub] Fokko commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync

2018-11-05 Thread GitBox
Fokko commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-435987410 @odracci Can you rebase? @dimberman Final thoughts?

[GitHub] morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
morgendave commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-435987126 > @morgendave Can you rebase onto master as well? Sure, thanks for the reminder

[jira] [Commented] (AIRFLOW-2780) Adds IMAP Hook to interact with a mail server

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675575#comment-16675575 ] ASF GitHub Bot commented on AIRFLOW-2780: - Fokko closed pull request #4119: [AIRFLOW-2780] Add

[GitHub] Fokko closed pull request #4119: [AIRFLOW-2780] Add IMAP Hook to retrieve email attachments

2018-11-05 Thread GitBox
Fokko closed pull request #4119: [AIRFLOW-2780] Add IMAP Hook to retrieve email attachments URL: https://github.com/apache/incubator-airflow/pull/4119 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Closed] (AIRFLOW-3218) Support for DAG level poking in external task sensor

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong closed AIRFLOW-3218. - Resolution: Fixed Fix Version/s: 2.0.0 > Support for DAG level poking in

[jira] [Commented] (AIRFLOW-3218) Support for DAG level poking in external task sensor

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675568#comment-16675568 ] ASF GitHub Bot commented on AIRFLOW-3218: - Fokko closed pull request #4058: [AIRFLOW-3218] add

[jira] [Created] (AIRFLOW-3300) Frequent crash of scheduler while interacting with Airflow Metadata (Mysql)

2018-11-05 Thread Tanuj Gupta (JIRA)
Tanuj Gupta created AIRFLOW-3300: Summary: Frequent crash of scheduler while interacting with Airflow Metadata (Mysql) Key: AIRFLOW-3300 URL: https://issues.apache.org/jira/browse/AIRFLOW-3300

[GitHub] Fokko closed pull request #4058: [AIRFLOW-3218] add support for poking a whole DAG

2018-11-05 Thread GitBox
Fokko closed pull request #4058: [AIRFLOW-3218] add support for poking a whole DAG URL: https://github.com/apache/incubator-airflow/pull/4058 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] Fokko commented on issue #4090: [AIRFLOW-3250] Fix for Redis Hook for not authorised connection calls

2018-11-05 Thread GitBox
Fokko commented on issue #4090: [AIRFLOW-3250] Fix for Redis Hook for not authorised connection calls URL: https://github.com/apache/incubator-airflow/pull/4090#issuecomment-435981193 @smentek Can you fix the CI? This is an

[GitHub] Fokko commented on issue #4089: adding image_pull_secrets into pod at creation inside operator

2018-11-05 Thread GitBox
Fokko commented on issue #4089: adding image_pull_secrets into pod at creation inside operator URL: https://github.com/apache/incubator-airflow/pull/4089#issuecomment-435980633 @Padarn Can you adhere to the git commit guidelines?

[GitHub] Fokko commented on issue #4057: [AIRFLOW-3216] HiveServer2Hook need a password with LDAP authentication

2018-11-05 Thread GitBox
Fokko commented on issue #4057: [AIRFLOW-3216] HiveServer2Hook need a password with LDAP authentication URL: https://github.com/apache/incubator-airflow/pull/4057#issuecomment-435978104 Thanks @jongyoul This is an

[GitHub] noqcks commented on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT

2018-11-05 Thread GitBox
noqcks commented on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT URL: https://github.com/apache/incubator-airflow/pull/3519#issuecomment-435977696 We attempted very briefly to get things working with this branch, but with no success. We are new to

[GitHub] Fokko commented on issue #4114: [AIRFLOW-3259] Fix internal server error when displaying charts

2018-11-05 Thread GitBox
Fokko commented on issue #4114: [AIRFLOW-3259] Fix internal server error when displaying charts URL: https://github.com/apache/incubator-airflow/pull/4114#issuecomment-435977563 @zackmeso Do you know any way how to verify this patch?

[GitHub] Fokko commented on issue #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

2018-11-05 Thread GitBox
Fokko commented on issue #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/4068#issuecomment-435977247 @oelesinsc24 Travis is still not happy: ```

[jira] [Commented] (AIRFLOW-3160) Load latest_dagruns asynchronously

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675518#comment-16675518 ] ASF GitHub Bot commented on AIRFLOW-3160: - Fokko closed pull request #4005: [AIRFLOW-3160] Load

[jira] [Resolved] (AIRFLOW-3160) Load latest_dagruns asynchronously

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-3160. --- Resolution: Fixed Fix Version/s: 2.0.0 > Load latest_dagruns asynchronously

[GitHub] Fokko commented on issue #4005: [AIRFLOW-3160] Load latest_dagruns asynchronously, speed up front page load time

2018-11-05 Thread GitBox
Fokko commented on issue #4005: [AIRFLOW-3160] Load latest_dagruns asynchronously, speed up front page load time URL: https://github.com/apache/incubator-airflow/pull/4005#issuecomment-435976502 Merged @aoen. High risk, high reward! 

[GitHub] Fokko closed pull request #4005: [AIRFLOW-3160] Load latest_dagruns asynchronously, speed up front page load time

2018-11-05 Thread GitBox
Fokko closed pull request #4005: [AIRFLOW-3160] Load latest_dagruns asynchronously, speed up front page load time URL: https://github.com/apache/incubator-airflow/pull/4005 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] Fokko commented on issue #4101: [AIRFLOW-3272] Add base grpc hook

2018-11-05 Thread GitBox
Fokko commented on issue #4101: [AIRFLOW-3272] Add base grpc hook URL: https://github.com/apache/incubator-airflow/pull/4101#issuecomment-435975968 @morgendave Can you rebase onto master as well? This is an automated message

[GitHub] Fokko commented on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT

2018-11-05 Thread GitBox
Fokko commented on issue #3519: [AIRFLOW-2642] fix wrong value git-sync initcontainer env GIT_SYNC_ROOT URL: https://github.com/apache/incubator-airflow/pull/3519#issuecomment-435975665 @noqcks Can you verify if this fix works for you?

[GitHub] feng-tao commented on issue #3584: [AIRFLOW-249] Refactor the SLA mechanism

2018-11-05 Thread GitBox
feng-tao commented on issue #3584: [AIRFLOW-249] Refactor the SLA mechanism URL: https://github.com/apache/incubator-airflow/pull/3584#issuecomment-435973025 I could help to take a look. But I currently don't have the env to run/test it ...

[GitHub] Fokko commented on issue #3584: [AIRFLOW-249] Refactor the SLA mechanism

2018-11-05 Thread GitBox
Fokko commented on issue #3584: [AIRFLOW-249] Refactor the SLA mechanism URL: https://github.com/apache/incubator-airflow/pull/3584#issuecomment-435971814 For me, the main issue is that I've never touched the SLA mechanism. Would be nice to have someone review this who is knowledgeable

[GitHub] evizitei commented on issue #4082: [AIRFLOW-2865] Call success_callback before updating task state

2018-11-05 Thread GitBox
evizitei commented on issue #4082: [AIRFLOW-2865] Call success_callback before updating task state URL: https://github.com/apache/incubator-airflow/pull/4082#issuecomment-435962763 Sure, I understand, just wanted to make sure I hadn't accidentally kicked myself into a process black hole

[GitHub] codecov-io edited a comment on issue #3960: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-05 Thread GitBox
codecov-io edited a comment on issue #3960: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/3960#issuecomment-425409131 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3960?src=pr=h1) Report > Merging

[GitHub] ashb commented on issue #3584: [AIRFLOW-249] Refactor the SLA mechanism

2018-11-05 Thread GitBox
ashb commented on issue #3584: [AIRFLOW-249] Refactor the SLA mechanism URL: https://github.com/apache/incubator-airflow/pull/3584#issuecomment-435961220 Sorry @Eronarn it sucks when you open a PR and keep it from conflicting only to get no traction from the maintainers (been there, done

[jira] [Resolved] (AIRFLOW-2865) Race condition between on_success_callback and LocalTaskJob's cleanup

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-2865. Resolution: Fixed Fix Version/s: 2.0.0 > Race condition between

[jira] [Commented] (AIRFLOW-2865) Race condition between on_success_callback and LocalTaskJob's cleanup

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675455#comment-16675455 ] ASF GitHub Bot commented on AIRFLOW-2865: - ashb closed pull request #4082: [AIRFLOW-2865] Call

[GitHub] ashb commented on issue #4082: [AIRFLOW-2865] Call success_callback before updating task state

2018-11-05 Thread GitBox
ashb commented on issue #4082: [AIRFLOW-2865] Call success_callback before updating task state URL: https://github.com/apache/incubator-airflow/pull/4082#issuecomment-435960350 Thanks for the detailed description, it made this much much easier to review and reason about :D

[GitHub] ashb closed pull request #4082: [AIRFLOW-2865] Call success_callback before updating task state

2018-11-05 Thread GitBox
ashb closed pull request #4082: [AIRFLOW-2865] Call success_callback before updating task state URL: https://github.com/apache/incubator-airflow/pull/4082 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ashb commented on issue #4082: [AIRFLOW-2865] Call success_callback before updating task state

2018-11-05 Thread GitBox
ashb commented on issue #4082: [AIRFLOW-2865] Call success_callback before updating task state URL: https://github.com/apache/incubator-airflow/pull/4082#issuecomment-435959347 @evizitei No, nothing you've done wrong - it's a lack of time on the part of the (volunteer-based) committers.

[GitHub] Fokko commented on a change in pull request #4056: [AIRFLOW-3207] option to stop task pushing result to xcom

2018-11-05 Thread GitBox
Fokko commented on a change in pull request #4056: [AIRFLOW-3207] option to stop task pushing result to xcom URL: https://github.com/apache/incubator-airflow/pull/4056#discussion_r230836575 ## File path: airflow/models.py ## @@ -2473,6 +2476,7 @@ def __init__(

[jira] [Commented] (AIRFLOW-3299) Logs for currently running tasks fail to load

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675446#comment-16675446 ] Ash Berlin-Taylor commented on AIRFLOW-3299: Hacks upon hacks :( Not sure the fix. If we

[GitHub] Fokko commented on issue #3960: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor

2018-11-05 Thread GitBox
Fokko commented on issue #3960: [AIRFLOW-2966] Catch ApiException in the Kubernetes Executor URL: https://github.com/apache/incubator-airflow/pull/3960#issuecomment-435956829 Sorry @johnhofman, I was a bit busy. I've restarted the failing test, let's see if it passes now. The Kubernetes

[jira] [Commented] (AIRFLOW-3299) Logs for currently running tasks fail to load

2018-11-05 Thread Brad Holmes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675441#comment-16675441 ] Brad Holmes commented on AIRFLOW-3299: -- And there it is:

[jira] [Comment Edited] (AIRFLOW-3299) Logs for currently running tasks fail to load

2018-11-05 Thread Brad Holmes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675437#comment-16675437 ] Brad Holmes edited comment on AIRFLOW-3299 at 11/5/18 5:09 PM: --- I see. 

[jira] [Commented] (AIRFLOW-3299) Logs for currently running tasks fail to load

2018-11-05 Thread Brad Holmes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675437#comment-16675437 ] Brad Holmes commented on AIRFLOW-3299: -- I see, I think the problem is specific to my sensor task

[jira] [Commented] (AIRFLOW-3299) Logs for currently running tasks fail to load

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675432#comment-16675432 ] Ash Berlin-Taylor commented on AIRFLOW-3299: My memory is a bit hazy now, but As soon as

[jira] [Commented] (AIRFLOW-3299) Logs for currently running tasks fail to load

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675430#comment-16675430 ] Ash Berlin-Taylor commented on AIRFLOW-3299: When you say "not appearing" what do you mean?

[jira] [Updated] (AIRFLOW-3295) Require encryption in DaskExecutor when certificates are configured.

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3295: --- Summary: Require encryption in DaskExecutor when certificates are configured.

[jira] [Created] (AIRFLOW-3299) Logs for currently running tasks fail to load

2018-11-05 Thread Brad Holmes (JIRA)
Brad Holmes created AIRFLOW-3299: Summary: Logs for currently running tasks fail to load Key: AIRFLOW-3299 URL: https://issues.apache.org/jira/browse/AIRFLOW-3299 Project: Apache Airflow

[jira] [Resolved] (AIRFLOW-3295) Potential Security Issue in DaskExecutor

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3295. Resolution: Fixed Fix Version/s: 1.10.1 2.0.0 >

[GitHub] ashb commented on issue #1933: [AIRFLOW-689] Okta Authentication

2018-11-05 Thread GitBox
ashb commented on issue #1933: [AIRFLOW-689] Okta Authentication URL: https://github.com/apache/incubator-airflow/pull/1933#issuecomment-435950923 The new RBAC-based Webserver is what we recommend people use going forward, and to integrate Okta with that something like

[jira] [Updated] (AIRFLOW-2190) base_url with a subpath generates TypeError

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-2190: --- Affects Version/s: 1.10.1 > base_url with a subpath generates TypeError >

[jira] [Updated] (AIRFLOW-3159) Update Airflow documentation on GCP Logging

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3159: --- Fix Version/s: 1.10.1 > Update Airflow documentation on GCP Logging >

[jira] [Commented] (AIRFLOW-3279) Documentation for Google Logging unclear

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675427#comment-16675427 ] Ash Berlin-Taylor commented on AIRFLOW-3279: Those docs are a bit out of date -we've fixed

[GitHub] ashb commented on a change in pull request #4129: [AIRFLOW-3294] Update connections form and integration docs

2018-11-05 Thread GitBox
ashb commented on a change in pull request #4129: [AIRFLOW-3294] Update connections form and integration docs URL: https://github.com/apache/incubator-airflow/pull/4129#discussion_r230827738 ## File path: docs/integration.rst ## @@ -1011,3 +1011,13 @@ QuboleFileSensor

[GitHub] ashb commented on issue #4132: [AIRFLOW-3298] Return None if user not found in session.

2018-11-05 Thread GitBox
ashb commented on issue #4132: [AIRFLOW-3298] Return None if user not found in session. URL: https://github.com/apache/incubator-airflow/pull/4132#issuecomment-435946042 In tests/core.py there is a `test_login_logout_ldap` function - and I think you can add to the session via `self.app`

[jira] [Updated] (AIRFLOW-3112) Align SFTP hook with SSH hook

2018-11-05 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-3112: Fix Version/s: (was: 2.0.0) 1.10.1 > Align SFTP hook with SSH hook >

[GitHub] ashb commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP

2018-11-05 Thread GitBox
ashb commented on a change in pull request #4006: [AIRFLOW-3164] Verify server certificate when connecting to LDAP URL: https://github.com/apache/incubator-airflow/pull/4006#discussion_r230821322 ## File path: airflow/contrib/auth/backends/ldap_auth.py ## @@ -55,16 +55,20

[jira] [Commented] (AIRFLOW-3262) Can't get log containing Response when using SimpleHttpOperator

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675413#comment-16675413 ] ASF GitHub Bot commented on AIRFLOW-3262: - kaxil opened a new pull request #4135:

[GitHub] kaxil opened a new pull request #4135: [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com

2018-11-05 Thread GitBox
kaxil opened a new pull request #4135: [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com URL: https://github.com/apache/incubator-airflow/pull/4135 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Resolved] (AIRFLOW-3268) Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3268. - Resolution: Fixed Fix Version/s: 1.10.1 Resolved by

[jira] [Updated] (AIRFLOW-3265) Mysql Hook does not support "unix_socket" extra

2018-11-05 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-3265: Fix Version/s: (was: 2.0.0) 1.10.1 > Mysql Hook does not support

[jira] [Commented] (AIRFLOW-3022) Add volume mount to KubernetesExecutorConfig

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675403#comment-16675403 ] ASF GitHub Bot commented on AIRFLOW-3022: - ashb closed pull request #3855: [AIRFLOW-3022] Add

[GitHub] ashb closed pull request #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig

2018-11-05 Thread GitBox
ashb closed pull request #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig URL: https://github.com/apache/incubator-airflow/pull/3855 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ashb commented on issue #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig

2018-11-05 Thread GitBox
ashb commented on issue #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig URL: https://github.com/apache/incubator-airflow/pull/3855#issuecomment-435938196 Don't worry about squashing - Github will do that for us.

[GitHub] ckljohn commented on issue #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig

2018-11-05 Thread GitBox
ckljohn commented on issue #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig URL: https://github.com/apache/incubator-airflow/pull/3855#issuecomment-435937949 Should I squash the commits? This is an

[GitHub] ashb commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint

2018-11-05 Thread GitBox
ashb commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint URL: https://github.com/apache/incubator-airflow/pull/4126#discussion_r230815782 ## File path:

[GitHub] ashb commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint

2018-11-05 Thread GitBox
ashb commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint URL: https://github.com/apache/incubator-airflow/pull/4126#discussion_r230813140 ## File path:

[GitHub] ashb commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint

2018-11-05 Thread GitBox
ashb commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint URL: https://github.com/apache/incubator-airflow/pull/4126#discussion_r230810900 ## File path:

[jira] [Commented] (AIRFLOW-3268) Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675393#comment-16675393 ] ASF GitHub Bot commented on AIRFLOW-3268: - kaxil closed pull request #4113: [AIRFLOW-3268]

[GitHub] kaxil commented on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread GitBox
kaxil commented on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL URL: https://github.com/apache/incubator-airflow/pull/4113#issuecomment-435937003 Awesome. Thanks @potiuk This is an

[GitHub] kaxil closed pull request #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread GitBox
kaxil closed pull request #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL URL: https://github.com/apache/incubator-airflow/pull/4113 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[jira] [Commented] (AIRFLOW-3213) Create ADLS to GCS operator

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675389#comment-16675389 ] ASF GitHub Bot commented on AIRFLOW-3213: - bkvarda opened a new pull request #4134:

[GitHub] bkvarda opened a new pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator

2018-11-05 Thread GitBox
bkvarda opened a new pull request #4134: [AIRFLOW-3213] Create ADLS to GCS operator URL: https://github.com/apache/incubator-airflow/pull/4134 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-3017) 404 error when opening log in the Web UI

2018-11-05 Thread Brad Holmes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675388#comment-16675388 ] Brad Holmes commented on AIRFLOW-3017: -- The typo I suppose is here:

[GitHub] ashb commented on a change in pull request #2747: AIRFLOW-1772: Fix bug with handling cron expressions as an schedule i…

2018-11-05 Thread GitBox
ashb commented on a change in pull request #2747: AIRFLOW-1772: Fix bug with handling cron expressions as an schedule i… URL: https://github.com/apache/incubator-airflow/pull/2747#discussion_r230809491 ## File path: airflow/contrib/sensors/gcs_sensor.py ## @@ -67,8 +66,7

[jira] [Reopened] (AIRFLOW-3239) Test discovery partial fails due to incorrect name of the test files

2018-11-05 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-3239: [~Fokko] I don't think this ticket is done until tests/core.py and test.jobs.py are

[jira] [Commented] (AIRFLOW-3270) Apache airflow 1.10.0 integration with LDAP anonmyously

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675364#comment-16675364 ] ASF GitHub Bot commented on AIRFLOW-3270: - ashb opened a new pull request #4133: [AIRFLOW-3270]

[GitHub] ashb opened a new pull request #4133: [AIRFLOW-3270] Allow passwordless-binding for LDAP auth backend

2018-11-05 Thread GitBox
ashb opened a new pull request #4133: [AIRFLOW-3270] Allow passwordless-binding for LDAP auth backend URL: https://github.com/apache/incubator-airflow/pull/4133 Make sure you have checked _all_ steps below. ### Jira - [ ] https://issues.apache.org/jira/browse/AIRFLOW-3270

[GitHub] codecov-io edited a comment on issue #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job

2018-11-05 Thread GitBox
codecov-io edited a comment on issue #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job URL: https://github.com/apache/incubator-airflow/pull/4108#issuecomment-433685129 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4108?src=pr=h1)

[GitHub] XD-DENG commented on issue #4131: [AIRFLOW-3239] Further fix of CI tests

2018-11-05 Thread GitBox
XD-DENG commented on issue #4131: [AIRFLOW-3239] Further fix of CI tests URL: https://github.com/apache/incubator-airflow/pull/4131#issuecomment-435927712 Thanks @Fokko This is an automated message from the Apache Git

[GitHub] codecov-io edited a comment on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread GitBox
codecov-io edited a comment on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL URL: https://github.com/apache/incubator-airflow/pull/4113#issuecomment-434089073 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4113?src=pr=h1) Report >

[jira] [Commented] (AIRFLOW-3239) Test discovery partial fails due to incorrect name of the test files

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675345#comment-16675345 ] ASF GitHub Bot commented on AIRFLOW-3239: - Fokko closed pull request #4131: [AIRFLOW-3239]

[jira] [Resolved] (AIRFLOW-3239) Test discovery partial fails due to incorrect name of the test files

2018-11-05 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-3239. --- Resolution: Fixed Fix Version/s: 2.0.0 > Test discovery partial fails due

[GitHub] Fokko closed pull request #4131: [AIRFLOW-3239] Further fix of CI tests

2018-11-05 Thread GitBox
Fokko closed pull request #4131: [AIRFLOW-3239] Further fix of CI tests URL: https://github.com/apache/incubator-airflow/pull/4131 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] Fokko removed a comment on issue #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig

2018-11-05 Thread GitBox
Fokko removed a comment on issue #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig URL: https://github.com/apache/incubator-airflow/pull/3855#issuecomment-435925157 Love the test @ckljohn. What do you think @ashb ?

[GitHub] Fokko commented on issue #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig

2018-11-05 Thread GitBox
Fokko commented on issue #3855: [AIRFLOW-3022] Add volume mount to KubernetesExecutorConfig URL: https://github.com/apache/incubator-airflow/pull/3855#issuecomment-435925157 Love the test @ckljohn. What do you think @ashb ?

[GitHub] ashb commented on a change in pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible

2018-11-05 Thread GitBox
ashb commented on a change in pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible URL: https://github.com/apache/incubator-airflow/pull/2460#discussion_r230797684 ## File path: airflow/models.py ## @@ -3055,6 +3055,37 @@ def

[GitHub] codecov-io commented on issue #4131: [AIRFLOW-3239] Further fix of CI tests

2018-11-05 Thread GitBox
codecov-io commented on issue #4131: [AIRFLOW-3239] Further fix of CI tests URL: https://github.com/apache/incubator-airflow/pull/4131#issuecomment-435919917 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4131?src=pr=h1) Report > Merging

[GitHub] Fokko commented on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions modification via UI do not persist

2018-11-05 Thread GitBox
Fokko commented on issue #4118: [AIRFLOW-3271] Airflow RBAC Permissions modification via UI do not persist URL: https://github.com/apache/incubator-airflow/pull/4118#issuecomment-435916572 Travis is unhappy: ``` ==

[GitHub] codecov-io edited a comment on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread GitBox
codecov-io edited a comment on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL URL: https://github.com/apache/incubator-airflow/pull/4113#issuecomment-434089073 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4113?src=pr=h1) Report >

[GitHub] potiuk commented on issue #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job

2018-11-05 Thread GitBox
potiuk commented on issue #4108: [AIRFLOW-3263] Ignore exception when 'run' tries to kill already killed job URL: https://github.com/apache/incubator-airflow/pull/4108#issuecomment-435915276 Sure @ashb . Magic is not good :).

[GitHub] ultrabug commented on issue #2460: [AIRFLOW-1424] make the next execution date of DAGs visible

2018-11-05 Thread GitBox
ultrabug commented on issue #2460: [AIRFLOW-1424] make the next execution date of DAGs visible URL: https://github.com/apache/incubator-airflow/pull/2460#issuecomment-435914220 Interesting to see this, the author of the CLI implementation assumed that there can't be a next schedule if

[GitHub] potiuk commented on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread GitBox
potiuk commented on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL URL: https://github.com/apache/incubator-airflow/pull/4113#issuecomment-435913986 Sure :). Done. This is an automated

[GitHub] kaxil commented on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread GitBox
kaxil commented on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL URL: https://github.com/apache/incubator-airflow/pull/4113#issuecomment-435912138 @potiuk Thanks, appreciate that :) . Can you update the commit message as well to something along the

[GitHub] XD-DENG commented on a change in pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible

2018-11-05 Thread GitBox
XD-DENG commented on a change in pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible URL: https://github.com/apache/incubator-airflow/pull/2460#discussion_r230786250 ## File path: airflow/models.py ## @@ -3732,6 +3732,37 @@ def

[GitHub] ultrabug commented on issue #2460: [AIRFLOW-1424] make the next execution date of DAGs visible

2018-11-05 Thread GitBox
ultrabug commented on issue #2460: [AIRFLOW-1424] make the next execution date of DAGs visible URL: https://github.com/apache/incubator-airflow/pull/2460#issuecomment-435908366 Thanks for pointing this out @Fokko, I totally forgot to check the cli test suite

[GitHub] Fokko commented on issue #4131: [AIRFLOW-3239] Further fix of CI tests

2018-11-05 Thread GitBox
Fokko commented on issue #4131: [AIRFLOW-3239] Further fix of CI tests URL: https://github.com/apache/incubator-airflow/pull/4131#issuecomment-435907925 @XD-DENG Running again!  This is an automated message from the Apache

[GitHub] XD-DENG commented on issue #4131: [AIRFLOW-3239] Further fix of CI tests

2018-11-05 Thread GitBox
XD-DENG commented on issue #4131: [AIRFLOW-3239] Further fix of CI tests URL: https://github.com/apache/incubator-airflow/pull/4131#issuecomment-435905147 Hi @Fokko , 2 out of 9 tests encountered errors. Is it possible to restart these two tests? Cheers.

[GitHub] potiuk commented on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL

2018-11-05 Thread GitBox
potiuk commented on issue #4113: [AIRFLOW-3268] Cannot pass SSL dictionary to mysql connection via URL URL: https://github.com/apache/incubator-airflow/pull/4113#issuecomment-435903446 Hey @kaxil - Why not :). I added it now, reverse engineering it from the code. It's good to leave the

[GitHub] codecov-io edited a comment on issue #4132: [AIRFLOW-3298] Return None if user not found in session.

2018-11-05 Thread GitBox
codecov-io edited a comment on issue #4132: [AIRFLOW-3298] Return None if user not found in session. URL: https://github.com/apache/incubator-airflow/pull/4132#issuecomment-435903185 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4132?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4132: [AIRFLOW-3298] Return None if user not found in session.

2018-11-05 Thread GitBox
codecov-io commented on issue #4132: [AIRFLOW-3298] Return None if user not found in session. URL: https://github.com/apache/incubator-airflow/pull/4132#issuecomment-435903185 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4132?src=pr=h1) Report > Merging

<    1   2   3   >