[GitHub] [beam] sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10

2020-02-28 Thread GitBox
sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10 URL: https://github.com/apache/beam/pull/10945#issuecomment-592885034 Run Spotless PreCommit

[GitHub] [beam] sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10

2020-02-28 Thread GitBox
sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10 URL: https://github.com/apache/beam/pull/10945#issuecomment-592885120 Run CommunityMetrics PreCommit

[GitHub] [beam] sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10

2020-02-28 Thread GitBox
sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10 URL: https://github.com/apache/beam/pull/10945#issuecomment-592882962 @mxm Thanks for the review. I have updated the PR according to your comments. Currently

[GitHub] [beam] sunjincheng121 commented on a change in pull request #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10

2020-02-28 Thread GitBox
sunjincheng121 commented on a change in pull request #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10 URL: https://github.com/apache/beam/pull/10945#discussion_r386002840 ## File path:

[GitHub] [beam] sunjincheng121 commented on issue #10940: [BEAM-9288] Not bundle conscrypt in gRPC vendor

2020-02-28 Thread GitBox
sunjincheng121 commented on issue #10940: [BEAM-9288] Not bundle conscrypt in gRPC vendor URL: https://github.com/apache/beam/pull/10940#issuecomment-592871735 Run Java PreCommit This is an automated message from the Apache

[GitHub] [beam] angoenka commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-28 Thread GitBox
angoenka commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-592832262 Thanks @chadrik @udim Just a quick reminder that we should squash the fixup related commits to keep the history clean based on the

[GitHub] [beam] pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-28 Thread GitBox
pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#discussion_r385984734 ## File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py ## @@ -421,8 +424,12 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-28 Thread GitBox
pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#discussion_r385981104 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -314,3 +355,239 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-28 Thread GitBox
pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#discussion_r385983264 ## File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py ## @@ -432,6 +439,45 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-28 Thread GitBox
pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#discussion_r385980992 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -314,3 +355,239 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-28 Thread GitBox
pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#discussion_r385980425 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -314,3 +355,239 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-28 Thread GitBox
pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#discussion_r385984836 ## File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py ## @@ -471,7 +517,14 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-28 Thread GitBox
pabloem commented on a change in pull request #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#discussion_r385979045 ## File path: sdks/python/apache_beam/testing/test_stream.py ## @@ -314,3 +355,239 @@ def

[GitHub] [beam] stale[bot] closed pull request #10426: [WIP] Datetime functions prototype

2020-02-28 Thread GitBox
stale[bot] closed pull request #10426: [WIP] Datetime functions prototype URL: https://github.com/apache/beam/pull/10426 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] stale[bot] commented on issue #10426: [WIP] Datetime functions prototype

2020-02-28 Thread GitBox
stale[bot] commented on issue #10426: [WIP] Datetime functions prototype URL: https://github.com/apache/beam/pull/10426#issuecomment-592790133 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the

[GitHub] [beam] boyuanzz commented on a change in pull request #10972: [WIP] Add DeduplicationByUniqueId transform

2020-02-28 Thread GitBox
boyuanzz commented on a change in pull request #10972: [WIP] Add DeduplicationByUniqueId transform URL: https://github.com/apache/beam/pull/10972#discussion_r385979470 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py ## @@ -543,6 +545,15 @@

[GitHub] [beam] rohdesamuel closed pull request #10391: [BEAM-8335] Implement the StreamingCacheManager

2020-02-28 Thread GitBox
rohdesamuel closed pull request #10391: [BEAM-8335] Implement the StreamingCacheManager URL: https://github.com/apache/beam/pull/10391 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] rohdesamuel closed pull request #10368: [BEAM-8335] Modify PipelineInstrument to add TestStream for unbounded PCollections

2020-02-28 Thread GitBox
rohdesamuel closed pull request #10368: [BEAM-8335] Modify PipelineInstrument to add TestStream for unbounded PCollections URL: https://github.com/apache/beam/pull/10368 This is an automated message from the Apache Git

[GitHub] [beam] Hannah-Jiang opened a new pull request #11006: [WIP][BEAM-9136]Add licenses for dependencies

2020-02-28 Thread GitBox
Hannah-Jiang opened a new pull request #11006: [WIP][BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11006 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] lostluck commented on a change in pull request #10991: [BEAM-3301] Refactor DoFn validation & allow specifying main inputs.

2020-02-28 Thread GitBox
lostluck commented on a change in pull request #10991: [BEAM-3301] Refactor DoFn validation & allow specifying main inputs. URL: https://github.com/apache/beam/pull/10991#discussion_r385468257 ## File path: sdks/go/pkg/beam/core/graph/fn.go ## @@ -209,21 +209,58 @@ func

[GitHub] [beam] lostluck commented on a change in pull request #10991: [BEAM-3301] Refactor DoFn validation & allow specifying main inputs.

2020-02-28 Thread GitBox
lostluck commented on a change in pull request #10991: [BEAM-3301] Refactor DoFn validation & allow specifying main inputs. URL: https://github.com/apache/beam/pull/10991#discussion_r385893620 ## File path: sdks/go/pkg/beam/core/graph/fn.go ## @@ -209,21 +209,58 @@ func

[beam] branch master updated (5ff5313 -> 6e69b26)

2020-02-28 Thread udim
This is an automated email from the ASF dual-hosted git repository. udim pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 5ff5313 [BEAM-9287] Add Postcommit tests for dataflow runner v2 (#10998) add af69a78 [BEAM-9405] Fix

[GitHub] [beam] udim merged pull request #11001: [BEAM-9405] Fix post-commit error about create_job_service

2020-02-28 Thread GitBox
udim merged pull request #11001: [BEAM-9405] Fix post-commit error about create_job_service URL: https://github.com/apache/beam/pull/11001 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] udim commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service

2020-02-28 Thread GitBox
udim commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service URL: https://github.com/apache/beam/pull/11001#issuecomment-592778581 > @udim tests pass. > > btw, I don't have the ability to merge this. should I? Perhaps you need to also be a member

[GitHub] [beam] angoenka merged pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka merged pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998 This is an automated message from the Apache Git Service. To respond to the

[beam] branch master updated (036560f -> 5ff5313)

2020-02-28 Thread goenka
This is an automated email from the ASF dual-hosted git repository. goenka pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 036560f Merge pull request #10999: [BEAM-9345] Fix source of test flakiness in FlinkSubmissionTest add 5ff5313

[GitHub] [beam] angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592776224 Thanks! This is an automated message from the Apache Git

[GitHub] [beam] chadrik commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service

2020-02-28 Thread GitBox
chadrik commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service URL: https://github.com/apache/beam/pull/11001#issuecomment-592774486 @udim tests pass. btw, I don't have the ability to merge this. should I?

[GitHub] [beam] yifanzou commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
yifanzou commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592774593 LGTM, thanks! This is an automated message from the Apache

[beam] branch master updated (c7c28f6 -> 036560f)

2020-02-28 Thread mxm
This is an automated email from the ASF dual-hosted git repository. mxm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from c7c28f6 [BEAM-8487] Handle nested forward references (#10932) add 10883c8 [BEAM-9345] Fix source of test flakiness

[GitHub] [beam] mxm merged pull request #10999: [BEAM-9345] Fix source of test flakiness in FlinkSubmissionTest

2020-02-28 Thread GitBox
mxm merged pull request #10999: [BEAM-9345] Fix source of test flakiness in FlinkSubmissionTest URL: https://github.com/apache/beam/pull/10999 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] bumblebee-coming commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.

2020-02-28 Thread GitBox
bumblebee-coming commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners. URL: https://github.com/apache/beam/pull/10951#discussion_r385962866 ## File path: sdks/python/apache_beam/transforms/combiners_test.py ## @@ -470,6

[GitHub] [beam] kennknowles commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite

2020-02-28 Thread GitBox
kennknowles commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite URL: https://github.com/apache/beam/pull/10559#issuecomment-592766578 I will note here that the user can also do this relocation as a workaround so it is not a blocker (also not a regression since we

[GitHub] [beam] kennknowles commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite

2020-02-28 Thread GitBox
kennknowles commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite URL: https://github.com/apache/beam/pull/10559#issuecomment-592766259 (Confirmed manually that the old string is gone and the new one is present)

[GitHub] [beam] lukecwik commented on issue #10940: [BEAM-9288] Not bundle conscrypt in gRPC vendor

2020-02-28 Thread GitBox
lukecwik commented on issue #10940: [BEAM-9288] Not bundle conscrypt in gRPC vendor URL: https://github.com/apache/beam/pull/10940#issuecomment-592765216 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] udim merged pull request #10932: [BEAM-8487] Handle nested forward references

2020-02-28 Thread GitBox
udim merged pull request #10932: [BEAM-8487] Handle nested forward references URL: https://github.com/apache/beam/pull/10932 This is an automated message from the Apache Git Service. To respond to the message, please log on

[beam] branch master updated (2f10df9 -> c7c28f6)

2020-02-28 Thread udim
This is an automated email from the ASF dual-hosted git repository. udim pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 2f10df9 Merge pull request #10822: [BEAM-7746] Minor typing updates / fixes add c7c28f6 [BEAM-8487] Handle

[beam] branch master updated (60aa5d9 -> 2f10df9)

2020-02-28 Thread udim
This is an automated email from the ASF dual-hosted git repository. udim pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 60aa5d9 Merge pull request #10559 from vectorijk/calcite-vendor-jdbc-url add 7a50378 more typing fixes add

[GitHub] [beam] udim merged pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-28 Thread GitBox
udim merged pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] udim commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-28 Thread GitBox
udim commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-592762988 Thanks, Chad! merging This is an automated message from the Apache Git Service. To

[GitHub] [beam] alexvanboxel commented on issue #10413: [BEAM-9035] Typed options for Row Schema and Field

2020-02-28 Thread GitBox
alexvanboxel commented on issue #10413: [BEAM-9035] Typed options for Row Schema and Field URL: https://github.com/apache/beam/pull/10413#issuecomment-592762686 Run Python PreCommit This is an automated message from the

[GitHub] [beam] rohdesamuel opened a new pull request #11005: Streamingcache merge

2020-02-28 Thread GitBox
rohdesamuel opened a new pull request #11005: Streamingcache merge URL: https://github.com/apache/beam/pull/11005 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us

[GitHub] [beam] ananvay commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
ananvay commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592749863 Thanks, LGTM! This is an automated message from the Apache Git

[GitHub] [beam] dpmills commented on a change in pull request #11004: Adds DisplayData for StateSpecs used by stateful ParDos

2020-02-28 Thread GitBox
dpmills commented on a change in pull request #11004: Adds DisplayData for StateSpecs used by stateful ParDos URL: https://github.com/apache/beam/pull/11004#discussion_r385942978 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/coders/SerializableCoder.java

[GitHub] [beam] udim commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service

2020-02-28 Thread GitBox
udim commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service URL: https://github.com/apache/beam/pull/11001#issuecomment-592747991 run python 2 postcommit This is an automated message from the

[GitHub] [beam] angoenka commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#discussion_r385940539 ## File path: .test-infra/jenkins/job_PostCommit_Python_ValidatesRunner_Dataflow_V2.groovy

[GitHub] [beam] angoenka commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#discussion_r385940539 ## File path: .test-infra/jenkins/job_PostCommit_Python_ValidatesRunner_Dataflow_V2.groovy

[GitHub] [beam] angoenka commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#discussion_r385940430 ## File path: sdks/python/scripts/run_integration_test.sh ## @@ -232,6 +232,7 @@ if [[ -z

[GitHub] [beam] angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592746535 > Ah, sorry. Are the comments visible now? Yup This is

[GitHub] [beam] angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592745575 A Validates runner run for dataflow v2 https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2_PR/1/

[beam] branch master updated: [BEAM-8331] rewrite the calcite JDBC urls

2020-02-28 Thread lcwik
This is an automated email from the ASF dual-hosted git repository. lcwik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new b67017a [BEAM-8331] rewrite the calcite JDBC urls

[GitHub] [beam] lukecwik merged pull request #10559: [BEAM-8331] rewrite jdbc url in vendored calcite

2020-02-28 Thread GitBox
lukecwik merged pull request #10559: [BEAM-8331] rewrite jdbc url in vendored calcite URL: https://github.com/apache/beam/pull/10559 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite

2020-02-28 Thread GitBox
lukecwik commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite URL: https://github.com/apache/beam/pull/10559#issuecomment-592742689 There have been no regressions. Filed https://issues.apache.org/jira/browse/BEAM-9412

[GitHub] [beam] kennknowles commented on issue #11004: Adds DisplayData for StateSpecs used by stateful ParDos

2020-02-28 Thread GitBox
kennknowles commented on issue #11004: Adds DisplayData for StateSpecs used by stateful ParDos URL: https://github.com/apache/beam/pull/11004#issuecomment-592741636 run java precommit This is an automated message from the

[GitHub] [beam] lukecwik commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite

2020-02-28 Thread GitBox
lukecwik commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite URL: https://github.com/apache/beam/pull/10559#issuecomment-592739611 Reran just now, on master: ``` Class org.slf4j.LoggerFactory is not found; referenced by 29 class files

[GitHub] [beam] kennknowles commented on a change in pull request #11004: Adds DisplayData for StateSpecs used by stateful ParDos

2020-02-28 Thread GitBox
kennknowles commented on a change in pull request #11004: Adds DisplayData for StateSpecs used by stateful ParDos URL: https://github.com/apache/beam/pull/11004#discussion_r385930889 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/coders/SerializableCoder.java

[GitHub] [beam] kennknowles commented on a change in pull request #11004: Adds DisplayData for StateSpecs used by stateful ParDos

2020-02-28 Thread GitBox
kennknowles commented on a change in pull request #11004: Adds DisplayData for StateSpecs used by stateful ParDos URL: https://github.com/apache/beam/pull/11004#discussion_r385931847 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java ##

[GitHub] [beam] pabloem commented on issue #10958: [BEAM] Submitting final communication strategy

2020-02-28 Thread GitBox
pabloem commented on issue #10958: [BEAM] Submitting final communication strategy URL: https://github.com/apache/beam/pull/10958#issuecomment-592738216 The wiki is here: https://cwiki.apache.org/confluence/display/BEAM Wiki edits are not done via pull requests. You can create an

[GitHub] [beam] dpmills opened a new pull request #11004: Adds DisplayData for StateSpecs used by stateful ParDos

2020-02-28 Thread GitBox
dpmills opened a new pull request #11004: Adds DisplayData for StateSpecs used by stateful ParDos URL: https://github.com/apache/beam/pull/11004 Adds DisplayData for StateSpecs used by stateful ParDos. R: @kennknowles Post-Commit Tests Status (on

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592735040 Run SQL PostCommit This is an automated message from the

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592731427 Run SQL PostCommit This is an automated message from the

[GitHub] [beam] macruzbar commented on issue #10958: [BEAM] Submitting final communication strategy

2020-02-28 Thread GitBox
macruzbar commented on issue #10958: [BEAM] Submitting final communication strategy URL: https://github.com/apache/beam/pull/10958#issuecomment-592723620 > +1 for wiki ok great! Do I need to submit a new pull request?

[beam] branch master updated: [BEAM-9401] bind Flink MiniCluster to localhost

2020-02-28 Thread ibzib
This is an automated email from the ASF dual-hosted git repository. ibzib pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new 5db8660 [BEAM-9401] bind Flink MiniCluster to

[GitHub] [beam] ibzib merged pull request #10995: [BEAM-9401] bind Flink MiniCluster to localhost

2020-02-28 Thread GitBox
ibzib merged pull request #10995: [BEAM-9401] bind Flink MiniCluster to localhost URL: https://github.com/apache/beam/pull/10995 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ameihm0912 commented on issue #10973: KinesisIO retry LimitExceededException

2020-02-28 Thread GitBox
ameihm0912 commented on issue #10973: KinesisIO retry LimitExceededException URL: https://github.com/apache/beam/pull/10973#issuecomment-592720884 @aromanenko-dev interesting, that's definitely an option but as you mention I am unclear on what the implications of applying a global

[GitHub] [beam] kennknowles commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite

2020-02-28 Thread GitBox
kennknowles commented on issue #10559: [BEAM-8331] rewrite jdbc url in vendored calcite URL: https://github.com/apache/beam/pull/10559#issuecomment-592716351 Are the linkage errors a regression? If not, this PR is helpful and they can be separate efforts.

[GitHub] [beam] chadrik commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service

2020-02-28 Thread GitBox
chadrik commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service URL: https://github.com/apache/beam/pull/11001#issuecomment-592712994 R: @robertwb R: @udim This is an automated message from

[GitHub] [beam] amaliujia commented on issue #10940: [BEAM-9288] Not bundle conscrypt in gRPC vendor

2020-02-28 Thread GitBox
amaliujia commented on issue #10940: [BEAM-9288] Not bundle conscrypt in gRPC vendor URL: https://github.com/apache/beam/pull/10940#issuecomment-592709535 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592696080 Run Python Dataflow V2 ValidatesRunner This is an automated

[GitHub] [beam] rohdesamuel commented on issue #10994: [BEAM-8335] TeststreamService integration with DirectRunner

2020-02-28 Thread GitBox
rohdesamuel commented on issue #10994: [BEAM-8335] TeststreamService integration with DirectRunner URL: https://github.com/apache/beam/pull/10994#issuecomment-592695120 This was rebased onto the cherry-pick of PR/10497 (ReverseTestStream implementation)

[GitHub] [beam] ananvay commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
ananvay commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#discussion_r385488768 ## File path: sdks/python/scripts/run_integration_test.sh ## @@ -232,6 +232,7 @@ if [[ -z

[GitHub] [beam] ananvay commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
ananvay commented on a change in pull request #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#discussion_r385488485 ## File path: .test-infra/jenkins/job_PostCommit_Python_ValidatesRunner_Dataflow_V2.groovy

[GitHub] [beam] ananvay commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
ananvay commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592695151 Ah, sorry. Are the comments visible now? This is an automated

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592693089 Run SQL PostCommit This is an automated message from the

[GitHub] [beam] udim commented on issue #10932: [BEAM-8487] Handle nested forward references

2020-02-28 Thread GitBox
udim commented on issue #10932: [BEAM-8487] Handle nested forward references URL: https://github.com/apache/beam/pull/10932#issuecomment-592692169 Run Python PreCommit This is an automated message from the Apache Git Service.

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592692026 Run SQL PostCommit This is an automated message from the

[GitHub] [beam] lukecwik commented on issue #10940: [BEAM-9288] Not bundle conscrypt in gRPC vendor

2020-02-28 Thread GitBox
lukecwik commented on issue #10940: [BEAM-9288] Not bundle conscrypt in gRPC vendor URL: https://github.com/apache/beam/pull/10940#issuecomment-592691649 Run Python PreCommit This is an automated message from the Apache Git

[GitHub] [beam] angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592691460 > Thanks a lot Ankur!! > > Overall LGTM, a few minor comments to track the changes made here. Perhaps we should have a

[GitHub] [beam] angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2

2020-02-28 Thread GitBox
angoenka commented on issue #10998: [BEAM-9287] Add Postcommit tests for dataflow runner v2 URL: https://github.com/apache/beam/pull/10998#issuecomment-592691050 Run Seed Job This is an automated message from the Apache Git

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592681527 Run SQL PostCommit This is an automated message from the

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592681235 Run SQL PostCommit This is an automated message from the

[beam] 01/01: Create release branch for version 2.20.0.

2020-02-28 Thread amaliujia
This is an automated email from the ASF dual-hosted git repository. amaliujia pushed a commit to branch release-2.20.0 in repository https://gitbox.apache.org/repos/asf/beam.git commit 794ac6ca0b0742417f26cb63b6429a86fd5ea99d Author: amaliujia AuthorDate: Fri Feb 28 11:07:41 2020 -0800

[beam] branch release-2.20.0 created (now 794ac6c)

2020-02-28 Thread amaliujia
This is an automated email from the ASF dual-hosted git repository. amaliujia pushed a change to branch release-2.20.0 in repository https://gitbox.apache.org/repos/asf/beam.git. at 794ac6c Create release branch for version 2.20.0. This branch includes the following new commits:

[beam] branch master updated: Moving to 2.21.0-SNAPSHOT on master branch.

2020-02-28 Thread amaliujia
This is an automated email from the ASF dual-hosted git repository. amaliujia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new f30ba11 Moving to 2.21.0-SNAPSHOT on master

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-28 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-592678321 @udim All tests passing now This is an automated message from the Apache Git

[GitHub] [beam] chadrik commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service

2020-02-28 Thread GitBox
chadrik commented on issue #11001: [BEAM-9405] Fix post-commit error about create_job_service URL: https://github.com/apache/beam/pull/11001#issuecomment-592677927 R: @kamilwu This is an automated message from the Apache

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592674707 Yes, both paths have test coverage. Will merge as soon as I figure out the timing issues in the read test. (Test data isn't

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592673405 Run SQL PostCommit This is an automated message from the

[GitHub] [beam] chamikaramj commented on a change in pull request #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-28 Thread GitBox
chamikaramj commented on a change in pull request #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#discussion_r385856505 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1361,87

[GitHub] [beam] chunyang commented on a change in pull request #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-28 Thread GitBox
chunyang commented on a change in pull request #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#discussion_r385854644 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1361,87 +1369,18

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592661992 Run SQL PostCommit This is an automated message from the

[GitHub] [beam] pabloem commented on a change in pull request #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-28 Thread GitBox
pabloem commented on a change in pull request #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#discussion_r385842690 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1361,87 +1369,18

[GitHub] [beam] pulasthi edited a comment on issue #10888: [BEAM-7304] Twister2 Beam runner

2020-02-28 Thread GitBox
pulasthi edited a comment on issue #10888: [BEAM-7304] Twister2 Beam runner URL: https://github.com/apache/beam/pull/10888#issuecomment-592599267 @iemejia the java pre-commit still seems to be failing but because of other reasons. And would it be better to rebase the pull request into a

[GitHub] [beam] amaliujia commented on issue #10982: [BEAM-9392] Fix Multi TestStream assertion errors

2020-02-28 Thread GitBox
amaliujia commented on issue #10982: [BEAM-9392] Fix Multi TestStream assertion errors URL: https://github.com/apache/beam/pull/10982#issuecomment-592650626 Thank you all! This is an automated message from the Apache Git

[GitHub] [beam] apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud commented on issue #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003#issuecomment-592647170 Run SQL PostCommit This is an automated message from the

[GitHub] [beam] apilloud opened a new pull request #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL

2020-02-28 Thread GitBox
apilloud opened a new pull request #11003: [BEAM-9411] Enable BigQuery DIRECT_READ by default in SQL URL: https://github.com/apache/beam/pull/11003 This is avalable globally now and we keep getting customer issues caused by it not being enabled. Lets turn it on by default!

[GitHub] [beam] apilloud closed pull request #11002: [BEAM-9411] Enable BigQuery DIRECT_READ by default for SQL

2020-02-28 Thread GitBox
apilloud closed pull request #11002: [BEAM-9411] Enable BigQuery DIRECT_READ by default for SQL URL: https://github.com/apache/beam/pull/11002 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] apilloud opened a new pull request #11002: [BEAM-9411] Enable BigQuery DIRECT_READ by default for SQL

2020-02-28 Thread GitBox
apilloud opened a new pull request #11002: [BEAM-9411] Enable BigQuery DIRECT_READ by default for SQL URL: https://github.com/apache/beam/pull/11002 This is avalable globally now and we keep getting customer issues caused by it not being enabled. Lets turn it on by default!

[beam] branch direct created (now 578bc11)

2020-02-28 Thread apilloud
This is an automated email from the ASF dual-hosted git repository. apilloud pushed a change to branch direct in repository https://gitbox.apache.org/repos/asf/beam.git. at 578bc11 [BEAM-9411] Enable BigQuery DIRECT_READ by default This branch includes the following new commits:

[beam] 01/01: [BEAM-9411] Enable BigQuery DIRECT_READ by default

2020-02-28 Thread apilloud
This is an automated email from the ASF dual-hosted git repository. apilloud pushed a commit to branch direct in repository https://gitbox.apache.org/repos/asf/beam.git commit 578bc110e1c0976ae040f7818af0182e6fe26363 Author: Andrew Pilloud AuthorDate: Fri Feb 28 09:06:53 2020 -0800

  1   2   >