[GitHub] [beam] echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#issuecomment-601050524 @lgajowy @mwalenia thanks again for the great performance framework you made ! It is complementary to Nexmark. Indeed nexmark

[GitHub] [beam] iemejia commented on a change in pull request #10815: [BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery

2020-03-19 Thread GitBox
iemejia commented on a change in pull request #10815: [BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery URL: https://github.com/apache/beam/pull/10815#discussion_r394859324 ## File path:

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-19 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-601048332 run seed job This is an automated message from the

[GitHub] [beam] iemejia commented on a change in pull request #10815: [BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery

2020-03-19 Thread GitBox
iemejia commented on a change in pull request #10815: [BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery URL: https://github.com/apache/beam/pull/10815#discussion_r394846218 ## File path: sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java

[GitHub] [beam] iemejia commented on a change in pull request #10815: [BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery

2020-03-19 Thread GitBox
iemejia commented on a change in pull request #10815: [BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery URL: https://github.com/apache/beam/pull/10815#discussion_r394846361 ## File path: sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java

[GitHub] [beam] alexvanboxel merged pull request #10413: [BEAM-9035] Typed options for Row Schema and Field

2020-03-19 Thread GitBox
alexvanboxel merged pull request #10413: [BEAM-9035] Typed options for Row Schema and Field URL: https://github.com/apache/beam/pull/10413 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] alexvanboxel commented on issue #10413: [BEAM-9035] Typed options for Row Schema and Field

2020-03-19 Thread GitBox
alexvanboxel commented on issue #10413: [BEAM-9035] Typed options for Row Schema and Field URL: https://github.com/apache/beam/pull/10413#issuecomment-601039811 > @alexvanboxel I'm still not 100% sure that I agree that options are not schemas, and I don't love making SchemaVerification

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-19 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-601024107 Run Java PreCommit This is an automated message

[GitHub] [beam] pawelpasterz closed pull request #11076: Run precommit portability on java 11

2020-03-19 Thread GitBox
pawelpasterz closed pull request #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] pawelpasterz commented on a change in pull request #11076: Run precommit portability on java 11

2020-03-19 Thread GitBox
pawelpasterz commented on a change in pull request #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076#discussion_r394822688 ## File path: sdks/java/testing/test-utils/build.gradle ## @@ -39,3 +39,14 @@ dependencies { testCompile

[GitHub] [beam] alexvanboxel merged pull request #11159: BEAM-8924 - Update Apache Tika to 1.24

2020-03-19 Thread GitBox
alexvanboxel merged pull request #11159: BEAM-8924 - Update Apache Tika to 1.24 URL: https://github.com/apache/beam/pull/11159 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pabloem merged pull request #11158: [BEAM-9533] Fixing tox.ini variants

2020-03-18 Thread GitBox
pabloem merged pull request #11158: [BEAM-9533] Fixing tox.ini variants URL: https://github.com/apache/beam/pull/11158 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] reuvenlax commented on issue #11074: Store logical type values in Row instead of base values

2020-03-18 Thread GitBox
reuvenlax commented on issue #11074: Store logical type values in Row instead of base values URL: https://github.com/apache/beam/pull/11074#issuecomment-600982415 @alexvanboxel @kanterov any more comments? @alexvanboxel this will conflict badly with your PR I think (as you moved

[GitHub] [beam] youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-18 Thread GitBox
youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394783430 ## File path: sdks/go/pkg/beam/core/graph/fn.go ## @@ -569,6 +622,188 @@ func

[GitHub] [beam] youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-18 Thread GitBox
youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394783450 ## File path: sdks/go/pkg/beam/core/graph/fn.go ## @@ -569,6 +622,188 @@ func

[GitHub] [beam] youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-18 Thread GitBox
youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394783477 ## File path: sdks/go/pkg/beam/core/graph/fn_test.go ## @@ -470,6 +542,169 @@ func

[GitHub] [beam] youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-18 Thread GitBox
youngoli commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394783417 ## File path: sdks/go/pkg/beam/core/graph/fn.go ## @@ -196,13 +217,31 @@ func (f

[GitHub] [beam] amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-03-18 Thread GitBox
amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch URL: https://github.com/apache/beam/pull/11081#issuecomment-600976910 Run Release Gradle Build This is an

[GitHub] [beam] pabloem commented on issue #11158: [BEAM-9533] Fixing tox.ini variants

2020-03-18 Thread GitBox
pabloem commented on issue #11158: [BEAM-9533] Fixing tox.ini variants URL: https://github.com/apache/beam/pull/11158#issuecomment-600976187 Run Portable_Python PreCommit This is an automated message from the Apache Git

[GitHub] [beam] jfarr commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-18 Thread GitBox
jfarr commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#issuecomment-600950516 > I think it's almost LGTM, just requires some Javadoc updates on using rate limiter in multiple threads. Thanks @aromanenko-dev,

[GitHub] [beam] suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r394739760 ## File path: sdks/java/io/google-cloud-platform/build.gradle ## @@ -75,6 +75,7 @@

[GitHub] [beam] suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r394739168 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

[GitHub] [beam] suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r394739488 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

[GitHub] [beam] suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
suztomo commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r394739600 ## File path: sdks/java/core/build.gradle ## @@ -87,6 +87,7 @@ dependencies {

[GitHub] [beam] ibzib opened a new pull request #11170: [BEAM-9553] Use latest Flink job server image as default.

2020-03-18 Thread GitBox
ibzib opened a new pull request #11170: [BEAM-9553] Use latest Flink job server image as default. URL: https://github.com/apache/beam/pull/11170 cc @lukecwik Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#issuecomment-600933872 Run SQL Postcommit This is an automated message from

[GitHub] [beam] aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#issuecomment-600933820 Run Spark ValidatesRunner This is an automated message

[GitHub] [beam] aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#issuecomment-600933769 Run Dataflow ValidatesRunner This is an automated

[GitHub] [beam] suztomo commented on issue #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies

2020-03-18 Thread GitBox
suztomo commented on issue #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies URL: https://github.com/apache/beam/pull/11156#issuecomment-600933706 @aaltay Thank you. This is an automated message from

[GitHub] [beam] aaltay commented on issue #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies

2020-03-18 Thread GitBox
aaltay commented on issue #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies URL: https://github.com/apache/beam/pull/11156#issuecomment-600933591 Run Python PreCommit This is an automated message from

[GitHub] [beam] aaltay commented on issue #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies

2020-03-18 Thread GitBox
aaltay commented on issue #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies URL: https://github.com/apache/beam/pull/11156#issuecomment-600933550 Run Java PreCommit This is an automated message from the

[GitHub] [beam] aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#issuecomment-600933744 Run BigQueryIO Streaming Performance Test Java This is

[GitHub] [beam] aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#issuecomment-600933708 Run Java HadoopFormatIO Performance Test This is an

[GitHub] [beam] aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
aaltay commented on issue #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#issuecomment-600933671 Run Java PostCommit This is an automated message from

[GitHub] [beam] lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-18 Thread GitBox
lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394728377 ## File path: sdks/go/pkg/beam/core/graph/fn_test.go ## @@ -470,6 +542,169 @@ func

[GitHub] [beam] lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-18 Thread GitBox
lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394618692 ## File path: sdks/go/pkg/beam/core/graph/fn.go ## @@ -196,13 +217,31 @@ func (f

[GitHub] [beam] lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-18 Thread GitBox
lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394725254 ## File path: sdks/go/pkg/beam/core/graph/fn.go ## @@ -569,6 +622,188 @@ func

[GitHub] [beam] lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-18 Thread GitBox
lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394722487 ## File path: sdks/go/pkg/beam/core/graph/fn.go ## @@ -569,6 +622,188 @@ func

[GitHub] [beam] suztomo commented on a change in pull request #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies

2020-03-18 Thread GitBox
suztomo commented on a change in pull request #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies URL: https://github.com/apache/beam/pull/11156#discussion_r394727429 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

[GitHub] [beam] aaltay commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-18 Thread GitBox
aaltay commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-600928606 retest this please This is an automated message from the

[GitHub] [beam] TheNeuralBit opened a new pull request #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-18 Thread GitBox
TheNeuralBit opened a new pull request #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169 Post-Commit Tests Status (on master branch)

[GitHub] [beam] ihji commented on issue #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-03-18 Thread GitBox
ihji commented on issue #11039: [BEAM-9383] Staging Dataflow artifacts from environment URL: https://github.com/apache/beam/pull/11039#issuecomment-600925930 @chamikaramj PTAL and rerun the tests. This is an automated

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-03-18 Thread GitBox
ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment URL: https://github.com/apache/beam/pull/11039#discussion_r394722832 ## File path:

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-03-18 Thread GitBox
ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment URL: https://github.com/apache/beam/pull/11039#discussion_r394721868 ## File path:

[GitHub] [beam] lostluck commented on issue #11164: [BEAM-9551] Environment PB Pointer cleanup

2020-03-18 Thread GitBox
lostluck commented on issue #11164: [BEAM-9551] Environment PB Pointer cleanup URL: https://github.com/apache/beam/pull/11164#issuecomment-600924609 R: @youngoli This is an automated message from the Apache Git Service. To

[GitHub] [beam] suztomo opened a new pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-18 Thread GitBox
suztomo opened a new pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168 Before: forcing all dependencies for all class paths After: forcing only 4 dependencies needed for tests.

[GitHub] [beam] lukecwik commented on a change in pull request #11160: [BEAM-9339] Declare capabilities in the Java SDK.

2020-03-18 Thread GitBox
lukecwik commented on a change in pull request #11160: [BEAM-9339] Declare capabilities in the Java SDK. URL: https://github.com/apache/beam/pull/11160#discussion_r394720559 ## File path:

[GitHub] [beam] lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-18 Thread GitBox
lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157#issuecomment-600921437 Run Portable_Python PreCommit

[GitHub] [beam] lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-18 Thread GitBox
lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#issuecomment-600919341 R: @robertwb This is an automated message from

[GitHub] [beam] lukecwik opened a new pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-18 Thread GitBox
lukecwik opened a new pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167 Typical flow: Runner requests metrics and SDK responds with metrics data and ids, SDK stores id -> full MonitoringInfo mapping.

[GitHub] [beam] lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-18 Thread GitBox
lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#issuecomment-600917167 Run Portable_Python PreCommit

[GitHub] [beam] KevinGG edited a comment on issue #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-18 Thread GitBox
KevinGG edited a comment on issue #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#issuecomment-600914076 Per discussion offline, we've decided to emit some logging for options APIs. yapf formatted. lint passed

[GitHub] [beam] KevinGG commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-18 Thread GitBox
KevinGG commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#issuecomment-600914076 Per discussion offline, we've decided to emit some logging for options APIs. yapf formatted. lint passed

[GitHub] [beam] KevinGG opened a new pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-18 Thread GitBox
KevinGG opened a new pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166 1. Info logging to notify users about invoking evict_captured_data on changing capture_duration, capture_size_limit, and

[GitHub] [beam] lukecwik commented on issue #11160: [BEAM-9339] Declare capabilities in the Java SDK.

2020-03-18 Thread GitBox
lukecwik commented on issue #11160: [BEAM-9339] Declare capabilities in the Java SDK. URL: https://github.com/apache/beam/pull/11160#issuecomment-600910480 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-18 Thread GitBox
lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#issuecomment-600910385 Run Portable_Python PreCommit

[GitHub] [beam] lostluck commented on issue #11164: [BEAM-9551] Environment PB Pointer cleanup

2020-03-18 Thread GitBox
lostluck commented on issue #11164: [BEAM-9551] Environment PB Pointer cleanup URL: https://github.com/apache/beam/pull/11164#issuecomment-600909382 Run Go Postcommit This is an automated message from the Apache Git Service.

[GitHub] [beam] robertwb opened a new pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-18 Thread GitBox
robertwb opened a new pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] apilloud merged pull request #11133: [BEAM-9511][BEAM-9515][BEAM-9516] Uncollect takes arbitrary expressions

2020-03-18 Thread GitBox
apilloud merged pull request #11133: [BEAM-9511][BEAM-9515][BEAM-9516] Uncollect takes arbitrary expressions URL: https://github.com/apache/beam/pull/11133 This is an automated message from the Apache Git Service. To

[GitHub] [beam] lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-18 Thread GitBox
lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#issuecomment-600901398 Run Portable_Python PreCommit

[GitHub] [beam] lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-18 Thread GitBox
lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157#issuecomment-600901181 Run Portable_Python PreCommit

[GitHub] [beam] lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-18 Thread GitBox
lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157#issuecomment-600901119 Run Java PreCommit

[GitHub] [beam] lostluck opened a new pull request #11164: [BEAM-9551] Environment PB Pointer cleanup

2020-03-18 Thread GitBox
lostluck opened a new pull request #11164: [BEAM-9551] Environment PB Pointer cleanup URL: https://github.com/apache/beam/pull/11164 Go Protocol buffers strongly prefer to be pointers, and could cause issues otherwise WRT copying the proto's non-exposed state incorrectly. Likely hasn't

[GitHub] [beam] pabloem commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-18 Thread GitBox
pabloem commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r394668514 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -0,0

[GitHub] [beam] pabloem commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-18 Thread GitBox
pabloem commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r394632407 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -0,0

[GitHub] [beam] pabloem commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-18 Thread GitBox
pabloem commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r394631597 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -0,0

[GitHub] [beam] robertwb commented on issue #11150: [BEAM-9535] Remove unused ParDoPayload.Parameters.

2020-03-18 Thread GitBox
robertwb commented on issue #11150: [BEAM-9535] Remove unused ParDoPayload.Parameters. URL: https://github.com/apache/beam/pull/11150#issuecomment-600895150 Run Portable_Python PreCommit This is an automated message from the

[GitHub] [beam] robertwb commented on a change in pull request #11160: [BEAM-9339] Declare capabilities in the Java SDK.

2020-03-18 Thread GitBox
robertwb commented on a change in pull request #11160: [BEAM-9339] Declare capabilities in the Java SDK. URL: https://github.com/apache/beam/pull/11160#discussion_r394679580 ## File path:

[GitHub] [beam] robertwb commented on a change in pull request #11160: [BEAM-9339] Declare capabilities in the Java SDK.

2020-03-18 Thread GitBox
robertwb commented on a change in pull request #11160: [BEAM-9339] Declare capabilities in the Java SDK. URL: https://github.com/apache/beam/pull/11160#discussion_r394679769 ## File path:

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-18 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-600890728 @lastomato Thoughts on how we could rework the HCAPI client to get around this failing CI Check?

[GitHub] [beam] apilloud merged pull request #11132: [BEAM-9513][BEAM-9521] Translate ZetaSQL joins without condition

2020-03-18 Thread GitBox
apilloud merged pull request #11132: [BEAM-9513][BEAM-9521] Translate ZetaSQL joins without condition URL: https://github.com/apache/beam/pull/11132 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] pabloem commented on issue #11158: [BEAM-9533] Fixing tox.ini variants

2020-03-18 Thread GitBox
pabloem commented on issue #11158: [BEAM-9533] Fixing tox.ini variants URL: https://github.com/apache/beam/pull/11158#issuecomment-600888942 Run Python PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] apilloud commented on issue #11133: [BEAM-9511][BEAM-9515][BEAM-9516] Uncollect takes arbitrary expressions

2020-03-18 Thread GitBox
apilloud commented on issue #11133: [BEAM-9511][BEAM-9515][BEAM-9516] Uncollect takes arbitrary expressions URL: https://github.com/apache/beam/pull/11133#issuecomment-600887799 Added tests. This is an automated message from

[GitHub] [beam] lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-18 Thread GitBox
lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157#issuecomment-600879819 Run Portable_Python PreCommit

[GitHub] [beam] lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-18 Thread GitBox
lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157#issuecomment-600879773 Run Java PreCommit

[GitHub] [beam] lukecwik commented on issue #11150: [BEAM-9535] Remove unused ParDoPayload.Parameters.

2020-03-18 Thread GitBox
lukecwik commented on issue #11150: [BEAM-9535] Remove unused ParDoPayload.Parameters. URL: https://github.com/apache/beam/pull/11150#issuecomment-600879449 Run Python2_PVR_Flink PreCommit This is an automated message from

[GitHub] [beam] davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-18 Thread GitBox
davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#discussion_r394662812 ## File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py ## @@

[GitHub] [beam] lukecwik commented on issue #11150: [BEAM-9535] Remove unused ParDoPayload.Parameters.

2020-03-18 Thread GitBox
lukecwik commented on issue #11150: [BEAM-9535] Remove unused ParDoPayload.Parameters. URL: https://github.com/apache/beam/pull/11150#issuecomment-600879517 Run Portable_Python PreCommit This is an automated message from the

[GitHub] [beam] amaliujia merged pull request #11152: [BEAM-9536] Specify return types of window start/end functions explicitly

2020-03-18 Thread GitBox
amaliujia merged pull request #11152: [BEAM-9536] Specify return types of window start/end functions explicitly URL: https://github.com/apache/beam/pull/11152 This is an automated message from the Apache Git Service. To

[GitHub] [beam] aaltay merged pull request #11161: [BEAM-7923] Change Transform Label Prefix Syntax

2020-03-18 Thread GitBox
aaltay merged pull request #11161: [BEAM-7923] Change Transform Label Prefix Syntax URL: https://github.com/apache/beam/pull/11161 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rohdesamuel commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-18 Thread GitBox
rohdesamuel commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#discussion_r394655524 ## File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py ## @@

[GitHub] [beam] pabloem commented on issue #11158: [BEAM-9533] Fixing tox.ini variants

2020-03-18 Thread GitBox
pabloem commented on issue #11158: [BEAM-9533] Fixing tox.ini variants URL: https://github.com/apache/beam/pull/11158#issuecomment-600872144 Run Python PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] suztomo commented on issue #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies

2020-03-18 Thread GitBox
suztomo commented on issue #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies URL: https://github.com/apache/beam/pull/11156#issuecomment-600868999 ## Java Precommit failed

[GitHub] [beam] pabloem commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-18 Thread GitBox
pabloem commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#discussion_r394648905 ## File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py ## @@

[GitHub] [beam] pabloem commented on issue #11153: [BEAM-9537] Adding a new module for FnApiRunner

2020-03-18 Thread GitBox
pabloem commented on issue #11153: [BEAM-9537] Adding a new module for FnApiRunner URL: https://github.com/apache/beam/pull/11153#issuecomment-600865229 I've started rebasing https://github.com/apache/beam/pull/10291 to keep it up to date. Since the module refactoring is likely to make

[GitHub] [beam] reuvenlax commented on issue #10413: [BEAM-9035] Typed options for Row Schema and Field

2020-03-18 Thread GitBox
reuvenlax commented on issue #10413: [BEAM-9035] Typed options for Row Schema and Field URL: https://github.com/apache/beam/pull/10413#issuecomment-600864690 @alexvanboxel I'm still not 100% sure that I agree that options are not schemas, and I don't love making SchemaVerification public.

[GitHub] [beam] amaliujia commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-18 Thread GitBox
amaliujia commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157#issuecomment-600864297 LGTM

[GitHub] [beam] pabloem commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-18 Thread GitBox
pabloem commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#discussion_r394495708 ## File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py ## @@

[GitHub] [beam] rohdesamuel opened a new pull request #11163: Add better error handling to the TestStreamServiceController

2020-03-18 Thread GitBox
rohdesamuel opened a new pull request #11163: Add better error handling to the TestStreamServiceController URL: https://github.com/apache/beam/pull/11163 Change-Id: I022f25840207eb6c931c97358f159f134393c180 **Please** add a meaningful description for your change here

[GitHub] [beam] aaltay commented on issue #11161: [BEAM-7923] Change Transform Label Prefix Syntax

2020-03-18 Thread GitBox
aaltay commented on issue #11161: [BEAM-7923] Change Transform Label Prefix Syntax URL: https://github.com/apache/beam/pull/11161#issuecomment-600855753 Run Portable_Python PreCommit This is an automated message from the

[GitHub] [beam] amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-03-18 Thread GitBox
amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch URL: https://github.com/apache/beam/pull/11081#issuecomment-600854236 Run Release Gradle Build This is an

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-18 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r394610410 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-18 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r394620115 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-18 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r394598085 ## File path: sdks/python/apache_beam/dataframe/transforms_test.py ## @@ -0,0 +1,87 @@ +# +# Licensed to the

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-18 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r394602286 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-18 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r394630321 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache

[GitHub] [beam] lukecwik commented on issue #11160: [BEAM-9339] Declare capabilities in the Java SDK.

2020-03-18 Thread GitBox
lukecwik commented on issue #11160: [BEAM-9339] Declare capabilities in the Java SDK. URL: https://github.com/apache/beam/pull/11160#issuecomment-600847451 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-18 Thread GitBox
lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157#issuecomment-600840712 Run Java PreCommit

[GitHub] [beam] lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-18 Thread GitBox
lukecwik commented on issue #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157#issuecomment-600840756 Run Portable_Python PreCommit

[GitHub] [beam] davidcavazos commented on issue #10165: [BEAM-7390] Add code snippet for GroupIntoBatches

2020-03-18 Thread GitBox
davidcavazos commented on issue #10165: [BEAM-7390] Add code snippet for GroupIntoBatches URL: https://github.com/apache/beam/pull/10165#issuecomment-600835633 I will get rid of `BatchElements` and keep `GroupIntoBatches`. I will also update the sample to use keys as well.

<    3   4   5   6   7   8   9   10   11   12   >