[GitHub] [calcite] zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION URL: https://github.com/apache/calcite/pull/1011#discussion_r264088987 ## File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java ## @@

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION URL: https://github.com/apache/calcite/pull/1011#discussion_r264089171 ## File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java ## @@

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION URL: https://github.com/apache/calcite/pull/1011#discussion_r264088987 ## File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java ## @@

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION URL: https://github.com/apache/calcite/pull/1011#discussion_r264088987 ## File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java ## @@

[GitHub] [calcite] asereda-gs merged pull request #1095: [CALCITE-2599] add the ASCII function

asereda-gs merged pull request #1095: [CALCITE-2599] add the ASCII function URL: https://github.com/apache/calcite/pull/1095 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] asereda-gs commented on issue #1095: [CALCITE-2599] add the ASCII function

asereda-gs commented on issue #1095: [CALCITE-2599] add the ASCII function URL: https://github.com/apache/calcite/pull/1095#issuecomment-471386887 Thank you! This is an automated message from the Apache Git Service. To

[calcite] branch master updated: [CALCITE-2599] Implement SQL ASCII function (Chunwei Lei)

This is an automated email from the ASF dual-hosted git repository. sereda pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new a481357 [CALCITE-2599] Implement SQL ASCII

[GitHub] [calcite] chunweilei commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

chunweilei commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-471385527 Some comment can be found in https://issues.apache.org/jira/browse/CALCITE-2658.

[GitHub] [calcite] chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921#issuecomment-471385489 Some comment can be found in https://issues.apache.org/jira/browse/CALCITE-2658

[GitHub] [calcite] chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921#issuecomment-471384970 Hi, @risdenk @asereda-gs , Any comment about this PR?

[GitHub] [calcite] chunweilei commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

chunweilei commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-471384874 Hi, @risdenk @asereda-gs @julianhyde, Any comment about this PR?

[GitHub] [calcite] asereda-gs commented on a change in pull request #1097: [CALCITE-2902] Improve performance of AbstractRelNode#computeDigest

asereda-gs commented on a change in pull request #1097: [CALCITE-2902] Improve performance of AbstractRelNode#computeDigest URL: https://github.com/apache/calcite/pull/1097#discussion_r264068526 ## File path: core/src/main/java/org/apache/calcite/rel/AbstractRelNode.java

[calcite] branch master updated: [CALCITE-2677] Struct types with one field are not mapped correctly to Java Classes

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new bfc842a [CALCITE-2677] Struct types with one

[GitHub] [calcite] zabetak merged pull request #923: [CALCITE-2677] Struct types with one field are not mapped correctly to Java Classes (Stamatis Zampetakis)

zabetak merged pull request #923: [CALCITE-2677] Struct types with one field are not mapped correctly to Java Classes (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/923 This is an automated message from

[GitHub] [calcite] zabetak commented on a change in pull request #1097: [CALCITE-2902] Improve performance of AbstractRelNode#computeDigest

zabetak commented on a change in pull request #1097: [CALCITE-2902] Improve performance of AbstractRelNode#computeDigest URL: https://github.com/apache/calcite/pull/1097#discussion_r264065951 ## File path: core/src/main/java/org/apache/calcite/rel/AbstractRelNode.java ##

[GitHub] [calcite] walterddr commented on issue #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

walterddr commented on issue #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION URL: https://github.com/apache/calcite/pull/1011#issuecomment-471366200 #958 has been merged. thus I updated the `RowExpressionExtension` based on SimpleIdentifier approach. Please kindly take a

[GitHub] [calcite] asereda-gs commented on a change in pull request #1095: [CALCITE-2599] add the ASCII function

asereda-gs commented on a change in pull request #1095: [CALCITE-2599] add the ASCII function URL: https://github.com/apache/calcite/pull/1095#discussion_r264046635 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -237,6 +238,12 @@

[GitHub] [calcite] asereda-gs commented on issue #1095: [CALCITE-2599] add the ASCII function

asereda-gs commented on issue #1095: [CALCITE-2599] add the ASCII function URL: https://github.com/apache/calcite/pull/1095#issuecomment-471320186 Can you please change commit message to `Implement SQL ASCII function` (original `add the ASCII function` doesn't sound right) ? Also