[GitHub] [calcite] jcamachor opened a new pull request #1144: [CALCITE-2976] Improve materialized view rewriting coverage with disj…

2019-04-02 Thread GitBox
jcamachor opened a new pull request #1144: [CALCITE-2976] Improve materialized view rewriting coverage with disj… URL: https://github.com/apache/calcite/pull/1144 …unctive predicates This is an automated message from the

[GitHub] [calcite] XuMingmin commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream

2019-04-02 Thread GitBox
XuMingmin commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream URL: https://github.com/apache/calcite/pull/1127#issuecomment-479326310 There're some test cases in `KafkaAdapterTest` with `org.apache.kafka.clients.consumer.MockConsumer`. Is that what you refers to?

[calcite] branch master updated: [CALCITE-2892] Add the JSON_KEYS function (xuqianjin)

2019-04-02 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 80dc5bc [CALCITE-2892] Add the JSON_KEYS

[GitHub] [calcite] zhztheplayer closed pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer closed pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior URL: https://github.com/apache/calcite/pull/1107#discussion_r271558302 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ##

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271553975 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite] zinking commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream

2019-04-02 Thread GitBox
zinking commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream URL: https://github.com/apache/calcite/pull/1127#issuecomment-479274973 I was hoping to see some sql test in this new adapter though, could that be mocked?

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271543754 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271543304 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite] zabetak commented on issue #1072: [CALCITE-2879] Improve filter condition in Join

2019-04-02 Thread GitBox
zabetak commented on issue #1072: [CALCITE-2879] Improve filter condition in Join URL: https://github.com/apache/calcite/pull/1072#issuecomment-479227785 Hi @yuqi1129, thanks for the PR. However, it seems there is already a way to do what you are proposing here. Can you please clarify and

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271511373 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@ -2623,6

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271510539 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableRel.java

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271510854 ## File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java ## @@

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271511665 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271498915 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-479206930 @zabetak , I have addressed the comments > > I need something like

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271498915 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271498570 ## File path:

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271485479 ## File path:

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271485206 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@

[GitHub] [calcite-avatica] risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#issuecomment-479187791 I created https://github.com/apache/calcite-avatica/pull/93 for the suppression route.

[GitHub] [calcite-avatica] risdenk opened a new pull request #93: [CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk opened a new pull request #93: [CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/93 Upgrade jetty to 9.4.15.v20190215 and add suppressions for deprecations associated with the upgrade.

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271475823 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271475849 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#issuecomment-479178185 Since the existing implementation will work (not removed from Jetty yet just deprecated), I am thinking to just suppress the

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271473370 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271474411 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271473791 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271474119 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#issuecomment-479174728 So I'm definitely getting by butt kicked on this. I am going to push my changes that are definitely broken.

[GitHub] [calcite] hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-02 Thread GitBox
hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271460739 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-02 Thread GitBox
hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271460662 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] zabetak closed pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada Lopez)

2019-04-02 Thread GitBox
zabetak closed pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1112

[calcite] branch master updated: [CALCITE-2930] IllegalStateException when FilterCorrelateRule matches a SEMI or ANTI Correlate (Ruben Quesada Lopez)

2019-04-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 43ba147 [CALCITE-2930] IllegalStateException

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271402416 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1143: [CALCITE-2884] Add the JSON_INSERT, JSON_REPLACE, JSON_SET function

2019-04-02 Thread GitBox
XuQianJin-Stars opened a new pull request #1143: [CALCITE-2884] Add the JSON_INSERT,JSON_REPLACE,JSON_SET function URL: https://github.com/apache/calcite/pull/1143 `JSON_INSERT`(jsondoc, path, val[, path, val] ) `JSON_REPLACE`(jsondoc, _path_, _val_[, path, val] )

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271382782 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -876,6 +876,9

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271382782 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -876,6 +876,9

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271382782 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -876,6 +876,9

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271378333 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite] hsyuan edited a comment on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-04-02 Thread GitBox
hsyuan edited a comment on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-479063273 Closing this PR, since it has been resolved in commit:

[GitHub] [calcite] hsyuan commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-04-02 Thread GitBox
hsyuan commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-479063273 Closing this PR, since it has been resolved in commit:

[GitHub] [calcite] hsyuan closed pull request #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-04-02 Thread GitBox
hsyuan closed pull request #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126 This is an automated message from the Apache Git

[calcite] branch master updated: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-04-02 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new e043640 [CALCITE-2004] Push join predicate

[GitHub] [calcite] hsyuan merged pull request #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-04-02 Thread GitBox
hsyuan merged pull request #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join URL: https://github.com/apache/calcite/pull/1096 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] danny0405 commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-04-02 Thread GitBox
danny0405 commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-478992669 @LaiZhou This problem is fixed in CALCITE-2928

[GitHub] [calcite] chunweilei commented on issue #1142: [CALCITE-2754] Implement LISTAGG function (Sergey Nuyanzin, Chunwei Lei)

2019-04-02 Thread GitBox
chunweilei commented on issue #1142: [CALCITE-2754] Implement LISTAGG function (Sergey Nuyanzin, Chunwei Lei) URL: https://github.com/apache/calcite/pull/1142#issuecomment-478864452 Since [PR#981](https://github.com/apache/calcite/pull/981) is not updated since Dec, I open this pull