[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

2019-04-18 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276896982 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] chunweilei edited a comment on issue #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
chunweilei edited a comment on issue #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#issuecomment-484757984 Update the PR including: * Rename `removeJoin` to `canRemoveJoin` * Use `RexUtil#shift` to transform

[GitHub] [calcite] chunweilei commented on issue #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
chunweilei commented on issue #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#issuecomment-484757984 Update the PR including: * Rename `removeJoin` to `canRemoveJoin` * Use `RexUtil#shift` to transform expressions

[GitHub] [calcite] chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276887623 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinJoinRemoveRule.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276887497 ## File path: core/src/main/java/org/apache/calcite/rel/rules/AggregateJoinJoinRemoveRule.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276887530 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinJoinRemoveRule.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276887509 ## File path: core/src/main/java/org/apache/calcite/rel/rules/AggregateJoinJoinRemoveRule.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276887310 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@ -735,6

[GitHub] [calcite] chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
chunweilei commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276887188 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@ -735,6

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

2019-04-18 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276663148 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[calcite] branch master updated: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true (Ruben Quesada Lopez)

2019-04-18 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 8982925 [CALCITE-2865]

[GitHub] [calcite] zabetak merged pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-04-18 Thread GitBox
zabetak merged pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130 This is an automated message from the

[GitHub] [calcite] hsyuan commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
hsyuan commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276744020 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@ -735,6

[GitHub] [calcite] hsyuan commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
hsyuan commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276745034 ## File path: core/src/main/java/org/apache/calcite/rel/rules/AggregateJoinJoinRemoveRule.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
hsyuan commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276744222 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@ -735,6

[GitHub] [calcite] hsyuan commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join

2019-04-18 Thread GitBox
hsyuan commented on a change in pull request #1160: [CALCITE-2712] Add rule to eliminate unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#discussion_r276743099 ## File path: core/src/main/java/org/apache/calcite/rel/rules/AggregateJoinJoinRemoveRule.java

[GitHub] [calcite] rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276736102 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276735774 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276735138 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276734751 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276734115 ## File path:

[GitHub] [calcite] vineetgarg02 commented on a change in pull request #1172: [CALCITE-3007] Type mismatch for ANY subquery in project (Vineet Garg)

2019-04-18 Thread GitBox
vineetgarg02 commented on a change in pull request #1172: [CALCITE-3007] Type mismatch for ANY subquery in project (Vineet Garg) URL: https://github.com/apache/calcite/pull/1172#discussion_r276717705 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

[GitHub] [calcite] nishantmonu51 commented on a change in pull request #1174: [CALCITE-3001] Upgrade to Apache Druid 0.14.0-incubating

2019-04-18 Thread GitBox
nishantmonu51 commented on a change in pull request #1174: [CALCITE-3001] Upgrade to Apache Druid 0.14.0-incubating URL: https://github.com/apache/calcite/pull/1174#discussion_r276709067 ## File path: druid/src/test/java/org/apache/calcite/test/DruidAdapterIT.java ## @@

[calcite] branch master updated: [CALCITE-3006] Example code on site cannot compile (Chunwei Lei)

2019-04-18 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 41df09c [CALCITE-3006] Example code on site

[GitHub] [calcite] hsyuan merged pull request #1173: [CALCITE-3006] Example code on site cannot compile

2019-04-18 Thread GitBox
hsyuan merged pull request #1173: [CALCITE-3006] Example code on site cannot compile URL: https://github.com/apache/calcite/pull/1173 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] chunweilei commented on issue #1167: [CALCITE-3009] It should fail if there are duplicate keys in a .xml file

2019-04-18 Thread GitBox
chunweilei commented on issue #1167: [CALCITE-3009] It should fail if there are duplicate keys in a .xml file URL: https://github.com/apache/calcite/pull/1167#issuecomment-484537960 @julianhyde could you please review this PR? Appreciate it.

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

2019-04-18 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276663148 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276568835 ## File path:

[GitHub] [calcite] nishantmonu51 opened a new pull request #1174: [CALCITE-3001] Upgrade to Apache Druid 0.14.0-incubating

2019-04-18 Thread GitBox
nishantmonu51 opened a new pull request #1174: [CALCITE-3001] Upgrade to Apache Druid 0.14.0-incubating URL: https://github.com/apache/calcite/pull/1174 Depends on https://github.com/vlsi/calcite-test-dataset/pull/30 This is

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

2019-04-18 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276625244 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

2019-04-18 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276625244 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

2019-04-18 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276625244 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

2019-04-18 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276611604 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276601185 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276601185 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276599667 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276591409 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276591409 ## File path:

[GitHub] [calcite] julianhyde commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

2019-04-18 Thread GitBox
julianhyde commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276577645 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java ##

[GitHub] [calcite] rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276568835 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276564619 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276564619 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276558022 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230,6

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276557077 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276553754 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-18 Thread GitBox
hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276553183 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@