[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277534862 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@ -52,

[GitHub] [calcite] chunweilei commented on issue #1166: [CALCITE-3004] RexOver is incorrectly pushed down in ProjectSetOpTran…

2019-04-22 Thread GitBox
chunweilei commented on issue #1166: [CALCITE-3004] RexOver is incorrectly pushed down in ProjectSetOpTran… URL: https://github.com/apache/calcite/pull/1166#issuecomment-485652209 Updated for resolving conflicts. This is an a

[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-485650820 @zabetak I modified the tests to verify that the `RexCopier` works correctly. Please review it again. Thanks. --

[calcite-avatica] branch master updated (8482516 -> 5c754cf)

2019-04-22 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git. discard 8482516 [CALCITE-2939] NPE when executeBatch array type. discard 6e38038 [CALCITE-2939] NPE when e

[GitHub] [calcite-avatica] F21 merged pull request #94: [CALCITE-2939] NPE when executeBatch array type.

2019-04-22 Thread GitBox
F21 merged pull request #94: [CALCITE-2939] NPE when executeBatch array type. URL: https://github.com/apache/calcite-avatica/pull/94 This is an automated message from the Apache Git Service. To respond to the message, please

[calcite-avatica] branch master updated (4ad09fa -> 8482516)

2019-04-22 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git. from 4ad09fa Fix misspelled JDBC connection max duration property: expiryduration (Lanny) new 6e380

[GitHub] [calcite-avatica] F21 commented on issue #94: [CALCITE-2939] NPE when executeBatch array type.

2019-04-22 Thread GitBox
F21 commented on issue #94: [CALCITE-2939] NPE when executeBatch array type. URL: https://github.com/apache/calcite-avatica/pull/94#issuecomment-485636738 @danny0405 Can you look at the updated changes? This is an automated me

[GitHub] [calcite-avatica] F21 commented on issue #95: fix:spell error

2019-04-22 Thread GitBox
F21 commented on issue #95: fix:spell error URL: https://github.com/apache/calcite-avatica/pull/95#issuecomment-485636621 This is merged as 4ad09fa0758ba482f216e5c3bf1a7a2d65fe0392 This is an automated message from the Apache

[GitHub] [calcite-avatica] F21 closed pull request #95: fix:spell error

2019-04-22 Thread GitBox
F21 closed pull request #95: fix:spell error URL: https://github.com/apache/calcite-avatica/pull/95 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] vineetgarg02 commented on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

2019-04-22 Thread GitBox
vineetgarg02 commented on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#issuecomment-485636532 @jcamachor I have disable the FULL OUTER JOIN as there is an existing issue. I'll enable it once CALCITE-3012 is f

[GitHub] [calcite] vineetgarg02 edited a comment on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

2019-04-22 Thread GitBox
vineetgarg02 edited a comment on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#issuecomment-485636532 @jcamachor I have disabled the FULL OUTER JOIN as there is an existing issue. I'll enable it once CALCITE-3

[calcite-avatica] branch master updated: Fix misspelled JDBC connection max duration property: expiryduration (Lanny)

2019-04-22 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new 4ad09fa Fix misspelled JDBC con

[GitHub] [calcite] vineetgarg02 edited a comment on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

2019-04-22 Thread GitBox
vineetgarg02 edited a comment on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#issuecomment-485636317 > query and comment don't match. Thanks~ Haisheng Yuan Thanks for noticing this. I have fixed it and

[GitHub] [calcite] vineetgarg02 commented on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

2019-04-22 Thread GitBox
vineetgarg02 commented on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#issuecomment-485636317 > query and comment don't match. Thanks~ Haisheng Yuan--- Thanks for no

[GitHub] [calcite] hsyuan commented on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

2019-04-22 Thread GitBox
hsyuan commented on issue #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#issuecomment-485632898 query and comment don't match. Thanks~ Haisheng Yuan--

[GitHub] [calcite] vineetgarg02 commented on a change in pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

2019-04-22 Thread GitBox
vineetgarg02 commented on a change in pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#discussion_r277509165 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] XuMingmin removed a comment on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream

2019-04-22 Thread GitBox
XuMingmin removed a comment on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream URL: https://github.com/apache/calcite/pull/1127#issuecomment-485571737 retest This is an automated message from the Apache Git Service.

[GitHub] [calcite] XuMingmin commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream

2019-04-22 Thread GitBox
XuMingmin commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream URL: https://github.com/apache/calcite/pull/1127#issuecomment-485571737 retest This is an automated message from the Apache Git Service. To respo

[GitHub] [calcite] julianhyde commented on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-22 Thread GitBox
julianhyde commented on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#issuecomment-485488591 I have reviewed. I'll make comments in the JIRA case. -

[GitHub] [calcite] chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277324374 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ##

[GitHub] [calcite] chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277311551 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@ -

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277286713 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@ -52,

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-22 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r277288371 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ## @@

[calcite] branch master updated: [CALCITE-3010] In SQL parser, move JsonValueExpression into Expression

2019-04-22 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 02eb106 [CALCITE-3010] In SQL parser, move Jso

[GitHub] [calcite] zhztheplayer merged pull request #1175: [CALCITE-3010] In SQL parser, move JsonValueExpression into Expression

2019-04-22 Thread GitBox
zhztheplayer merged pull request #1175: [CALCITE-3010] In SQL parser, move JsonValueExpression into Expression URL: https://github.com/apache/calcite/pull/1175 This is an automated message from the Apache Git Service. To res