[GitHub] [calcite] praveenbingo commented on issue #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data …

praveenbingo commented on issue #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data … URL: https://github.com/apache/calcite/pull/1859#issuecomment-604246510 > > @danny0405 This is similar to #1311 which made some of the other decimal related rules

[GitHub] [calcite] XuQianJin-Stars commented on issue #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

XuQianJin-Stars commented on issue #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#issuecomment-604232418 hi, @ritesh-kapoor Can this PR add a description? This is an

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

XuQianJin-Stars commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#discussion_r398304749 ## File path: core/src/main/java/org/apache/calcite/runtime/CompressionFunctions.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

danny0405 commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r398304160 ## File path: core/build.gradle.kts ## @@ -41,7 +41,6 @@ dependencie

[GitHub] [calcite] danny0405 commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision exc

danny0405 commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision exceeding max length of Oracle URL: https://github.com/apache/calcite/pull/1861#discussion_r398303679 ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision exc

danny0405 commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision exceeding max length of Oracle URL: https://github.com/apache/calcite/pull/1861#discussion_r398303679 ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

hsyuan commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r398303036 ## File path: core/src/main/java/org/apache/calcite/util/ReflectUtil.java ##

[GitHub] [calcite] wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision ex

wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision exceeding max length of Oracle URL: https://github.com/apache/calcite/pull/1861#discussion_r398299807 ##

[GitHub] [calcite] wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision ex

wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision exceeding max length of Oracle URL: https://github.com/apache/calcite/pull/1861#discussion_r398299547 ##

[GitHub] [calcite] DonnyZone commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

DonnyZone commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#discussion_r398296250 ## File path: core/src/main/java/org/apache/calcite/runtime/CompressionFunctions.java ## @@ -62,4

[GitHub] [calcite] neoremind commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

neoremind commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r398291034 ## File path: core/src/main/java/org/apache/calcite/util/ReflectUtil.java ###

[GitHub] [calcite] neoremind commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

neoremind commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r398291034 ## File path: core/src/main/java/org/apache/calcite/util/ReflectUtil.java ###

[GitHub] [calcite] danny0405 merged pull request #1872: [CALCITE-3871] Remove dependency of org.apiguardian:apiguardian-api

danny0405 merged pull request #1872: [CALCITE-3871] Remove dependency of org.apiguardian:apiguardian-api URL: https://github.com/apache/calcite/pull/1872 This is an automated message from the Apache Git Service. To respond t

[calcite] branch master updated: [CALCITE-3871] Remove dependency of org.apiguardian:apiguardian-api

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new ebbba56 [CALCITE-3871] Remove dependency of

[GitHub] [calcite] hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner

hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398241191 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java #

[GitHub] [calcite] hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner

hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398241191 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java #

[GitHub] [calcite] hsyuan commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

hsyuan commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r398234467 ## File path: core/src/main/java/org/apache/calcite/util/ReflectUtil.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner

hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398182889 ## File path: core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r398088521 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r398088611 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java ##

[GitHub] [calcite] neoremind opened a new pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

neoremind opened a new pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875 By examining a simple query through flame graph (see [issue](https://issues.apache.org/jira/browse/CALCITE-3873)), one

[GitHub] [calcite] DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function

DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862#issuecomment-603832001 +1, LGTM This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] danny0405 commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ

danny0405 commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r397832408 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.

[GitHub] [calcite-avatica] vlsi opened a new pull request #120: Update Gradle: 6.1.1 -> 6.3

vlsi opened a new pull request #120: Update Gradle: 6.1.1 -> 6.3 URL: https://github.com/apache/calcite-avatica/pull/120 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[calcite] branch master updated (c60f675 -> 989fc12)

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from c60f675 Update Gradle: 6.1.1 -> 6.3 add 989fc12 [CALCITE-3660] Disable PigRelBuilderStyleTest#test

[calcite] branch master updated (ffcfb92 -> c60f675)

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from ffcfb92 [CALCITE-3829] MergeJoinEnumerator should not use inputs enumerators until it is really required

[GitHub] [calcite] vlsi merged pull request #1874: Update Gradle: 6.1.1 -> 6.3

vlsi merged pull request #1874: Update Gradle: 6.1.1 -> 6.3 URL: https://github.com/apache/calcite/pull/1874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] wenhuitang commented on issue #1862: [CALCITE-3864] Implement Concat function

wenhuitang commented on issue #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862#issuecomment-603802313 Comments has been addressed, and reference.md has been updated too. This is

[GitHub] [calcite] wenhuitang commented on a change in pull request #1862: [CALCITE-3864] Implement Concat function

wenhuitang commented on a change in pull request #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862#discussion_r397801950 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ## @@ -332,6 +33

[GitHub] [calcite] vvysotskyi commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ

vvysotskyi commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r397800959 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil

[GitHub] [calcite] danny0405 commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ

danny0405 commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r397766734 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.

[GitHub] [calcite] DonnyZone commented on a change in pull request #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data …

DonnyZone commented on a change in pull request #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data … URL: https://github.com/apache/calcite/pull/1859#discussion_r397756517 ## File path: core/src/main/java/org/apache/calcite/rel/type/RelData

[GitHub] [calcite] DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inferenc

DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#discussion_r397748715

[GitHub] [calcite] DonnyZone commented on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOper

DonnyZone commented on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#issuecomment-603760540 Moreover, (1) a

[GitHub] [calcite] DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inferenc

DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#discussion_r397741431

[GitHub] [calcite] danny0405 edited a comment on issue #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data …

danny0405 edited a comment on issue #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data … URL: https://github.com/apache/calcite/pull/1859#issuecomment-603748315 > @danny0405 This is similar to #1311 which made some of the other decimal related rule

[GitHub] [calcite] danny0405 commented on issue #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data …

danny0405 commented on issue #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data … URL: https://github.com/apache/calcite/pull/1859#issuecomment-603748315 > @danny0405 This is similar to #1311 which made some of the other decimal related rules confi

[GitHub] [calcite] vlsi opened a new pull request #1874: Update Gradle: 6.1.1 -> 6.3

vlsi opened a new pull request #1874: Update Gradle: 6.1.1 -> 6.3 URL: https://github.com/apache/calcite/pull/1874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [calcite] DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inferenc

DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#discussion_r397714763

[GitHub] [calcite] DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inferenc

DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#discussion_r397713213

[GitHub] [calcite] DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inferenc

DonnyZone commented on a change in pull request #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#discussion_r397711754

[GitHub] [calcite] praveenbingo commented on a change in pull request #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data …

praveenbingo commented on a change in pull request #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data … URL: https://github.com/apache/calcite/pull/1859#discussion_r397710842 ## File path: core/src/main/java/org/apache/calcite/rel/type/RelD

[GitHub] [calcite] wenhuitang commented on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOpe

wenhuitang commented on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#issuecomment-603733532 > There is no

[GitHub] [calcite] DonnyZone commented on a change in pull request #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data …

DonnyZone commented on a change in pull request #1859: [CALCITE-3863] Make Truncate/Round return type inference overridable through rel data … URL: https://github.com/apache/calcite/pull/1859#discussion_r397681534 ## File path: core/src/main/java/org/apache/calcite/rel/type/RelData

[GitHub] [calcite] liyafan82 opened a new pull request #1873: [CALCITE-3872] Simplify expressions with unary minus

liyafan82 opened a new pull request #1873: [CALCITE-3872] Simplify expressions with unary minus URL: https://github.com/apache/calcite/pull/1873 Support simplifying expression - ( - ( x ) ) as x. This is an automated message

[GitHub] [calcite] DonnyZone commented on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOper

DonnyZone commented on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION URL: https://github.com/apache/calcite/pull/1862#issuecomment-603674884 There is no con