[GitHub] [calcite] DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function

DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862#issuecomment-604812196 In [CALCITE-3235](https://issues.apache.org/jira/browse/CALCITE-3235), `CONCAT` function with var args is added but not implemented (i.e., the

[GitHub] [calcite] neoremind commented on issue #1876: [CALCITE-3878] Make ArrayList creation with initial capacity when size is fixed

neoremind commented on issue #1876: [CALCITE-3878] Make ArrayList creation with initial capacity when size is fixed URL: https://github.com/apache/calcite/pull/1876#issuecomment-604806498 @chunweilei Thanks for reminding as well. I have replied Julian in JIRA. -

[GitHub] [calcite] liyafan82 commented on a change in pull request #1873: [CALCITE-3872] Simplify expressions with unary minus

liyafan82 commented on a change in pull request #1873: [CALCITE-3872] Simplify expressions with unary minus URL: https://github.com/apache/calcite/pull/1873#discussion_r399025357 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -2265,8 +226

[GitHub] [calcite] chunweilei commented on a change in pull request #1862: [CALCITE-3864] Implement Concat function

chunweilei commented on a change in pull request #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862#discussion_r399014279 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ## @@ -2169,6 +217

[GitHub] [calcite] hsyuan commented on issue #1876: [CALCITE-3878] Make ArrayList creation with initial capacity when size is fixed

hsyuan commented on issue #1876: [CALCITE-3878] Make ArrayList creation with initial capacity when size is fixed URL: https://github.com/apache/calcite/pull/1876#issuecomment-604794008 I didn't notice it. Thanks for reminding. ---

[GitHub] [calcite] chunweilei commented on a change in pull request #1866: [CALCITE-3726] Documentation for Declaring Objects For Types Defined …

chunweilei commented on a change in pull request #1866: [CALCITE-3726] Documentation for Declaring Objects For Types Defined … URL: https://github.com/apache/calcite/pull/1866#discussion_r399013717 ## File path: site/_docs/reference.md ## @@ -2804,6 +2805,44 @@ To enable,

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

ritesh-kapoor commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#discussion_r399011539 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ## @@ -

[GitHub] [calcite] chunweilei commented on a change in pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values

chunweilei commented on a change in pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values URL: https://github.com/apache/calcite/pull/1870#discussion_r399011127 ## File path: core/src/test/java/org/apache/calcite/test/enumerable

[GitHub] [calcite] chunweilei commented on a change in pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values

chunweilei commented on a change in pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values URL: https://github.com/apache/calcite/pull/1870#discussion_r399010788 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/Enumer

[GitHub] [calcite] DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function

DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862#issuecomment-604791073 Close and reopen to trigger the checks. This is an automated message from the

[GitHub] [calcite] wenhuitang opened a new pull request #1862: [CALCITE-3864] Implement Concat function

wenhuitang opened a new pull request #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862 Pull request for https://issues.apache.org/jira/browse/CALCITE-3864 This is an automated me

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1866: [CALCITE-3726] Documentation for Declaring Objects For Types Defined …

ritesh-kapoor commented on a change in pull request #1866: [CALCITE-3726] Documentation for Declaring Objects For Types Defined … URL: https://github.com/apache/calcite/pull/1866#discussion_r399010216 ## File path: site/_docs/reference.md ## @@ -2290,7 +2290,32 @@ Note: #

[GitHub] [calcite] DonnyZone closed pull request #1862: [CALCITE-3864] Implement Concat function

DonnyZone closed pull request #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] DonnyZone commented on issue #1405: [CALCITE-2772] Support varargs UDF for scalar function

DonnyZone commented on issue #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#issuecomment-604790132 Hi @gr4ve, to solve the conflicts, you need to rebase this pr on latest calcite/master branch. --

[GitHub] [calcite] chunweilei commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ

chunweilei commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r399008307 ## File path: core/src/test/java/org/apache/calcite/util/Smalls

[GitHub] [calcite] chunweilei commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ

chunweilei commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r399008307 ## File path: core/src/test/java/org/apache/calcite/util/Smalls

[GitHub] [calcite] chunweilei commented on a change in pull request #1868: [CALCITE-3867] Support RelDistribution json serialization

chunweilei commented on a change in pull request #1868: [CALCITE-3867] Support RelDistribution json serialization URL: https://github.com/apache/calcite/pull/1868#discussion_r399006271 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java ## @@ -

[GitHub] [calcite] danny0405 commented on a change in pull request #1866: [CALCITE-3726] Documentation for Declaring Objects For Types Defined …

danny0405 commented on a change in pull request #1866: [CALCITE-3726] Documentation for Declaring Objects For Types Defined … URL: https://github.com/apache/calcite/pull/1866#discussion_r399003445 ## File path: site/_docs/reference.md ## @@ -2290,7 +2290,32 @@ Note:

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1866: [CALCITE-3726] Documentation for Declaring Objects For Types Defined …

ritesh-kapoor commented on a change in pull request #1866: [CALCITE-3726] Documentation for Declaring Objects For Types Defined … URL: https://github.com/apache/calcite/pull/1866#discussion_r399001957 ## File path: site/_docs/reference.md ## @@ -2286,6 +2286,17 @@ Note: *

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

XuQianJin-Stars commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#discussion_r399001523 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ## @@

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r399000697 ## File path: core/src/test/java/org/apache/calcite/test/UdfTest.java ## @@ -198,6 +235,19 @@

[GitHub] [calcite] DonnyZone commented on issue #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values

DonnyZone commented on issue #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values URL: https://github.com/apache/calcite/pull/1870#issuecomment-604781955 +1, LGTM This is an automated

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r399000506 ## File path: core/src/test/java/org/apache/calcite/util/Smalls.java ## @@ -253,7 +254,7 @@ publ

[GitHub] [calcite] DonnyZone commented on a change in pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values

DonnyZone commented on a change in pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values URL: https://github.com/apache/calcite/pull/1870#discussion_r399000418 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerab

[GitHub] [calcite] DonnyZone commented on a change in pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values

DonnyZone commented on a change in pull request #1870: [CALCITE-3846] EnumerableMergeJoin: wrong comparison of composite key with null values URL: https://github.com/apache/calcite/pull/1870#discussion_r399000418 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerab

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1873: [CALCITE-3872] Simplify expressions with unary minus

ritesh-kapoor commented on a change in pull request #1873: [CALCITE-3872] Simplify expressions with unary minus URL: https://github.com/apache/calcite/pull/1873#discussion_r39929 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -2265,8

[GitHub] [calcite] ritesh-kapoor commented on issue #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

ritesh-kapoor commented on issue #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#issuecomment-604780316 > hi, @ritesh-kapoor Can this PR add a description? Added.. Thanks ---

[GitHub] [calcite] ritesh-kapoor opened a new pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

ritesh-kapoor opened a new pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865 https://dev.mysql.com/doc/refman/8.0/en/encryption-functions.html#function_uncompress e.g.: SELECT UNCOMPRESS(COMPRESS('any string'

[GitHub] [calcite] ritesh-kapoor closed pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

ritesh-kapoor closed pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

ritesh-kapoor commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#discussion_r398998393 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ## @@ -

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

ritesh-kapoor commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#discussion_r398998091 ## File path: core/src/main/java/org/apache/calcite/runtime/CompressionFunctions.java ## @@ -

[GitHub] [calcite] neoremind commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner

neoremind commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398979529 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java ###

[GitHub] [calcite] hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner

hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398933698 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java ##

[GitHub] [calcite] vvysotskyi commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ

vvysotskyi commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r398808399 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTe

[GitHub] [calcite] neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-604520763 @vlsi I will try to add the benchmark. `MethodHandle` would be a good alternative, since it requires bo

[GitHub] [calcite] vlsi commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

vlsi commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-604506267 @neoremind , do you think you could add the jmh test to Calcite as well (see https://github.com/apache/calci

[GitHub] [calcite] vlsi closed pull request #1877: RAV-1502

vlsi closed pull request #1877: RAV-1502 URL: https://github.com/apache/calcite/pull/1877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [calcite] vlsi commented on issue #1877: RAV-1502

vlsi commented on issue #1877: RAV-1502 URL: https://github.com/apache/calcite/pull/1877#issuecomment-604504754 @sarbjeet805, it looks like the PR is for the wrong repository :-/ This is an automated message from the Apache Gi

[GitHub] [calcite] sarbjeet805 opened a new pull request #1877: RAV-1502

sarbjeet805 opened a new pull request #1877: RAV-1502 URL: https://github.com/apache/calcite/pull/1877 Support of log function for snowflake dialect added This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-604479873 @danny0405 jmh test result is as below. It shows by using reflection invocation to look up methods in e

[GitHub] [calcite] neoremind commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

neoremind commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r398636010 ## File path: core/src/main/java/org/apache/calcite/util/ReflectVisitDispatch

[GitHub] [calcite] danny0405 commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

danny0405 commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r398586118 ## File path: core/src/main/java/org/apache/calcite/util/ReflectVisitDispatch

[GitHub] [calcite] danny0405 commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ

danny0405 commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r398548086 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTes

[GitHub] [calcite] wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision ex

wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision exceeding max length of Oracle URL: https://github.com/apache/calcite/pull/1861#discussion_r398505227 ##

[GitHub] [calcite] wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision ex

wenhuitang commented on a change in pull request #1861: [CALCITE-3468] JDBC adapter may generate casts on Oracle for varchar without the precision and for char with the precision exceeding max length of Oracle URL: https://github.com/apache/calcite/pull/1861#discussion_r398505227 ##

[GitHub] [calcite] vvysotskyi commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ

vvysotskyi commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r398469196 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil

[GitHub] [calcite] vlsi commented on issue #1876: [CALCITE-3878] Make ArrayList creation with initial capacity when size is fixed

vlsi commented on issue #1876: [CALCITE-3878] Make ArrayList creation with initial capacity when size is fixed URL: https://github.com/apache/calcite/pull/1876#issuecomment-604344052 LGTM This is an automated message from the

[GitHub] [calcite] neoremind opened a new pull request #1876: [CALCITE-3878] Make ArrayList creation with initial capacity when size is fixed

neoremind opened a new pull request #1876: [CALCITE-3878] Make ArrayList creation with initial capacity when size is fixed URL: https://github.com/apache/calcite/pull/1876 I find many places in Calcite where `new ArrayList<>()` is used, if the list is expected to be immutable or not resizi

[GitHub] [calcite] wenhuitang opened a new pull request #1862: [CALCITE-3864] Implement Concat function

wenhuitang opened a new pull request #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862 Pull request for https://issues.apache.org/jira/browse/CALCITE-3864 This is an automated me

[GitHub] [calcite] DonnyZone closed pull request #1862: [CALCITE-3864] Implement Concat function

DonnyZone closed pull request #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] zabetak commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner

zabetak commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398410186 ## File path: core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java #

[GitHub] [calcite] neoremind commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

neoremind commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r398391089 ## File path: core/src/main/java/org/apache/calcite/util/ReflectUtil.java ###

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support

ritesh-kapoor commented on a change in pull request #1865: [CALCITE-3648] MySQL UNCOMPRESS function support URL: https://github.com/apache/calcite/pull/1865#discussion_r398385503 ## File path: site/_docs/reference.md ## @@ -2362,6 +2362,7 @@ semantics. | o p | TO_DATE(str

[GitHub] [calcite] hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner

hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398362363 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java ##

[GitHub] [calcite] neoremind commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner

neoremind commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398354625 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java ###