[GitHub] [calcite] libenchao commented on a diff in pull request #2889: [CALCITE-5253] Natural join fields validation partially broken after CALCITE-5171

libenchao commented on code in PR #2889: URL: https://github.com/apache/calcite/pull/2889#discussion_r984672791 ## core/src/main/java/org/apache/calcite/rel/type/RelCrossType.java: ## @@ -58,6 +58,15 @@ public RelCrossType( return false; } + /** + * Returns the

[GitHub] [calcite] asolimando commented on a diff in pull request #2889: [CALCITE-5253] Natural join fields validation partially broken after CALCITE-5171

asolimando commented on code in PR #2889: URL: https://github.com/apache/calcite/pull/2889#discussion_r984551995 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -6163,7 +6163,7 @@ private ImmutableList cube(ImmutableBitSet... sets) { /** Test case

[GitHub] [calcite] libenchao commented on a diff in pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

libenchao commented on code in PR #2813: URL: https://github.com/apache/calcite/pull/2813#discussion_r984656218 ## core/src/main/java/org/apache/calcite/rel/core/Project.java: ## @@ -137,20 +163,27 @@ protected Project(RelInput input) { * @param input Input * @param

[GitHub] [calcite] zabetak commented on a diff in pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

zabetak commented on code in PR #2813: URL: https://github.com/apache/calcite/pull/2813#discussion_r984488709 ## core/src/main/java/org/apache/calcite/rel/core/Project.java: ## @@ -137,20 +163,27 @@ protected Project(RelInput input) { * @param input Input * @param

[GitHub] [calcite] libenchao commented on a diff in pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

libenchao commented on code in PR #2813: URL: https://github.com/apache/calcite/pull/2813#discussion_r984403160 ## core/src/main/java/org/apache/calcite/rel/core/Project.java: ## @@ -137,20 +163,27 @@ protected Project(RelInput input) { * @param input Input * @param