[calcite] branch main updated: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL

This is an automated email from the ASF dual-hosted git repository. libenchao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 5bbbd18563 [CALCITE-5296] In a query with ROLLUP

[GitHub] [calcite] libenchao closed pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL

libenchao closed pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL URL: https://github.com/apache/calcite/pull/2920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [calcite] wojustme commented on a diff in pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL

wojustme commented on code in PR #2920: URL: https://github.com/apache/calcite/pull/2920#discussion_r990634393 ## core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java: ## @@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) { String sql = "

[GitHub] [calcite] wojustme commented on a diff in pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL

wojustme commented on code in PR #2920: URL: https://github.com/apache/calcite/pull/2920#discussion_r990634393 ## core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java: ## @@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) { String sql = "

[GitHub] [calcite] xuzifu666 commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch

xuzifu666 commented on PR #2933: URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282510 @danny0405 Teacher Chan, the api is not used in Calcite, want to refactor it throght remove it for other developers not use the api，thanks -- This is an automated message from the Ap

[GitHub] [calcite] xuzifu666 commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch

xuzifu666 commented on PR #2933: URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282070 > Sorry, I'm not a commiter to Apache Calcite and lack context to form an opinion on this change. get -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] xuzifu666 commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch

xuzifu666 commented on PR #2933: URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282002 @danny0405 Hi, teacher danny, the api is not used in Calcite，and want to remove it to aviod other developers use it. > Sorry, I'm not a commiter to Apache Calcite and lack context

[GitHub] [calcite] libenchao commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

libenchao commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r990619993 ## core/src/main/java/org/apache/calcite/rex/RexBuilder.java: ## @@ -1355,10 +1356,14 @@ public RexNode makeIn(RexNode arg, List ranges) { if (areAssignable(arg,

[GitHub] [calcite] bchapuis commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch

bchapuis commented on PR #2933: URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272279359 Sorry, I'm not a commiter to Apache Calcite and lack context to form an opinion on this change. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] xuzifu666 closed pull request #2934: remove unused method in Resources

xuzifu666 closed pull request #2934: remove unused method in Resources URL: https://github.com/apache/calcite/pull/2934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [calcite] xuzifu666 commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch

xuzifu666 commented on PR #2933: URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272265819 @bchapuis have a review please, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [calcite] xuzifu666 opened a new pull request, #2933: [Minor] Refactor Matcher class with remove removePartialMatch

xuzifu666 opened a new pull request, #2933: URL: https://github.com/apache/calcite/pull/2933 removePartialMatch is useless in Mather，and avoid be used by other function remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [calcite] abhishek-das-gupta commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

abhishek-das-gupta commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r990604610 ## core/src/main/java/org/apache/calcite/rex/RexBuilder.java: ## @@ -1355,10 +1356,14 @@ public RexNode makeIn(RexNode arg, List ranges) { if (areAssigna

[GitHub] [calcite] libenchao commented on a diff in pull request #2920: [CALCITE-5296] In a query with ROLLUP, validator wrongly infers that a column is NOT NULL

libenchao commented on code in PR #2920: URL: https://github.com/apache/calcite/pull/2920#discussion_r990601217 ## core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java: ## @@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) { String sql =