[GitHub] [calcite] Aitozi opened a new pull request, #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-18 Thread GitBox
Aitozi opened a new pull request, #3035: URL: https://github.com/apache/calcite/pull/3035 …elate Before fix the sql in test will be optimize to: ``` LogicalProject(ENAME=[$0], EMPNO=[$1], EMPNO_R=[$3], TYPE=[CASE(=($2, 'bounded'), 1, 2)])

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080688763 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -240,6 +281,17 @@ public MysqlSqlDialect(Context context) {

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080677876 ## core/src/main/java/org/apache/calcite/util/format/FormatModelElementAlias.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] olivrlee commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
olivrlee commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080644292 ## core/src/main/java/org/apache/calcite/util/format/FormatModelElementAlias.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080614602 ## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080608342 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -240,6 +281,17 @@ public MysqlSqlDialect(Context context) {

[GitHub] [calcite] mkou commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
mkou commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080572882 ## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] wnob commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-18 Thread GitBox
wnob commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1074030646 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] wnob commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-18 Thread GitBox
wnob commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1074027016 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4609,15 +4610,116 @@ SqlLiteral DateTimeLiteral() : } | { s = span(); } p = SimpleStringLiteral() { -

[GitHub] [calcite] tanclary commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tanclary commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073952163 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return

[GitHub] [calcite] tjbanghart commented on pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on PR #3034: URL: https://github.com/apache/calcite/pull/3034#issuecomment-1387591383 @tanclary yes I will add those. Thanks for reminding me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073950252 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return

[GitHub] [calcite] birschick-bq commented on pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-18 Thread GitBox
birschick-bq commented on PR #3031: URL: https://github.com/apache/calcite/pull/3031#issuecomment-1387586998 cc: @CassieLyu / @sunnie629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] tanclary commented on pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tanclary commented on PR #3034: URL: https://github.com/apache/calcite/pull/3034#issuecomment-1387559274 Should you add descriptions for the functions to reference.md? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] tanclary commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tanclary commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073936097 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return

[GitHub] [calcite] tjbanghart opened a new pull request, #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart opened a new pull request, #3034: URL: https://github.com/apache/calcite/pull/3034 Lays the groundwork for [CALCITE-2980](https://issues.apache.org/jira/browse/CALCITE-2980) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] tjbanghart closed pull request #3033: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart closed pull request #3033: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME URL: https://github.com/apache/calcite/pull/3033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] tjbanghart opened a new pull request, #3033: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart opened a new pull request, #3033: URL: https://github.com/apache/calcite/pull/3033 Lays the groundwork for [CALCITE-2980](https://issues.apache.org/jira/browse/CALCITE-2980) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] tanclary opened a new pull request, #3032: [CALCITE-5484] Implement BigQuery DATETIME_SUB()

2023-01-18 Thread GitBox
tanclary opened a new pull request, #3032: URL: https://github.com/apache/calcite/pull/3032 Add support for BigQuery's DATETIME_SUB() function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to