sonarcloud[bot] commented on PR #3292:
URL: https://github.com/apache/calcite/pull/3292#issuecomment-1624827518
Kudos, SonarCloud Quality Gate passed! [ {
checkSimplifyUnchange
ILuffZhe commented on code in PR #3296:
URL: https://github.com/apache/calcite/pull/3296#discussion_r1255219238
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -2458,6 +2458,79 @@ private SqlOperator getNoDeterministicOperator() {
checkSimplifyUnchan
This is an automated email from the ASF dual-hosted git repository.
asf-ci-deploy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite-site.git
The following commit(s) were added to refs/heads/main by this push:
new be0db0c79 Website deployed from
calcit
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch site
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/site by this push:
new d0165364fb Site: Add Dan Zou as committer
d0165
This is an automated email from the ASF dual-hosted git repository.
zoudan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new f38b2a89b4 Site: Add Dan Zou as committer
f38b2a89b
zoudan merged PR #3294:
URL: https://github.com/apache/calcite/pull/3294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apa
zoudan commented on code in PR #3290:
URL: https://github.com/apache/calcite/pull/3290#discussion_r1255153032
##
site/_docs/reference.md:
##
@@ -2752,6 +2752,8 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | FROM_BASE32(string)
julianhyde commented on PR #3234:
URL: https://github.com/apache/calcite/pull/3234#issuecomment-1624488746
If I were to make `safeDouble` always return true, would any tests fail?
If I wrote
```
boolean safeBoolean(boolean b) {
return b == true || b == false;
}
```
julianhyde commented on PR #3147:
URL: https://github.com/apache/calcite/pull/3147#issuecomment-1624482681
Is the new function class `SqlContainsSubstrFunction` necessary?
Thanks for adding javadoc in SqlFunctions. For future reference, `{@code ...
}` is slightly preferred over ` ...
ILuffZhe commented on code in PR #3296:
URL: https://github.com/apache/calcite/pull/3296#discussion_r1255066917
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -2458,6 +2458,79 @@ private SqlOperator getNoDeterministicOperator() {
checkSimplifyUnchan
julianhyde commented on PR #3296:
URL: https://github.com/apache/calcite/pull/3296#issuecomment-1624472758
Sorry about the CI failure. Yes it's because of the commit message.
Unfortunately `LintTest` cannot distinguish between commits in a PR and commits
on main.
--
This is an automated
sonarcloud[bot] commented on PR #3296:
URL: https://github.com/apache/calcite/pull/3296#issuecomment-1624436812
Kudos, SonarCloud Quality Gate passed! [ were added to refs/heads/main by this push:
new b8ffcce8ec [CALCITE-5780] Simplify '1 > x OR 1 <= x
NobiGo merged PR #3267:
URL: https://github.com/apache/calcite/pull/3267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apa
sonarcloud[bot] commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1624404155
Kudos, SonarCloud Quality Gate passed! [ {
}
}
sonarcloud[bot] commented on PR #3295:
URL: https://github.com/apache/calcite/pull/3295#issuecomment-1624126986
Kudos, SonarCloud Quality Gate passed! [ under one
tanclary commented on code in PR #3234:
URL: https://github.com/apache/calcite/pull/3234#discussion_r1254727378
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -1524,136 +1524,89 @@ public static int multiply(int b0, int b1) {
throw notArithmetic("
tanclary commented on code in PR #3234:
URL: https://github.com/apache/calcite/pull/3234#discussion_r1254726840
##
babel/src/test/resources/sql/big-query.iq:
##
@@ -600,6 +600,44 @@ FROM t;
!ok
!}
+#
+# SAFE
tanclary commented on code in PR #3234:
URL: https://github.com/apache/calcite/pull/3234#discussion_r1254727128
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -2305,6 +2308,30 @@ private static class LastDayImplementor extends
MethodNameImpl
sonarcloud[bot] commented on PR #3295:
URL: https://github.com/apache/calcite/pull/3295#issuecomment-1624041580
Kudos, SonarCloud Quality Gate passed! [
olivrlee commented on code in PR #3234:
URL: https://github.com/apache/calcite/pull/3234#discussion_r1254690373
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -1524,136 +1524,89 @@ public static int multiply(int b0, int b1) {
throw notArithmetic("
NobiGo commented on code in PR #3296:
URL: https://github.com/apache/calcite/pull/3296#discussion_r1254531435
##
core/src/test/resources/sql/misc.iq:
##
@@ -2400,4 +2400,124 @@ TS
1969-07-21 00:00:00
!ok
+!use scott
+!set outputformat mysql
+
+# [CALCITE-5769] Optimizing 'CA
NobiGo commented on code in PR #3296:
URL: https://github.com/apache/calcite/pull/3296#discussion_r1254529639
##
core/src/test/resources/sql/misc.iq:
##
@@ -2400,4 +2400,124 @@ TS
1969-07-21 00:00:00
!ok
+!use scott
+!set outputformat mysql
+
+# [CALCITE-5769] Optimizing 'CA
ILuffZhe commented on code in PR #3296:
URL: https://github.com/apache/calcite/pull/3296#discussion_r1254333066
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -2458,6 +2458,79 @@ private SqlOperator getNoDeterministicOperator() {
checkSimplifyUnchan
NobiGo commented on code in PR #3296:
URL: https://github.com/apache/calcite/pull/3296#discussion_r1254524763
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -2458,6 +2458,79 @@ private SqlOperator getNoDeterministicOperator() {
checkSimplifyUnchange
NobiGo commented on PR #3296:
URL: https://github.com/apache/calcite/pull/3296#issuecomment-1623774613
> Maybe we need to rerun CI?
Yes. This is because my commit info not f
sonarcloud[bot] commented on PR #3290:
URL: https://github.com/apache/calcite/pull/3290#issuecomment-1623711129
Kudos, SonarCloud Quality Gate passed! [
sonarcloud[bot] commented on PR #3290:
URL: https://github.com/apache/calcite/pull/3290#issuecomment-1623638847
Kudos, SonarCloud Quality Gate passed! [ {
f0.forEachLib
ILuffZhe commented on PR #3295:
URL: https://github.com/apache/calcite/pull/3295#issuecomment-1623572477
Hi @MasseGuillaume . I noticed that your PR contains someone else
codes(maybe it's due to the force push), can you adjust your patch？ So we can
proceed to the next step.
--
This is an
ILuffZhe commented on code in PR #3296:
URL: https://github.com/apache/calcite/pull/3296#discussion_r1254333049
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -2458,6 +2458,79 @@ private SqlOperator getNoDeterministicOperator() {
checkSimplifyUnchan
JiajunBernoulli commented on PR #3296:
URL: https://github.com/apache/calcite/pull/3296#issuecomment-1623456391
Maybe we need to rerun CI?
--
This is an automated message from the Apach
sonarcloud[bot] commented on PR #3292:
URL: https://github.com/apache/calcite/pull/3292#issuecomment-1623445699
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qual
zabetak commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1623394466
The only blocking thing for getting this PR merged is putting in place the
"Fast" and "Slow" bucket. The "Very Slow" bucket as well as finding and
reporting regressions can be tackled in
chucheng92 commented on PR #3297:
URL: https://github.com/apache/calcite/pull/3297#issuecomment-1623339828
> LGTM pending tests!
>
> By the way, I feel that using an entire library just for the sake of using
`isEmpty` in 2-3 places is an overkill. It would be great if we could get rid
sonarcloud[bot] commented on PR #3296:
URL: https://github.com/apache/calcite/pull/3296#issuecomment-1623275081
Kudos, SonarCloud Quality Gate passed! [
sonarcloud[bot] commented on PR #3297:
URL: https://github.com/apache/calcite/pull/3297#issuecomment-1623164559
Kudos, SonarCloud Quality Gate passed! [