l4wei commented on code in PR #3800:
URL: https://github.com/apache/calcite/pull/3800#discussion_r1618110308
##
core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java:
##
@@ -443,7 +443,8 @@ public static boolean mayBeSatisfiable(RexNode e) {
for (RexNode disju
caicancai commented on PR #3785:
URL: https://github.com/apache/calcite/pull/3785#issuecomment-2136377502
@YiwenWu If you have time, can you help me take a look at this PR? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
YiwenWu commented on code in PR #3800:
URL: https://github.com/apache/calcite/pull/3800#discussion_r1617310267
##
core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java:
##
@@ -443,7 +443,8 @@ public static boolean mayBeSatisfiable(RexNode e) {
for (RexNode dis
NobiGo merged PR #3798:
URL: https://github.com/apache/calcite/pull/3798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apa
This is an automated email from the ASF dual-hosted git repository.
xiong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 694b556a2e [CALCITE-6417] Map value constructor and
YiwenWu commented on code in PR #3800:
URL: https://github.com/apache/calcite/pull/3800#discussion_r1617310267
##
core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java:
##
@@ -443,7 +443,8 @@ public static boolean mayBeSatisfiable(RexNode e) {
for (RexNode dis
NobiGo commented on PR #3799:
URL: https://github.com/apache/calcite/pull/3799#issuecomment-2135026112
'Some checks were not seccessful' caused by the commit info 'Fix Code ...'
start with Fix. If no other question, I will rebase it and make sure all check
passed.
--
This is an automated
NobiGo commented on code in PR #3799:
URL: https://github.com/apache/calcite/pull/3799#discussion_r1617070947
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -3519,9 +3519,57 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM `foo
NobiGo commented on code in PR #3799:
URL: https://github.com/apache/calcite/pull/3799#discussion_r1617069969
##
core/src/main/java/org/apache/calcite/sql/dialect/SparkSqlDialect.java:
##
@@ -146,4 +152,15 @@ public SparkSqlDialect(SqlDialect.Context context) {
super.unpa
