Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

sonarcloud[bot] commented on PR #3839: URL: https://github.com/apache/calcite/pull/3839#issuecomment-2211620181 ## [](https://sonarclo

Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

caicancai commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r1667241861 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4202,67 +4205,55 @@ private static class LogicalNotImplementor extends AbstractR

Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

caicancai commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r1667241931 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4202,67 +4205,55 @@ private static class LogicalNotImplementor extends AbstractR

Re: [PR] [CALCITE-6451] Refine nullability of outputs for MINUS and INTERSECT [calcite]

NobiGo commented on code in PR #3845: URL: https://github.com/apache/calcite/pull/3845#discussion_r1667214622 ## core/src/test/java/org/apache/calcite/test/RelBuilderTest.java: ## @@ -2317,6 +2318,69 @@ private static RelNode groupIdRel(RelBuilder builder, boolean extra) {

Re: [PR] [CALCITE-6451] Refine nullability of outputs for MINUS and INTERSECT [calcite]

vbarua commented on PR #3845: URL: https://github.com/apache/calcite/pull/3845#issuecomment-2211519882 This interacts interestingly/poorly with the [IntersectToDistinctRule](https://github.com/apache/calcite/blob/8a96095a64bc1cc955438d219d5f1fbcbc5762b7/core/src/main/java/org/apache/calcite/

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/calcite/pull/3833#issuecomment-2211499933 ## [](https://sonarclo

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/calcite/pull/3833#issuecomment-2211493944 ## [](https://sonarclo

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667198231 ## core/src/main/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatter.java: ## @@ -38,90 +45,164 @@ public class PostgresqlDateTimeFormat

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667196614 ## core/src/main/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatter.java: ## @@ -38,90 +45,164 @@ public class PostgresqlDateTimeFormat

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667195994 ## core/src/test/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatterTest.java: ## @@ -1311,6 +1314,610 @@ void testEraLowerCaseWithDots(

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667195920 ## core/src/main/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatter.java: ## @@ -175,25 +272,37 @@ public class PostgresqlDateTimeForma

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667195711 ## core/src/main/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatter.java: ## @@ -142,6 +227,10 @@ public class PostgresqlDateTimeFormat

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667195592 ## core/src/main/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatter.java: ## @@ -132,6 +213,10 @@ public class PostgresqlDateTimeFormat

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667195459 ## core/src/main/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatter.java: ## @@ -38,90 +45,164 @@ public class PostgresqlDateTimeFormat

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667195566 ## core/src/main/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatter.java: ## @@ -38,90 +45,164 @@ public class PostgresqlDateTimeFormat

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/calcite/pull/3833#issuecomment-2211483376 ## [](https://sonarclo

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667195013 ## core/src/main/java/org/apache/calcite/util/format/postgresql/ChronoUnitEnum.java: ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667195089 ## core/src/main/java/org/apache/calcite/util/format/postgresql/PostgresqlDateTimeFormatter.java: ## @@ -38,90 +45,164 @@ public class PostgresqlDateTimeFormat

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

sonarcloud[bot] commented on PR #3837: URL: https://github.com/apache/calcite/pull/3837#issuecomment-2211467857 ## [](https://sonarclo

Re: [PR] [CALCITE-6451] Refine nullability of outputs for MINUS and INTERSECT [calcite]

vbarua commented on code in PR #3845: URL: https://github.com/apache/calcite/pull/3845#discussion_r1667181497 ## core/src/test/java/org/apache/calcite/test/RelBuilderTest.java: ## @@ -2317,6 +2318,69 @@ private static RelNode groupIdRel(RelBuilder builder, boolean extra) {

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667162816 ## core/src/main/java/org/apache/calcite/rex/RexSimplify.java: ## @@ -2381,6 +2384,53 @@ private static boolean canRollUp(TimeUnit outer, TimeUnit inner) { ret

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667157552 ## core/src/main/java/org/apache/calcite/util/format/postgresql/TimeZoneHoursFormatPattern.java: ## @@ -29,14 +30,57 @@ */ public class TimeZoneHoursFormatP

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667156649 ## core/src/main/java/org/apache/calcite/util/format/postgresql/RomanNumeralMonthFormatPattern.java: ## @@ -81,4 +82,49 @@ public RomanNumeralMonthFormatPatter

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667156415 ## core/src/main/java/org/apache/calcite/util/format/postgresql/NumberFormatPattern.java: ## @@ -143,4 +165,40 @@ protected String trimLeadingZeros(String valu

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667156123 ## core/src/main/java/org/apache/calcite/util/format/postgresql/NumberFormatPattern.java: ## @@ -27,13 +27,35 @@ * A format element that will produce a numbe

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667155524 ## core/src/main/java/org/apache/calcite/util/format/postgresql/EnumStringFormatPattern.java: ## @@ -31,12 +32,27 @@ public class EnumStringFormatPattern exten

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667155226 ## core/src/main/java/org/apache/calcite/util/format/postgresql/DateStringFormatPattern.java: ## @@ -40,19 +41,33 @@ public class DateStringFormatPattern exten

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667155875 ## core/src/main/java/org/apache/calcite/rel/metadata/RelMdMeasure.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667154972 ## core/src/main/java/org/apache/calcite/rel/RelNodes.java: ## @@ -49,6 +62,65 @@ public static int compareRels(RelNode[] rels0, RelNode[] rels1) { return 0;

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667150579 ## core/src/test/java/org/apache/calcite/test/RelBuilderTest.java: ## @@ -3279,6 +3280,126 @@ private static RelBuilder assertSize(RelBuilder b, assertThat(root

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667152373 ## core/src/main/java/org/apache/calcite/sql/validate/MeasureScope.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667151934 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -10189,11 +10405,6 @@ private static int prec(SqlOperator op) { @Test void testDummy(

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667148675 ## core/src/test/java/org/apache/calcite/test/RelBuilderTest.java: ## @@ -3279,6 +3280,126 @@ private static RelBuilder assertSize(RelBuilder b, assertThat(root

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667144856 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidator.java: ## @@ -887,6 +889,25 @@ interface Config { */ Config withIdentifierExpansion(bool

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667135907 ## core/src/main/java/org/apache/calcite/sql/validate/OrderByScope.java: ## @@ -74,31 +74,43 @@ public class OrderByScope extends DelegatingScope { // If it's a

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667112147 ## core/src/main/java/org/apache/calcite/rex/RexSimplify.java: ## @@ -2381,6 +2384,53 @@ private static boolean canRollUp(TimeUnit outer, TimeUnit inner) { ret

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667105885 ## core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java: ## @@ -1873,4 +1873,35 @@ public static boolean isValidDecimalValue(@Nullable BigDecimal value,

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667100594 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectMergeRule.java: ## @@ -174,8 +174,9 @@ public interface Config extends RelRule.Config { /** Defines an

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667098344 ## core/src/test/resources/sql/misc.iq: ## @@ -2261,7 +2261,8 @@ where extract(YEAR from "sqlTimestamp") IN (1969, 1970); !ok -!if (false) { +!use scott Review

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667097770 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5131,6 +5164,41 @@ void testBitGetFunc(SqlOperatorFixture f, String functionName

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667096730 ## core/src/main/java/org/apache/calcite/rel/rules/MeasureRules.java: ## @@ -0,0 +1,532 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667095366 ## core/src/main/java/org/apache/calcite/rel/metadata/RelMdMeasure.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667094558 ## core/src/main/java/org/apache/calcite/rel/metadata/RelMdMeasure.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667091232 ## core/src/main/java/org/apache/calcite/rel/metadata/BuiltInMetadata.java: ## @@ -837,7 +840,59 @@ interface Handler extends MetadataHandler { @Override defa

Re: [PR] Measure columns ("SELECT ... AS MEASURE") [calcite]

julianhyde commented on code in PR #3837: URL: https://github.com/apache/calcite/pull/3837#discussion_r1667090454 ## core/src/main/java/org/apache/calcite/rel/metadata/RelMdMeasure.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667034099 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4061,11 +4074,40 @@ public int toDate(String dateString, String fmtString) {

Re: [PR] [CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp [calcite]

normanj-bitquill commented on code in PR #3833: URL: https://github.com/apache/calcite/pull/3833#discussion_r1667030464 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4004,6 +4004,19 @@ public static long unixDateExtract(String rangeString, long date

Re: [PR] [CALCITE-6445] Add REVERSE function (enabled in Spark library) [calcite]

sonarcloud[bot] commented on PR #3830: URL: https://github.com/apache/calcite/pull/3830#issuecomment-2211051678 ## [](https://sonarclo

Re: [PR] [CALCITE-6445] Add REVERSE function (enabled in Spark library) [calcite]

YiwenWu commented on code in PR #3830: URL: https://github.com/apache/calcite/pull/3830#discussion_r1666777819 ## site/_docs/reference.md: ## @@ -2850,6 +2850,7 @@ In the following: | b | REGEXP_SUBSTR(string, regexp [, position [, occurrence]]) | Synonym for REGEXP_EXTRACT |

Re: [PR] [CALCITE-6445] Add REVERSE function (enabled in Spark library) [calcite]

YiwenWu commented on code in PR #3830: URL: https://github.com/apache/calcite/pull/3830#discussion_r1666777819 ## site/_docs/reference.md: ## @@ -2850,6 +2850,7 @@ In the following: | b | REGEXP_SUBSTR(string, regexp [, position [, occurrence]]) | Synonym for REGEXP_EXTRACT |

Re: [PR] [CALCITE-6445] Add REVERSE function (enabled in Spark library) [calcite]

YiwenWu commented on code in PR #3830: URL: https://github.com/apache/calcite/pull/3830#discussion_r1666777819 ## site/_docs/reference.md: ## @@ -2850,6 +2850,7 @@ In the following: | b | REGEXP_SUBSTR(string, regexp [, position [, occurrence]]) | Synonym for REGEXP_EXTRACT |

Re: [PR] [CALCITE-6445] Add REVERSE function (enabled in Spark library) [calcite]

YiwenWu commented on code in PR #3830: URL: https://github.com/apache/calcite/pull/3830#discussion_r1666764973 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7464,30 +7471,57 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias function

Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

caicancai commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r1666743174 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4202,67 +4205,55 @@ private static class LogicalNotImplementor extends AbstractR

Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

caicancai commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r1666743174 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4202,67 +4205,55 @@ private static class LogicalNotImplementor extends AbstractR

Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

YiwenWu commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r106536 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4202,67 +4205,55 @@ private static class LogicalNotImplementor extends AbstractRex

Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

YiwenWu commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r1666739823 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4202,67 +4205,55 @@ private static class LogicalNotImplementor extends AbstractRex

Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

YiwenWu commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r1666739823 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4202,67 +4205,55 @@ private static class LogicalNotImplementor extends AbstractRex

Re: [PR] [CALCITE-6312] Add LOG function (enabled in PostgreSQL library) [calcite]

YiwenWu commented on code in PR #3839: URL: https://github.com/apache/calcite/pull/3839#discussion_r106536 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4202,67 +4205,55 @@ private static class LogicalNotImplementor extends AbstractRex

(calcite) branch main updated: [CALCITE-6401] JDBC adapter cannot push down JOIN with condition includes IS TRUE、IS NULL、Dynamic parameter、CAST、Literal comparison

This is an automated email from the ASF dual-hosted git repository. xiong pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 8a96095a64 [CALCITE-6401] JDBC adapter cannot push d

Re: [PR] [CALCITE-6401] JDBC adapter cannot push down JOIN with condition includes IS TRUE、IS NULL、Dynamic parameter、CAST、Literal comparison [calcite]

NobiGo merged PR #3843: URL: https://github.com/apache/calcite/pull/3843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apa