[GitHub] [calcite] birschick-bq closed pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-20 Thread GitBox
birschick-bq closed pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric URL: https://github.com/apache/calcite/pull/3031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3038: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3038: URL: https://github.com/apache/calcite/pull/3038#issuecomment-1398008354 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] libenchao opened a new pull request, #3038: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-19 Thread GitBox
libenchao opened a new pull request, #3038: URL: https://github.com/apache/calcite/pull/3038 This PR is based on https://github.com/apache/calcite/pull/3031 from @birschick-bq -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] libenchao closed pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
libenchao closed pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr… URL: https://github.com/apache/calcite/pull/3035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2981: [CALCITE-5283] Add ARG_MIN, ARG_MAX aggregate functions

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #2981: URL: https://github.com/apache/calcite/pull/2981#issuecomment-1397858121 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3036: [CALCITE-5424] Custom literals

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3036: URL: https://github.com/apache/calcite/pull/3036#issuecomment-1397828527 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] olivrlee commented on a diff in pull request #3036: [CALCITE-5424] Custom literals

2023-01-19 Thread GitBox
olivrlee commented on code in PR #3036: URL: https://github.com/apache/calcite/pull/3036#discussion_r1082033615 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3036: [CALCITE-5424] Custom literals

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3036: URL: https://github.com/apache/calcite/pull/3036#issuecomment-1397815215 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
julianhyde commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081992148 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
julianhyde commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081983370 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] julianhyde merged pull request #202: (do not merge) avatica staging

2023-01-19 Thread GitBox
julianhyde merged PR #202: URL: https://github.com/apache/calcite-avatica/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081880447 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081852921 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081852921 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081880447 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081880447 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081852921 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081852921 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite] julianhyde commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-19 Thread GitBox
julianhyde commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1081846240 ## core/src/main/java/org/apache/calcite/sql/fun/SqlBigQueryFormatDatetimeFunction.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite] julianhyde commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-19 Thread GitBox
julianhyde commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1081843370 ## core/src/main/java/org/apache/calcite/sql/fun/SqlBigQueryFormatDatetimeFunction.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite] julianhyde commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-19 Thread GitBox
julianhyde commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1081837725 ## core/src/main/java/org/apache/calcite/sql/SqlDialect.java: ## @@ -1002,6 +1004,18 @@ protected static void unparseOffset(SqlWriter writer, @Nullable SqlNode

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
julianhyde commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081816343 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] wnob closed pull request #186: [CALCITE-5308] Add support for TIMESTAMP WITH LOCAL TIME ZONE and microsecond-precision

2023-01-19 Thread GitBox
wnob closed pull request #186: [CALCITE-5308] Add support for TIMESTAMP WITH LOCAL TIME ZONE and microsecond-precision URL: https://github.com/apache/calcite-avatica/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite-avatica] wnob commented on pull request #186: [CALCITE-5308] Add support for TIMESTAMP WITH LOCAL TIME ZONE and microsecond-precision

2023-01-19 Thread GitBox
wnob commented on PR #186: URL: https://github.com/apache/calcite-avatica/pull/186#issuecomment-1397531597 Superceded by https://github.com/apache/calcite-avatica/pull/205 which focuses just on the type support and punts on precision for now. -- This is an automated message from the

[GitHub] [calcite-avatica] wnob opened a new pull request, #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob opened a new pull request, #205: URL: https://github.com/apache/calcite-avatica/pull/205 This is a work-in-progress as there are still some tests failing, but I believe the proper semantics are now codified in `AvaticaResultSetConversionsTest`. Was hoping to get some early feedback to

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3035: URL: https://github.com/apache/calcite/pull/3035#issuecomment-1397056502 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] Aitozi commented on a diff in pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
Aitozi commented on code in PR #3035: URL: https://github.com/apache/calcite/pull/3035#discussion_r1081278261 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -3002,6 +3002,32 @@ private void

[GitHub] [calcite] libenchao commented on a diff in pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
libenchao commented on code in PR #3035: URL: https://github.com/apache/calcite/pull/3035#discussion_r1081180900 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -3002,6 +3002,32 @@ private void

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3035: URL: https://github.com/apache/calcite/pull/3035#issuecomment-1396589034 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] Aitozi opened a new pull request, #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-18 Thread GitBox
Aitozi opened a new pull request, #3035: URL: https://github.com/apache/calcite/pull/3035 …elate Before fix the sql in test will be optimize to: ``` LogicalProject(ENAME=[$0], EMPNO=[$1], EMPNO_R=[$3], TYPE=[CASE(=($2, 'bounded'), 1, 2)])

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080688763 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -240,6 +281,17 @@ public MysqlSqlDialect(Context context) {

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080677876 ## core/src/main/java/org/apache/calcite/util/format/FormatModelElementAlias.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] olivrlee commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
olivrlee commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080644292 ## core/src/main/java/org/apache/calcite/util/format/FormatModelElementAlias.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080614602 ## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080608342 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -240,6 +281,17 @@ public MysqlSqlDialect(Context context) {

[GitHub] [calcite] mkou commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
mkou commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080572882 ## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] wnob commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-18 Thread GitBox
wnob commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1074030646 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] wnob commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-18 Thread GitBox
wnob commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1074027016 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4609,15 +4610,116 @@ SqlLiteral DateTimeLiteral() : } | { s = span(); } p = SimpleStringLiteral() { -

[GitHub] [calcite] tanclary commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tanclary commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073952163 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return

[GitHub] [calcite] tjbanghart commented on pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on PR #3034: URL: https://github.com/apache/calcite/pull/3034#issuecomment-1387591383 @tanclary yes I will add those. Thanks for reminding me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073950252 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return

[GitHub] [calcite] birschick-bq commented on pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-18 Thread GitBox
birschick-bq commented on PR #3031: URL: https://github.com/apache/calcite/pull/3031#issuecomment-1387586998 cc: @CassieLyu / @sunnie629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] tanclary commented on pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tanclary commented on PR #3034: URL: https://github.com/apache/calcite/pull/3034#issuecomment-1387559274 Should you add descriptions for the functions to reference.md? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] tanclary commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tanclary commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073936097 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return

[GitHub] [calcite] tjbanghart opened a new pull request, #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart opened a new pull request, #3034: URL: https://github.com/apache/calcite/pull/3034 Lays the groundwork for [CALCITE-2980](https://issues.apache.org/jira/browse/CALCITE-2980) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] tjbanghart closed pull request #3033: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart closed pull request #3033: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME URL: https://github.com/apache/calcite/pull/3033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] tjbanghart opened a new pull request, #3033: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart opened a new pull request, #3033: URL: https://github.com/apache/calcite/pull/3033 Lays the groundwork for [CALCITE-2980](https://issues.apache.org/jira/browse/CALCITE-2980) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] tanclary opened a new pull request, #3032: [CALCITE-5484] Implement BigQuery DATETIME_SUB()

2023-01-18 Thread GitBox
tanclary opened a new pull request, #3032: URL: https://github.com/apache/calcite/pull/3032 Add support for BigQuery's DATETIME_SUB() function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3031: URL: https://github.com/apache/calcite/pull/3031#issuecomment-1386252119 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-17 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1072911432 ## babel/src/test/resources/sql/big-query.iq: ## @@ -1097,12 +1097,74 @@ select unix_date(datetime '2008-12-25') as d; # # Return Data Type: DATE -select

[GitHub] [calcite] birschick-bq commented on a diff in pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-17 Thread GitBox
birschick-bq commented on code in PR #3031: URL: https://github.com/apache/calcite/pull/3031#discussion_r1072879759 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectAggregateMergeRule.java: ## @@ -99,7 +100,8 @@ && kindCount(project.getProjects(), SqlKind.CASE) == 0) {

[GitHub] [calcite] clesaec commented on a diff in pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-17 Thread GitBox
clesaec commented on code in PR #3031: URL: https://github.com/apache/calcite/pull/3031#discussion_r1072284872 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectAggregateMergeRule.java: ## @@ -99,7 +100,8 @@ && kindCount(project.getProjects(), SqlKind.CASE) == 0) {

[GitHub] [calcite] zabetak closed pull request #3027: [CALCITE-5475] Improve test coverage accuracy by aggregating modules

2023-01-17 Thread GitBox
zabetak closed pull request #3027: [CALCITE-5475] Improve test coverage accuracy by aggregating modules URL: https://github.com/apache/calcite/pull/3027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #3031: URL: https://github.com/apache/calcite/pull/3031#issuecomment-1384684549 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] julianhyde closed pull request #3013: CALCITE-5451 / Implement LPAD() and RPAD()

2023-01-16 Thread GitBox
julianhyde closed pull request #3013: CALCITE-5451 / Implement LPAD() and RPAD() URL: https://github.com/apache/calcite/pull/3013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2942: (do not merge)

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2942: URL: https://github.com/apache/calcite/pull/2942#issuecomment-1384677595 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] birschick-bq opened a new pull request, #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-16 Thread GitBox
birschick-bq opened a new pull request, #3031: URL: https://github.com/apache/calcite/pull/3031 Resolve issue with thrown exception if literal is non-numeric. https://issues.apache.org/jira/browse/CALCITE-5483 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] julianhyde commented on pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-16 Thread GitBox
julianhyde commented on PR #3023: URL: https://github.com/apache/calcite/pull/3023#issuecomment-1384675118 There's too much going on here for me to review. Can you separate it out into pieces that can be understood by an end user as adding some useful functionality? If there

[GitHub] [calcite] julianhyde closed pull request #2992: [CALCITE-5404] Implement BigQuery's POW() and TRUNC() math functions

2023-01-16 Thread GitBox
julianhyde closed pull request #2992: [CALCITE-5404] Implement BigQuery's POW() and TRUNC() math functions URL: https://github.com/apache/calcite/pull/2992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2942: (do not merge)

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2942: URL: https://github.com/apache/calcite/pull/2942#issuecomment-1384596408 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada merged pull request #3026: [CALCITE-5471] RelSupplier.SqlRelSupplier#apply should use .project(), not .rel

2023-01-16 Thread GitBox
rubenada merged PR #3026: URL: https://github.com/apache/calcite/pull/3026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3026: [CALCITE-5471] RelSupplier.SqlRelSupplier#apply should use .project(), not .rel

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #3026: URL: https://github.com/apache/calcite/pull/3026#issuecomment-1383852769 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3027: [CALCITE-5475] Improve test coverage accuracy by aggregating modules

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #3027: URL: https://github.com/apache/calcite/pull/3027#issuecomment-1383666026 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan commented on a diff in pull request #2981: [CALCITE-5283] Add ARG_MIN, ARG_MAX aggregate functions

2023-01-15 Thread GitBox
zoudan commented on code in PR #2981: URL: https://github.com/apache/calcite/pull/2981#discussion_r1070765927 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -1849,6 +1849,17 @@ public static > T greatest(T b0, T b1) { return b0 == null || b1 !=

[GitHub] [calcite-avatica] julianhyde closed pull request #179: [CALCITE-3557] ClassCastException for using nested multiset or array …

2023-01-15 Thread GitBox
julianhyde closed pull request #179: [CALCITE-3557] ClassCastException for using nested multiset or array … URL: https://github.com/apache/calcite-avatica/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite-avatica] julianhyde closed pull request #201: [CALCITE-5443] Reset update count when checking for more results

2023-01-15 Thread GitBox
julianhyde closed pull request #201: [CALCITE-5443] Reset update count when checking for more results URL: https://github.com/apache/calcite-avatica/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] dssysolyatin merged pull request #2974: [CALCITE-5209] Proper sub-query handling if it is used inside select list and group by

2023-01-15 Thread GitBox
dssysolyatin merged PR #2974: URL: https://github.com/apache/calcite/pull/2974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] libenchao commented on pull request #2974: [CALCITE-5209] Proper sub-query handling if it is used inside select list and group by

2023-01-15 Thread GitBox
libenchao commented on PR #2974: URL: https://github.com/apache/calcite/pull/2974#issuecomment-1383136327 LGTM~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2974: [CALCITE-5209] Proper sub-query handling if it is used inside select list and group by

2023-01-15 Thread GitBox
sonarcloud[bot] commented on PR #2974: URL: https://github.com/apache/calcite/pull/2974#issuecomment-1383109216 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2974: [CALCITE-5209] Proper sub-query handling if it is used inside select list and group by

2023-01-15 Thread GitBox
dssysolyatin commented on code in PR #2974: URL: https://github.com/apache/calcite/pull/2974#discussion_r1070548010 ## core/src/test/resources/sql/agg.iq: ## @@ -3467,4 +3467,38 @@ order by ename, deptno; !ok +# Test cases for [CALCITE-5209] ArrayIndexOutOfBoundsException

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2974: [CALCITE-5209] Proper sub-query handling if it is used inside select list and group by

2023-01-15 Thread GitBox
sonarcloud[bot] commented on PR #2974: URL: https://github.com/apache/calcite/pull/2974#issuecomment-1383106352 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] libenchao commented on a diff in pull request #2974: [CALCITE-5209] ArrayIndexOutOfBoundsException during SqlToRelConverter for group-by on `case` having `in` expression predicates

2023-01-14 Thread GitBox
libenchao commented on code in PR #2974: URL: https://github.com/apache/calcite/pull/2974#discussion_r1070491944 ## core/src/test/resources/sql/agg.iq: ## @@ -3467,4 +3467,38 @@ order by ename, deptno; !ok +# Test cases for [CALCITE-5209] ArrayIndexOutOfBoundsException

[GitHub] [calcite] libenchao commented on a diff in pull request #2932: [CALCITE-5304] RelJson should support RexSubQuery

2023-01-14 Thread GitBox
libenchao commented on code in PR #2932: URL: https://github.com/apache/calcite/pull/2932#discussion_r1070270379 ## core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java: ## @@ -122,10 +127,32 @@ public RelJson withInputTranslator(InputTranslator inputTranslator)

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3030: [CALCITE-5479] Adjust handling of iFormalOperand in sequence and interval checkers.

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #3030: URL: https://github.com/apache/calcite/pull/3030#issuecomment-1382697697 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3029: [CALCITE-5478] Use highest input precision for datetimes in SqlTypeFactoryImpl.leastRestrictive.

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #3029: URL: https://github.com/apache/calcite/pull/3029#issuecomment-1382695349 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] gianm opened a new pull request, #3030: [CALCITE-5479] Adjust handling of iFormalOperand in sequence and interval checkers.

2023-01-14 Thread GitBox
gianm opened a new pull request, #3030: URL: https://github.com/apache/calcite/pull/3030 1) Revert change from 33f4ab40bbee26e06209061c35a422f2f1e05371 that sent nonzero formal operands to any checkers in a sequence that are not FamilyOperandTypeChecker. 2) Adjust

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3028: [CALCITE-5477] Prefer Util.checkArgument over Preconditions.checkArgument

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #3028: URL: https://github.com/apache/calcite/pull/3028#issuecomment-1382693927 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] gianm opened a new pull request, #3029: [CALCITE-5478] Use highest input precision for datetimes in SqlTypeFactoryImpl.leastRestrictive.

2023-01-14 Thread GitBox
gianm opened a new pull request, #3029: URL: https://github.com/apache/calcite/pull/3029 Some code exists to do this for other types, but not datetimes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] julianhyde commented on pull request #3013: CALCITE-5451 / Implement LPAD() and RPAD()

2023-01-13 Thread GitBox
julianhyde commented on PR #3013: URL: https://github.com/apache/calcite/pull/3013#issuecomment-1382623925 Oops, I wrongly closed this. I meant to close #3003 instead. Reopening. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] julianhyde commented on pull request #3003: 5430/Add IFNULL() function for BIG_QUERY dialect

2023-01-13 Thread GitBox
julianhyde commented on PR #3003: URL: https://github.com/apache/calcite/pull/3003#issuecomment-1382622571 Merged as e426bd26. (The PR link in that commit is incorrect; it should point to this PR, 3003.) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] julianhyde closed pull request #3003: 5430/Add IFNULL() function for BIG_QUERY dialect

2023-01-13 Thread GitBox
julianhyde closed pull request #3003: 5430/Add IFNULL() function for BIG_QUERY dialect URL: https://github.com/apache/calcite/pull/3003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-13 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1070146181 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4609,15 +4610,116 @@ SqlLiteral DateTimeLiteral() : } | { s = span(); } p = SimpleStringLiteral() { -

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2942: (do not merge)

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #2942: URL: https://github.com/apache/calcite/pull/2942#issuecomment-1382468564 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] julianhyde closed pull request #3012: [CALCITE-5454] Update BigQuery Conformance for != and % operators

2023-01-13 Thread GitBox
julianhyde closed pull request #3012: [CALCITE-5454] Update BigQuery Conformance for != and % operators URL: https://github.com/apache/calcite/pull/3012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] julianhyde closed pull request #3013: CALCITE-5451 / Implement LPAD() and RPAD()

2023-01-13 Thread GitBox
julianhyde closed pull request #3013: CALCITE-5451 / Implement LPAD() and RPAD() URL: https://github.com/apache/calcite/pull/3013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] julianhyde closed pull request #3008: [CALCITE-5436] Implement DATE_SUB, TIME_SUB, TIMESTAMP_SUB (compatible w/ BigQuery)

2023-01-13 Thread GitBox
julianhyde closed pull request #3008: [CALCITE-5436] Implement DATE_SUB, TIME_SUB, TIMESTAMP_SUB (compatible w/ BigQuery) URL: https://github.com/apache/calcite/pull/3008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] julianhyde closed pull request #3011: [CALCITE-5452] Add BigQuery LENGTH() as synonym for CHAR_LENGTH()

2023-01-13 Thread GitBox
julianhyde closed pull request #3011: [CALCITE-5452] Add BigQuery LENGTH() as synonym for CHAR_LENGTH() URL: https://github.com/apache/calcite/pull/3011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] julianhyde closed pull request #3014: [CALCITE-5432] Implement BigQuery TIME_ADD() and TIME_DIFF()

2023-01-13 Thread GitBox
julianhyde closed pull request #3014: [CALCITE-5432] Implement BigQuery TIME_ADD() and TIME_DIFF() URL: https://github.com/apache/calcite/pull/3014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] julianhyde closed pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-13 Thread GitBox
julianhyde closed pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY URL: https://github.com/apache/calcite/pull/3009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-13 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1070115107 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-13 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1069975023 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2942: (do not merge)

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #2942: URL: https://github.com/apache/calcite/pull/2942#issuecomment-1382259823 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on pull request #3026: CALCITE-5471 RelSupplier.SqlRelSupplier#apply should use .project(), not .rel

2023-01-13 Thread GitBox
rubenada commented on PR #3026: URL: https://github.com/apache/calcite/pull/3026#issuecomment-1381655727 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3026: CALCITE-5471 RelSupplier.SqlRelSupplier#apply should use .project(), not .rel

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #3026: URL: https://github.com/apache/calcite/pull/3026#issuecomment-1381653736 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chunweilei commented on a diff in pull request #2932: [CALCITE-5304] RelJson should support RexSubQuery

2023-01-12 Thread GitBox
chunweilei commented on code in PR #2932: URL: https://github.com/apache/calcite/pull/2932#discussion_r1069024265 ## core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java: ## @@ -122,10 +127,32 @@ public RelJson withInputTranslator(InputTranslator inputTranslator)

[GitHub] [calcite] chunweilei commented on a diff in pull request #2981: [CALCITE-5283] Add ARG_MIN, ARG_MAX aggregate functions

2023-01-12 Thread GitBox
chunweilei commented on code in PR #2981: URL: https://github.com/apache/calcite/pull/2981#discussion_r1069003834 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -1849,6 +1849,17 @@ public static > T greatest(T b0, T b1) { return b0 == null || b1

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2942: (do not merge)

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #2942: URL: https://github.com/apache/calcite/pull/2942#issuecomment-1381202178 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [calcite] tanclary opened a new pull request, #3025: [CALCITE-5464] Implement BigQuery DATE_ADD/DATE_DIFF

2023-01-12 Thread GitBox
tanclary opened a new pull request, #3025: URL: https://github.com/apache/calcite/pull/3025 This is a draft PR for beginning work on BigQuery DATE_ADD() and DATE_DIFF() functions. DATE_ADD() is currently functioning as expected. DATE_DIFF() is facing a small issue where 'week' is not

[GitHub] [calcite] tanclary opened a new pull request, #3024: [CALCITE-5469] Implement BigQuery DATETIME_ADD/DATETIME_DIFF

2023-01-12 Thread GitBox
tanclary opened a new pull request, #3024: URL: https://github.com/apache/calcite/pull/3024 This is a beginning draft for the work to implement BigQuery DATETIME_ADD/DATETIME_DIFF. Currently, DATETIME_ADD is functioning as expected and is passing all operator and quidem tests.

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2991: [CALCITE-5407] Fix ARRAY conversion in MongoDB adapter

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #2991: URL: https://github.com/apache/calcite/pull/2991#issuecomment-1381192981 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

  1   2   3   4   5   6   7   8   9   10   >